René's URL Explorer Experiment


Title: bpo-27340: Use memoryview in SSLSocket.sendall() by tiran · Pull Request #3384 · python/cpython · GitHub

Open Graph Title: bpo-27340: Use memoryview in SSLSocket.sendall() by tiran · Pull Request #3384 · python/cpython

X Title: bpo-27340: Use memoryview in SSLSocket.sendall() by tiran · Pull Request #3384 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: SSLSocket.sendall() now uses memoryview to create slices of data. This fix support for all bytes-like object. It is also more efficient and avoids costly copies. Signed-off-by: Christian Heimes chr...

X Description: SSLSocket.sendall() now uses memoryview to create slices of data. This fix support for all bytes-like object. It is also more efficient and avoids costly copies. Signed-off-by: Christian Heimes chr...

Mail addresses
christian@python.org

Opengraph URL: https://github.com/python/cpython/pull/3384

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0aa75410-8fe1-6679-b37d-0f351973ac00
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id883A:18A536:BF85:F69F:6A525E2E
html-safe-nonce34e12eddfc91fe1ab1f2c5f090432d3ff2372929a07c1b6ccfdb1895a33a7818
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODNBOjE4QTUzNjpCRjg1OkY2OUY6NkE1MjVFMkUiLCJ2aXNpdG9yX2lkIjoiODcwOTk2NjcwNjIzMDA1ODU0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1167f7518833b71826c9c8db72dfd52f6032718dd3623be3753a26bb24240e37
hovercard-subject-tagpull_request:139568864
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3384/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4047c540b75b1f10e307f8c428745c755d8c61edca4391a1b9b5579e1b43ae0a/python/cpython/pull/3384
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4047c540b75b1f10e307f8c428745c755d8c61edca4391a1b9b5579e1b43ae0a/python/cpython/pull/3384
og:image:altSSLSocket.sendall() now uses memoryview to create slices of data. This fix support for all bytes-like object. It is also more efficient and avoids costly copies. Signed-off-by: Christian Heimes chr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiran
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3384#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3384
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3384
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3384
Reloadhttps://github.com/python/cpython/pull/3384
Reloadhttps://github.com/python/cpython/pull/3384
Please reload this pagehttps://github.com/python/cpython/pull/3384
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3384
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
tiranhttps://github.com/tiran
python:masterhttps://github.com/python/cpython/tree/master
tiran:bpo-27340-ssl-sendallhttps://github.com/tiran/cpython/tree/bpo-27340-ssl-sendall
Conversationhttps://github.com/python/cpython/pull/3384
Commits2 (2)https://github.com/python/cpython/pull/3384/commits
Checkshttps://github.com/python/cpython/pull/3384/checks
Files changedhttps://github.com/python/cpython/pull/3384/files
bpo-27340: Use memoryview in SSLSocket.sendall()https://github.com/python/cpython/pull/3384#top
tiranhttps://github.com/tiran
python:masterhttps://github.com/python/cpython/tree/master
tiran:bpo-27340-ssl-sendallhttps://github.com/tiran/cpython/tree/bpo-27340-ssl-sendall
https://github.com/tiran
tiranhttps://github.com/tiran
Sep 6, 2017https://github.com/python/cpython/pull/3384#issue-255612829
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://bugs.python.org/issue27340https://bugs.python.org/issue27340
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/tiran
tiranhttps://github.com/tiran
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Sep 6, 2017https://github.com/python/cpython/pull/3384#event-1236877806
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 6, 2017https://github.com/python/cpython/pull/3384#event-1236878000
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 6, 2017https://github.com/python/cpython/pull/3384#event-1236878063
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/fd5b2faf7c03dc6fa8249dd108e433f27d377e39..9d442ed5dabec8ad3b0681bdc15f81271a9aca57
fd5b2fahttps://github.com/python/cpython/commit/fd5b2faf7c03dc6fa8249dd108e433f27d377e39
9d442edhttps://github.com/python/cpython/commit/9d442ed5dabec8ad3b0681bdc15f81271a9aca57
Compare https://github.com/python/cpython/compare/fd5b2faf7c03dc6fa8249dd108e433f27d377e39..9d442ed5dabec8ad3b0681bdc15f81271a9aca57
September 6, 2017 13:56https://github.com/python/cpython/pull/3384#event-1236879670
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Sep 6, 2017 https://github.com/python/cpython/pull/3384#pullrequestreview-61055805
View reviewed changes https://github.com/python/cpython/pull/3384/files
Lib/ssl.pyhttps://github.com/python/cpython/pull/3384/files#diff-f6439be9c66350dde4c35dbeea0352c96cc970ba12b0478f6ae36f10725bd8c5
pitrouhttps://github.com/pitrou
Sep 6, 2017https://github.com/python/cpython/pull/3384#discussion_r137394572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Lib/_pyio.py#L695https://github.com/python/cpython/blob/master/Lib/_pyio.py#L695
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/vadmium
vadmiumhttps://github.com/vadmium
Sep 6, 2017 https://github.com/python/cpython/pull/3384#pullrequestreview-61037204
View reviewed changes https://github.com/python/cpython/pull/3384/files
vadmiumhttps://github.com/vadmium
https://github.com/python/cpython/pull/3384#pullrequestreview-61037204
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/v3.6.2/Lib/_compression.py#L66https://github.com/python/cpython/blob/v3.6.2/Lib/_compression.py#L66
Please reload this pagehttps://github.com/python/cpython/pull/3384
Misc/NEWS.d/next/Library/2017-09-06-06-50-41.bpo-27340.GgekV5.rsthttps://github.com/python/cpython/pull/3384/files#diff-f4294a60ff0cc565a298382b27ef91c3515c764671f5c4dbae106113da5ee1b4
vadmiumhttps://github.com/vadmium
Sep 6, 2017https://github.com/python/cpython/pull/3384#discussion_r137377667
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/tiran
tiranhttps://github.com/tiran
Sep 6, 2017https://github.com/python/cpython/pull/3384#issuecomment-327627302
@vadmiumhttps://github.com/vadmium
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/8987de22fb2270ae2dc402e063acdd9fd9ebddc4..2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e
8987de2https://github.com/python/cpython/commit/8987de22fb2270ae2dc402e063acdd9fd9ebddc4
2a4e458https://github.com/python/cpython/commit/2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e
Compare https://github.com/python/cpython/compare/8987de22fb2270ae2dc402e063acdd9fd9ebddc4..2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e
September 6, 2017 23:35https://github.com/python/cpython/pull/3384#event-1237838314
tiranhttps://github.com/tiran
September 7, 2017 11:04https://github.com/python/cpython/pull/3384#commits-pushed-9c3d0e6
https://github.com/tiran
bpo-27340: Use memoryview in SSLSocket.sendall()https://github.com/python/cpython/pull/3384/commits/9c3d0e6fe30b5432ab33ba8a5d7551323dd061b0
9c3d0e6https://github.com/python/cpython/pull/3384/commits/9c3d0e6fe30b5432ab33ba8a5d7551323dd061b0
https://github.com/tiran
Cast view to bytes, fix typohttps://github.com/python/cpython/pull/3384/commits/1dae12fc88daba9645b1388b1d61296b8dd5aa1d
1dae12fhttps://github.com/python/cpython/pull/3384/commits/1dae12fc88daba9645b1388b1d61296b8dd5aa1d
https://github.com/tiran
tiranhttps://github.com/tiran
force-pushedhttps://github.com/python/cpython/compare/2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e..1dae12fc88daba9645b1388b1d61296b8dd5aa1d
2a4e458https://github.com/python/cpython/commit/2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e
1dae12fhttps://github.com/python/cpython/commit/1dae12fc88daba9645b1388b1d61296b8dd5aa1d
Compare https://github.com/python/cpython/compare/2a4e4589549e5deb79d0aaab2e0c8e76db7c9b0e..1dae12fc88daba9645b1388b1d61296b8dd5aa1d
September 7, 2017 18:04https://github.com/python/cpython/pull/3384#event-1239305282
https://github.com/zooba
zoobahttps://github.com/zooba
Sep 7, 2017 https://github.com/python/cpython/pull/3384#pullrequestreview-61310355
View reviewed changes https://github.com/python/cpython/pull/3384/files/1dae12fc88daba9645b1388b1d61296b8dd5aa1d
https://github.com/tiran
tiranhttps://github.com/tiran
888bbdchttps://github.com/python/cpython/commit/888bbdc192ec4db888a294ef758cf5510442dc9a
Sep 7, 2017https://github.com/python/cpython/pull/3384#event-1239760371
https://github.com/tiran
tiranhttps://github.com/tiran
September 7, 2017 21:18https://github.com/python/cpython/pull/3384#event-1239760628
https://github.com/tiran
tiranhttps://github.com/tiran
needs backport to 2.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22
Sep 7, 2017https://github.com/python/cpython/pull/3384#event-1239771925
https://github.com/tiran
tiranhttps://github.com/tiran
Sep 7, 2017https://github.com/python/cpython/pull/3384#issuecomment-327931246
Please reload this pagehttps://github.com/python/cpython/pull/3384
tiranhttps://github.com/tiran
Sep 7, 2017 https://github.com/python/cpython/pull/3384#ref-commit-0b9c29f
https://github.com/tiran
[3.6] bpo-27340: Use memoryview in SSLSocket.sendall() (https://github.com/tiran/cpython/commit/0b9c29f2cac1d74874d77eb375cade9b3ef55881
pythonGH-3384https://github.com/python/cpython/pull/3384
)https://github.com/tiran/cpython/commit/0b9c29f2cac1d74874d77eb375cade9b3ef55881
0b9c29fhttps://github.com/tiran/cpython/commit/0b9c29f2cac1d74874d77eb375cade9b3ef55881
888bbdchttps://github.com/tiran/cpython/commit/888bbdc192ec4db888a294ef758cf5510442dc9a
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 7, 2017https://github.com/python/cpython/pull/3384#issuecomment-327942982
@tiranhttps://github.com/tiran
@tiranhttps://github.com/tiran
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 7, 2017https://github.com/python/cpython/pull/3384#issuecomment-327942991
@tiranhttps://github.com/tiran
@tiranhttps://github.com/tiran
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 7, 2017https://github.com/python/cpython/pull/3384#issuecomment-327943225
GH-3434https://github.com/python/cpython/pull/3434
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 7, 2017https://github.com/python/cpython/pull/3384#event-1239850834
tiranhttps://github.com/tiran
Sep 7, 2017 https://github.com/python/cpython/pull/3384#ref-commit-9423f5d
https://github.com/tiran
[3.6]https://github.com/python/cpython/commit/9423f5d68874ff2e500cbe072c25f883cf754be8
bpo-27340https://bugs.python.org/issue?@action=redirect&bpo=27340
: Use memoryview in SSLSocket.sendall() (https://github.com/python/cpython/commit/9423f5d68874ff2e500cbe072c25f883cf754be8
GH-3384https://github.com/python/cpython/pull/3384
) (https://github.com/python/cpython/commit/9423f5d68874ff2e500cbe072c25f883cf754be8
#3434https://github.com/python/cpython/pull/3434
)https://github.com/python/cpython/commit/9423f5d68874ff2e500cbe072c25f883cf754be8
9423f5dhttps://github.com/python/cpython/commit/9423f5d68874ff2e500cbe072c25f883cf754be8
bpo-27340https://bugs.python.org/issue?@action=redirect&bpo=27340
888bbdchttps://github.com/python/cpython/commit/888bbdc192ec4db888a294ef758cf5510442dc9a
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3384#event-1283082953
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3384
https://github.com/vadmium
vadmium https://github.com/vadmium
https://github.com/python/cpython/pull/3384/files/9d442ed5dabec8ad3b0681bdc15f81271a9aca57
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/3384/files/9d442ed5dabec8ad3b0681bdc15f81271a9aca57
https://github.com/zooba
zooba https://github.com/zooba
https://github.com/python/cpython/pull/3384/files/1dae12fc88daba9645b1388b1d61296b8dd5aa1d
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/3384
https://github.com/tiran
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/vadmium
https://github.com/zooba
https://github.com/pitrou
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.