René's URL Explorer Experiment


Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython · GitHub

Open Graph Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython

X Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython

Description: This is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852

Open Graph Description: This is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852

X Description: This is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852

Opengraph URL: https://github.com/python/cpython/pull/3372

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a2e2340d-7d72-3abf-3e78-a3e8db65c124
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF72:104E67:B8679:EB692:6A4D826C
html-safe-noncec21daee2b115ccf2741ab7521f0cf5715bb0453efd069a50e38ddf39c7dc57d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjcyOjEwNEU2NzpCODY3OTpFQjY5Mjo2QTREODI2QyIsInZpc2l0b3JfaWQiOiI0Mjk4NjQ4MTAwODA3MzE3NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2d119042959509b5db5f96d8111ec29d9f8ed6993fbe134976a1885aac0548b5
hovercard-subject-tagpull_request:139448490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3372/files
twitter:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/690853?s=400&v=4
og:image:altThis is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3372/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3372%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3372%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3372/files
Reloadhttps://github.com/python/cpython/pull/3372/files
Reloadhttps://github.com/python/cpython/pull/3372/files
Please reload this pagehttps://github.com/python/cpython/pull/3372/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3372/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
naschemehttps://github.com/nascheme
python:masterhttps://github.com/python/cpython/tree/master
nascheme:io_flush_atexithttps://github.com/nascheme/cpython/tree/io_flush_atexit
Conversation 1 https://github.com/python/cpython/pull/3372
Commits 6 https://github.com/python/cpython/pull/3372/commits
Checks 0 https://github.com/python/cpython/pull/3372/checks
Files changed https://github.com/python/cpython/pull/3372/files
Please reload this pagehttps://github.com/python/cpython/pull/3372/files
bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. https://github.com/python/cpython/pull/3372/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/3372/files
5c9ad62 Maintain a list of BufferedWriter objects. Flush them on exit. nascheme Jun 1, 2017 https://github.com/python/cpython/pull/3372/commits/5c9ad6201a8ca1786e06d78665265770a0696369
c6c1bbd Use weakref.WeakSet instead of WeakKeyDictionary. nascheme Jun 5, 2017 https://github.com/python/cpython/pull/3372/commits/c6c1bbd4579c65c15c9b2b2ef926a2f6cca35eb3
74731be Simplify buffered double-linked list types. nascheme Jun 5, 2017 https://github.com/python/cpython/pull/3372/commits/74731be15ab24b53b9352b620400f52f653f17ce
61952f0 In _flush_all_writers(), suppress errors from flush(). nascheme Jun 23, 2017 https://github.com/python/cpython/pull/3372/commits/61952f01722d6a7c3335f393f7ed5925eec5eca2
a98052f Remove NEWS entry, use blurb. nascheme Sep 4, 2017 https://github.com/python/cpython/pull/3372/commits/a98052f4ad38cf3465cd342748b57beb68260405
c890050 Take more care when flushing file buffers from atexit. nascheme Sep 6, 2017 https://github.com/python/cpython/pull/3372/commits/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f
Clear filters https://github.com/python/cpython/pull/3372/files
Please reload this pagehttps://github.com/python/cpython/pull/3372/files
Please reload this pagehttps://github.com/python/cpython/pull/3372/files
_pyio.py https://github.com/python/cpython/pull/3372/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
2017-09-04-12-46-25.bpo-17852.OxAtCg.rst https://github.com/python/cpython/pull/3372/files#diff-54f53a9014baf9880ae401b337c2494b04fce4d421b3ac7624403d7651dd357a
_iomodule.c https://github.com/python/cpython/pull/3372/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
_iomodule.h https://github.com/python/cpython/pull/3372/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
bufferedio.c https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Lib/_pyio.pyhttps://github.com/python/cpython/pull/3372/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
View file https://github.com/nascheme/cpython/blob/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f/Lib/_pyio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3372/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3372/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/3372/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
https://github.com/python/cpython/pull/3372/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38
Misc/NEWS.d/next/Core and Builtins/2017-09-04-12-46-25.bpo-17852.OxAtCg.rsthttps://github.com/python/cpython/pull/3372/files#diff-54f53a9014baf9880ae401b337c2494b04fce4d421b3ac7624403d7651dd357a
View file https://github.com/nascheme/cpython/blob/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f/Misc/NEWS.d/next/Core%20and%20Builtins/2017-09-04-12-46-25.bpo-17852.OxAtCg.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3372/{{ revealButtonHref }}
Modules/_io/_iomodule.chttps://github.com/python/cpython/pull/3372/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
View file https://github.com/nascheme/cpython/blob/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f/Modules/_io/_iomodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3372/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3372/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
https://github.com/python/cpython/pull/3372/files#diff-0501b143a2f566e8a760abc20a88fd2533b1f230e5322831f400a0263b8c0253
Modules/_io/_iomodule.hhttps://github.com/python/cpython/pull/3372/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
View file https://github.com/nascheme/cpython/blob/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f/Modules/_io/_iomodule.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3372/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3372/files#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
View file https://github.com/nascheme/cpython/blob/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f/Modules/_io/bufferedio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3372/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/3372/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.