René's URL Explorer Experiment


Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython · GitHub

Open Graph Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython

X Title: bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit. by nascheme · Pull Request #3372 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852

X Description: This is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852

Opengraph URL: https://github.com/python/cpython/pull/3372

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:65ca4c87-7b95-f6a6-ed13-344d866c622d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6E0:1C418C:2195079:30659B1:6A4D0E9F
html-safe-noncefa20b631ec2790b866b1059e0803ac48d194820b51ba14f6d1e1add44d6e4e5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkUwOjFDNDE4QzoyMTk1MDc5OjMwNjU5QjE6NkE0RDBFOUYiLCJ2aXNpdG9yX2lkIjoiMjM4ODM5NjU4NTk4MzQ3OTQ1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac27cd6046031016a17c948eba035358b09e19cb0c5052887271096a2f8c410228
hovercard-subject-tagpull_request:139448490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3372/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1f4717864f127f4ff6c3eeb9476a185a35455439f320bddaf9d869fdd9cd6874/python/cpython/pull/3372
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1f4717864f127f4ff6c3eeb9476a185a35455439f320bddaf9d869fdd9cd6874/python/cpython/pull/3372
og:image:altThis is a fixed (hopefully) version of my previous patch. Checking buf->ok and buf->finalizing is necessary, as suggested by Antoine Pitrou. https://bugs.python.org/issue17852
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenascheme
hostnamegithub.com
expected-hostnamegithub.com
Nonebcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3372#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3372
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3372
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3372
Reloadhttps://github.com/python/cpython/pull/3372
Reloadhttps://github.com/python/cpython/pull/3372
Please reload this pagehttps://github.com/python/cpython/pull/3372
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3372
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
naschemehttps://github.com/nascheme
python:masterhttps://github.com/python/cpython/tree/master
nascheme:io_flush_atexithttps://github.com/nascheme/cpython/tree/io_flush_atexit
Conversationhttps://github.com/python/cpython/pull/3372
Commits6 (6)https://github.com/python/cpython/pull/3372/commits
Checkshttps://github.com/python/cpython/pull/3372/checks
Files changedhttps://github.com/python/cpython/pull/3372/files
bpo-17852: Maintain a list of BufferedWriter objects. Flush them on exit.https://github.com/python/cpython/pull/3372#top
naschemehttps://github.com/nascheme
python:masterhttps://github.com/python/cpython/tree/master
nascheme:io_flush_atexithttps://github.com/nascheme/cpython/tree/io_flush_atexit
https://github.com/nascheme
naschemehttps://github.com/nascheme
Sep 6, 2017https://github.com/python/cpython/pull/3372#issue-255445841
Please reload this pagehttps://github.com/python/cpython/pull/3372
https://bugs.python.org/issue17852https://bugs.python.org/issue17852
Please reload this pagehttps://github.com/python/cpython/pull/3372
naschemehttps://github.com/nascheme
September 4, 2017 16:02https://github.com/python/cpython/pull/3372#commits-pushed-5c9ad62
https://github.com/nascheme
Maintain a list of BufferedWriter objects. Flush them on exit.https://github.com/python/cpython/pull/3372/commits/5c9ad6201a8ca1786e06d78665265770a0696369
5c9ad62https://github.com/python/cpython/pull/3372/commits/5c9ad6201a8ca1786e06d78665265770a0696369
https://github.com/nascheme
Use weakref.WeakSet instead of WeakKeyDictionary.https://github.com/python/cpython/pull/3372/commits/c6c1bbd4579c65c15c9b2b2ef926a2f6cca35eb3
c6c1bbdhttps://github.com/python/cpython/pull/3372/commits/c6c1bbd4579c65c15c9b2b2ef926a2f6cca35eb3
https://github.com/nascheme
Simplify buffered double-linked list types.https://github.com/python/cpython/pull/3372/commits/74731be15ab24b53b9352b620400f52f653f17ce
74731behttps://github.com/python/cpython/pull/3372/commits/74731be15ab24b53b9352b620400f52f653f17ce
https://github.com/nascheme
In _flush_all_writers(), suppress errors from flush().https://github.com/python/cpython/pull/3372/commits/61952f01722d6a7c3335f393f7ed5925eec5eca2
61952f0https://github.com/python/cpython/pull/3372/commits/61952f01722d6a7c3335f393f7ed5925eec5eca2
https://github.com/nascheme
Remove NEWS entry, use blurb.https://github.com/python/cpython/pull/3372/commits/a98052f4ad38cf3465cd342748b57beb68260405
a98052fhttps://github.com/python/cpython/pull/3372/commits/a98052f4ad38cf3465cd342748b57beb68260405
https://github.com/nascheme
Take more care when flushing file buffers from atexit.https://github.com/python/cpython/pull/3372/commits/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f
c890050https://github.com/python/cpython/pull/3372/commits/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 6, 2017https://github.com/python/cpython/pull/3372#event-1235923088
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 6, 2017https://github.com/python/cpython/pull/3372#event-1235923094
https://github.com/nascheme
naschemehttps://github.com/nascheme
pitrouhttps://github.com/pitrou
September 6, 2017 00:25https://github.com/python/cpython/pull/3372#event-1235923345
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Sep 6, 2017 https://github.com/python/cpython/pull/3372#pullrequestreview-60880074
View reviewed changes https://github.com/python/cpython/pull/3372/files/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f
https://github.com/nascheme
naschemehttps://github.com/nascheme
0a1ff24https://github.com/python/cpython/commit/0a1ff24acfc15d8c7f2dc41000a6f3d9a31e7480
Sep 22, 2017https://github.com/python/cpython/pull/3372#event-1261637962
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3372#event-1283082622
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Dec 12, 2017https://github.com/python/cpython/pull/3372#issuecomment-351220352
Please reload this pagehttps://github.com/python/cpython/pull/3372
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Dec 12, 2017 https://github.com/python/cpython/pull/3372#ref-pullrequest-281567931
bpo-17852: Revert incorrect fix based on misunderstanding of _Py_PyAtExit() semantics #4826 https://github.com/python/cpython/pull/4826
naschemehttps://github.com/nascheme
Dec 13, 2017 https://github.com/python/cpython/pull/3372#ref-commit-23c8801
https://github.com/nascheme
Fix PRhttps://github.com/nascheme/cpython/commit/23c8801c2fd059e0eefcbde6365a8d7439b15a59
python#3372https://github.com/python/cpython/pull/3372
, flush BufferedWriter objects on exit.https://github.com/nascheme/cpython/commit/23c8801c2fd059e0eefcbde6365a8d7439b15a59
23c8801https://github.com/nascheme/cpython/commit/23c8801c2fd059e0eefcbde6365a8d7439b15a59
https://github.com/nascheme
naschemehttps://github.com/nascheme
Dec 13, 2017 https://github.com/python/cpython/pull/3372#ref-pullrequest-281866134
bpo-17852: Fix PR #3372, flush BufferedWriter objects on exit. #4847 https://github.com/python/cpython/pull/4847
https://github.com/python/cpython/pull/3372
arigohttps://github.com/python/cpython/pull/3372
May 26, 2023 https://github.com/python/cpython/pull/3372#ref-issue-1198900112
Built-in module _io can lose data from buffered files in reference cycles #62052 https://github.com/python/cpython/issues/62052
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3372
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/3372/files/c890050c32d0b4d45339aa3d1dd5f8f164cfad8f
Please reload this pagehttps://github.com/python/cpython/pull/3372
https://github.com/nascheme
https://github.com/pitrou
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.