René's URL Explorer Experiment


Title: bpo-26175: Fix SpooledTemporaryFile IOBase abstract by GFernie · Pull Request #3249 · python/cpython · GitHub

Open Graph Title: bpo-26175: Fix SpooledTemporaryFile IOBase abstract by GFernie · Pull Request #3249 · python/cpython

X Title: bpo-26175: Fix SpooledTemporaryFile IOBase abstract by GFernie · Pull Request #3249 · python/cpython

Description: One would assume that this class implements the IOBase abstract. As the underlying file-like object is either io.BytesIO, io.StringIO, or a true file object, this is a reasonable abstract expect and to implement. Regardless, the behaviour of this class does not change much in the case of the attribute being missing from the underlying file-like; an AttributeError is still raised, albeit from one additional frame on the stack trace. https://bugs.python.org/issue26175

Open Graph Description: One would assume that this class implements the IOBase abstract. As the underlying file-like object is either io.BytesIO, io.StringIO, or a true file object, this is a reasonable abstract expect an...

X Description: One would assume that this class implements the IOBase abstract. As the underlying file-like object is either io.BytesIO, io.StringIO, or a true file object, this is a reasonable abstract expect an...

Opengraph URL: https://github.com/python/cpython/pull/3249

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1a3b7a1c-682e-1b80-2bbe-6d3064b177ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA8C:2839F:12646D6:188BCA9:6969ACFC
html-safe-nonced1696f9298e32b81490155c8c7629efdc7e4b381055a0187741fb144a1bebf21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQThDOjI4MzlGOjEyNjQ2RDY6MTg4QkNBOTo2OTY5QUNGQyIsInZpc2l0b3JfaWQiOiI4MjI5ODg3MDY4NzMzMDI1NTMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf325b60acb647c06afe337905dffe840502637f6ddb6660405dc39063e10fa3c
hovercard-subject-tagpull_request:138538082
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3249/files
twitter:imagehttps://avatars.githubusercontent.com/u/9322279?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9322279?s=400&v=4
og:image:altOne would assume that this class implements the IOBase abstract. As the underlying file-like object is either io.BytesIO, io.StringIO, or a true file object, this is a reasonable abstract expect an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3249/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3249%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3249%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3249/files
Reloadhttps://github.com/python/cpython/pull/3249/files
Reloadhttps://github.com/python/cpython/pull/3249/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
GFerniehttps://github.com/GFernie
python:mainhttps://github.com/python/cpython/tree/main
Conversation 48 https://github.com/python/cpython/pull/3249
Commits 13 https://github.com/python/cpython/pull/3249/commits
Checks 0 https://github.com/python/cpython/pull/3249/checks
Files changed https://github.com/python/cpython/pull/3249/files
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
bpo-26175: Fix SpooledTemporaryFile IOBase abstract https://github.com/python/cpython/pull/3249/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/3249/files
83d6152 Fix SpooledTemporaryFile IOBase abstract GFernie Aug 30, 2017 https://github.com/python/cpython/pull/3249/commits/83d6152028ad56d7eb0e4038c9c6d5c643908629
3b69baa Add news entry for bpo-26175 patch GFernie Aug 30, 2017 https://github.com/python/cpython/pull/3249/commits/3b69baaf336f8c3b61df2b3fae4d7a9ebc5bb1f5
753b4fb Update 2017-08-30-23-14-17.bpo-26175.GOaj9y.rst merwok Sep 20, 2017 https://github.com/python/cpython/pull/3249/commits/753b4fba2d70e84e8e9686d39bf6dcc162d4aa1f
a70113e Make SpooledTemporaryFile subclass IOBase GFernie Sep 30, 2017 https://github.com/python/cpython/pull/3249/commits/a70113ec131af4fd523da55a7ec46b9a8b170395
fb28362 Refactor tests to more reliably test abstract GFernie Sep 30, 2017 https://github.com/python/cpython/pull/3249/commits/fb283621685da73771256d8eb51dabf19fe71378
bc9d0a9 Return new absolute position from underlying file on seek GFernie Sep 9, 2018 https://github.com/python/cpython/pull/3249/commits/bc9d0a94a0d1c351ccb1fd9b70b7a835313c12db
b588dec Do nothing on __del__ GFernie Sep 9, 2018 https://github.com/python/cpython/pull/3249/commits/b588dec6a80c7e113ef9fe7e22749914810f4810
ab49dd1 Return new file size from underlying file on truncate GFernie Sep 9, 2018 https://github.com/python/cpython/pull/3249/commits/ab49dd1494411dfd31ef5e309c17a084103e4f25
4251b21 Merge remote-tracking branch 'origin/master' into bpo-26175_fix-Spool… GFernie Oct 30, 2019 https://github.com/python/cpython/pull/3249/commits/4251b218e7695230ceedfa450bd27b24e3741379
19f4c08 Add versionchanged tag GFernie Oct 30, 2019 https://github.com/python/cpython/pull/3249/commits/19f4c08d000f6249a99c81ebf0a1de40a22555ac
4519b9c Use :class: instead of :py:data: GFernie Oct 30, 2019 https://github.com/python/cpython/pull/3249/commits/4519b9c56ed657fe4519540f1e8b9d5fbedae268
554aad6 Revert "Do nothing on __del__" GFernie Nov 23, 2019 https://github.com/python/cpython/pull/3249/commits/554aad63340c73dcf0afe0fb35ce45cf1a4341c1
be094b3 Add test for rolled file finalisation GFernie Nov 23, 2019 https://github.com/python/cpython/pull/3249/commits/be094b38039b22c6145bee16ddf67358e44b7e8a
Clear filters https://github.com/python/cpython/pull/3249/files
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
tempfile.rst https://github.com/python/cpython/pull/3249/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e
tempfile.py https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
test_tempfile.py https://github.com/python/cpython/pull/3249/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983
2017-08-30-23-14-17.bpo-26175.GOaj9y.rst https://github.com/python/cpython/pull/3249/files#diff-1cfd34eadf3500d548e6d1a0f6f0ed83260044b520570d2ce6ce1693ecfa267c
Doc/library/tempfile.rsthttps://github.com/python/cpython/pull/3249/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e
View file https://github.com/python/cpython/blob/be094b38039b22c6145bee16ddf67358e44b7e8a/Doc/library/tempfile.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3249/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e
pitrouhttps://github.com/pitrou
Nov 23, 2019https://github.com/python/cpython/pull/3249/files#r349882468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
https://github.com/python/cpython/pull/3249/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1e
Lib/tempfile.pyhttps://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
View file https://github.com/python/cpython/blob/be094b38039b22c6145bee16ddf67358e44b7e8a/Lib/tempfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
ppperyhttps://github.com/pppery
Jun 6, 2018https://github.com/python/cpython/pull/3249/files#r193262967
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
vadmiumhttps://github.com/vadmium
Jun 9, 2018https://github.com/python/cpython/pull/3249/files#r194224533
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
GFerniehttps://github.com/GFernie
Sep 9, 2018https://github.com/python/cpython/pull/3249/files#r216171541
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
pitrouhttps://github.com/pitrou
Oct 22, 2018https://github.com/python/cpython/pull/3249/files#r226989654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
coleiferhttps://github.com/coleifer
Mar 23, 2019https://github.com/python/cpython/pull/3249/files#r268379596
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
pitrouhttps://github.com/pitrou
Nov 23, 2019https://github.com/python/cpython/pull/3249/files#r349882536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
thehesiodhttps://github.com/thehesiod
Feb 12, 2020https://github.com/python/cpython/pull/3249/files#r377982116
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
merwokhttps://github.com/merwok
Feb 13, 2020https://github.com/python/cpython/pull/3249/files#r378599271
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
thehesiodhttps://github.com/thehesiod
Feb 21, 2020https://github.com/python/cpython/pull/3249/files#r382337005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
danieldjewellhttps://github.com/danieldjewell
May 13, 2020https://github.com/python/cpython/pull/3249/files#r424712850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@merwokhttps://github.com/merwok
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
merwokhttps://github.com/merwok
May 13, 2020https://github.com/python/cpython/pull/3249/files#r424735823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
https://github.com/python/cpython/pull/3249/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21
Lib/test/test_tempfile.pyhttps://github.com/python/cpython/pull/3249/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983
View file https://github.com/python/cpython/blob/be094b38039b22c6145bee16ddf67358e44b7e8a/Lib/test/test_tempfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3249/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983
pitrouhttps://github.com/pitrou
Oct 22, 2018https://github.com/python/cpython/pull/3249/files#r226990347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
coleiferhttps://github.com/coleifer
Mar 23, 2019https://github.com/python/cpython/pull/3249/files#r268379437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
https://github.com/python/cpython/pull/3249/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983
pitrouhttps://github.com/pitrou
Nov 23, 2019https://github.com/python/cpython/pull/3249/files#r349882937
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
pitrouhttps://github.com/pitrou
Nov 23, 2019https://github.com/python/cpython/pull/3249/files#r349882980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
pitrouhttps://github.com/pitrou
Nov 23, 2019https://github.com/python/cpython/pull/3249/files#r349883005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3249/files
https://github.com/python/cpython/pull/3249/files#diff-cbc50394ff35aa5553e84fa01cfdda48f5215fcb60cd1ee84a0ee9682d908983
Misc/NEWS.d/next/Library/2017-08-30-23-14-17.bpo-26175.GOaj9y.rsthttps://github.com/python/cpython/pull/3249/files#diff-1cfd34eadf3500d548e6d1a0f6f0ed83260044b520570d2ce6ce1693ecfa267c
View file https://github.com/python/cpython/blob/be094b38039b22c6145bee16ddf67358e44b7e8a/Misc/NEWS.d/next/Library/2017-08-30-23-14-17.bpo-26175.GOaj9y.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3249/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.