René's URL Explorer Experiment


Title: gh-87390: Add tests demonstrating current type variable substitution behaviour by mrahtz · Pull Request #32341 · python/cpython · GitHub

Open Graph Title: gh-87390: Add tests demonstrating current type variable substitution behaviour by mrahtz · Pull Request #32341 · python/cpython

X Title: gh-87390: Add tests demonstrating current type variable substitution behaviour by mrahtz · Pull Request #32341 · python/cpython

Description: Here's a reference of what we currently do and don't allow in terms of type variable substitution in aliases. I've marked the cases that I think the current implementation is incorrect on. Ideally ...

Open Graph Description: Here's a reference of what we currently do and don't allow in terms of type variable substitution in aliases. I've marked the cases that I think the current implementation is incorrect ...

X Description: Here's a reference of what we currently do and don't allow in terms of type variable substitution in aliases. I've marked the cases that I think the current implementation i...

Opengraph URL: https://github.com/python/cpython/pull/32341

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6cc702a2-7ae5-f356-6e89-a7326bceb5a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB64:140A20:301CEE:40882B:6969AAD0
html-safe-nonce1b89270fc0485a2a0989118718cce9c4bc039ab0a2d282e12b989ce42584713e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjY0OjE0MEEyMDozMDFDRUU6NDA4ODJCOjY5NjlBQUQwIiwidmlzaXRvcl9pZCI6IjI2NDk5NDUyOTgxMzI2NDI1MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd04b2057beb8811c5e0a490047837745a9dc3eaa80ef24bcb4353ad3acaf486c
hovercard-subject-tagpull_request:900665331
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/32341/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/272970888861afbd168f92feabf276e464c3767179f6c325ae9ed11d93489fcb/python/cpython/pull/32341
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/272970888861afbd168f92feabf276e464c3767179f6c325ae9ed11d93489fcb/python/cpython/pull/32341
og:image:altHere's a reference of what we currently do and don't allow in terms of type variable substitution in aliases. I've marked the cases that I think the current implementation is incorrect ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemrahtz
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/32341#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32341
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32341
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/32341
Reloadhttps://github.com/python/cpython/pull/32341
Reloadhttps://github.com/python/cpython/pull/32341
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/32341
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/32341
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/32341#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
mrahtz:subst-testshttps://github.com/mrahtz/cpython/tree/subst-tests
gh-87390: Add tests demonstrating current type variable substitution behaviour https://github.com/python/cpython/pull/32341#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
mrahtz:subst-testshttps://github.com/mrahtz/cpython/tree/subst-tests
Conversation 42 https://github.com/python/cpython/pull/32341
Commits 24 https://github.com/python/cpython/pull/32341/commits
Checks 0 https://github.com/python/cpython/pull/32341/checks
Files changed https://github.com/python/cpython/pull/32341/files
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Apr 5, 2022https://github.com/python/cpython/pull/32341#issue-1193657266
Please reload this pagehttps://github.com/python/cpython/pull/32341
@pradeep90https://github.com/pradeep90
https://bugs.python.org/issue47006https://bugs.python.org/issue47006
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
Add integration tests for type variable substitutionhttps://github.com/python/cpython/pull/32341/commits/f508d12ea51855a6eedbbb28a2d55c7a9a3b904f
f508d12https://github.com/python/cpython/pull/32341/commits/f508d12ea51855a6eedbbb28a2d55c7a9a3b904f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 5, 2022https://github.com/python/cpython/pull/32341#event-6374217667
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 5, 2022https://github.com/python/cpython/pull/32341#event-6374217684
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Apr 5, 2022https://github.com/python/cpython/pull/32341#event-6374217759
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 6, 2022 https://github.com/python/cpython/pull/32341#pullrequestreview-934276270
View reviewed changes https://github.com/python/cpython/pull/32341/files/f508d12ea51855a6eedbbb28a2d55c7a9a3b904f
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/f508d12ea51855a6eedbbb28a2d55c7a9a3b904f#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
mrahtzhttps://github.com/mrahtz
April 8, 2022 21:56https://github.com/python/cpython/pull/32341#commits-pushed-ea104b9
https://github.com/mrahtz
Add tests for list, dict and tuplehttps://github.com/python/cpython/pull/32341/commits/ea104b97a8198bd26e85ea62f383be1c8fae99cf
ea104b9https://github.com/python/cpython/pull/32341/commits/ea104b97a8198bd26e85ea62f383be1c8fae99cf
https://github.com/mrahtz
Add tests for Tuplehttps://github.com/python/cpython/pull/32341/commits/526d9e8995ff4da08fd4e2d8c43fc0c39deef593
526d9e8https://github.com/python/cpython/pull/32341/commits/526d9e8995ff4da08fd4e2d8c43fc0c39deef593
https://github.com/mrahtz
Revert "Add tests for Tuple"https://github.com/python/cpython/pull/32341/commits/0f022db57132dc6cec9318768250f27640d4d941
0f022dbhttps://github.com/python/cpython/pull/32341/commits/0f022db57132dc6cec9318768250f27640d4d941
526d9e8https://github.com/mrahtz/cpython/commit/526d9e8995ff4da08fd4e2d8c43fc0c39deef593
https://github.com/mrahtz
Make it easier to tests all tuple, list and dict typeshttps://github.com/python/cpython/pull/32341/commits/cc7bf8cc6540f1964dd04ae28f1fb0d6806df781
cc7bf8chttps://github.com/python/cpython/pull/32341/commits/cc7bf8cc6540f1964dd04ae28f1fb0d6806df781
https://github.com/mrahtz
TypeVarSubstitutionTests -> GenericAliasSubstitutionTestshttps://github.com/python/cpython/pull/32341/commits/458b5ddbbb96301496113a7a8aceca4d7116cbf8
458b5ddhttps://github.com/python/cpython/pull/32341/commits/458b5ddbbb96301496113a7a8aceca4d7116cbf8
https://github.com/mrahtz
Remove question marks from cases I'm actually pretty sure abouthttps://github.com/python/cpython/pull/32341/commits/0c8ba383d83731e03ad9569daec84570d4f57d0f
0c8ba38https://github.com/python/cpython/pull/32341/commits/0c8ba383d83731e03ad9569daec84570d4f57d0f
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
April 10, 2022 09:40https://github.com/python/cpython/pull/32341#event-6403514249
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
code ownershttps://github.com/python/cpython/blob/defbbd68f7f68f4edb3a6b256f26e0532727b3da/.github/CODEOWNERS#L133
April 10, 2022 09:40https://github.com/python/cpython/pull/32341#event-6403514266
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 11, 2022 https://github.com/python/cpython/pull/32341#pullrequestreview-937371407
View reviewed changes https://github.com/python/cpython/pull/32341/files/0c8ba383d83731e03ad9569daec84570d4f57d0f
JelleZijlstrahttps://github.com/JelleZijlstra
https://github.com/python/cpython/pull/32341#pullrequestreview-937371407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/0c8ba383d83731e03ad9569daec84570d4f57d0f#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/0c8ba383d83731e03ad9569daec84570d4f57d0f#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/0c8ba383d83731e03ad9569daec84570d4f57d0f#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
Note that list[] should only take one argumenthttps://github.com/python/cpython/pull/32341/commits/db24e70cd086bc0ca65d59cc7e014466ebbd9fc7
db24e70https://github.com/python/cpython/pull/32341/commits/db24e70cd086bc0ca65d59cc7e014466ebbd9fc7
https://github.com/ghost
ghosthttps://github.com/ghost
Apr 11, 2022https://github.com/python/cpython/pull/32341#issuecomment-1095394893
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432b8b111ec9bf5bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/32341
mrahtzhttps://github.com/mrahtz
April 11, 2022 19:23https://github.com/python/cpython/pull/32341#commits-pushed-15a4809
https://github.com/mrahtz
Leave unpacked tuples unsimplifiedhttps://github.com/python/cpython/pull/32341/commits/15a48099849ea0367e5949c2e5a93a6643772695
15a4809https://github.com/python/cpython/pull/32341/commits/15a48099849ea0367e5949c2e5a93a6643772695
https://github.com/mrahtz
Add generic[*Ts][*tuple[*Ts]]https://github.com/python/cpython/pull/32341/commits/0d7d2eb5e6860d61c1e9741fb34e491b212facfb
0d7d2ebhttps://github.com/python/cpython/pull/32341/commits/0d7d2eb5e6860d61c1e9741fb34e491b212facfb
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Apr 11, 2022https://github.com/python/cpython/pull/32341#event-6411423852
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Apr 11, 2022https://github.com/python/cpython/pull/32341#issuecomment-1095421982
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
Update comments based on decision to leave unpacked tuples unsimplifiedhttps://github.com/python/cpython/pull/32341/commits/ab01c8a8c24c31f04a8c70242ef374bca23374e7
ab01c8ahttps://github.com/python/cpython/pull/32341/commits/ab01c8a8c24c31f04a8c70242ef374bca23374e7
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 11, 2022 https://github.com/python/cpython/pull/32341#ref-issue-1199076926
PEP 646: Decide on substitution behavior #91162 https://github.com/python/cpython/issues/91162
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
Apr 13, 2022https://github.com/python/cpython/pull/32341#event-6429061943
https://github.com/mrahtz
Add tests for generic[T1, bool, T2][*tuple[int, str]]https://github.com/python/cpython/pull/32341/commits/c4fe922c4e2f301a84e74ca02ec979fa3e47cc0c
c4fe922https://github.com/python/cpython/pull/32341/commits/c4fe922c4e2f301a84e74ca02ec979fa3e47cc0c
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Apr 15, 2022https://github.com/python/cpython/pull/32341#issuecomment-1099984950
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
Update comments based on decision to unpack *some* tupleshttps://github.com/python/cpython/pull/32341/commits/d55b8fb02cfd203085ac306936d783faa41080f8
d55b8fbhttps://github.com/python/cpython/pull/32341/commits/d55b8fb02cfd203085ac306936d783faa41080f8
https://github.com/pradeep90
pradeep90https://github.com/pradeep90
Apr 15, 2022 https://github.com/python/cpython/pull/32341#pullrequestreview-939997287
View reviewed changes https://github.com/python/cpython/pull/32341/files/d55b8fb02cfd203085ac306936d783faa41080f8
pradeep90https://github.com/pradeep90
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/python/cpython/pull/32341#pullrequestreview-939997287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
pradeep90https://github.com/pradeep90
Apr 12, 2022https://github.com/python/cpython/pull/32341#discussion_r848824445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/32341
mrahtzhttps://github.com/mrahtz
Apr 16, 2022https://github.com/python/cpython/pull/32341#discussion_r851651115
Please reload this pagehttps://github.com/python/cpython/pull/32341
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JelleZijlstrahttps://github.com/JelleZijlstra
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/32341
mrahtzhttps://github.com/mrahtz
Apr 16, 2022https://github.com/python/cpython/pull/32341#discussion_r851653407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#91162https://github.com/python/cpython/issues/91162
Please reload this pagehttps://github.com/python/cpython/pull/32341
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 15, 2022https://github.com/python/cpython/pull/32341#event-6441607179
https://github.com/pradeep90
pradeep90https://github.com/pradeep90
Apr 15, 2022 https://github.com/python/cpython/pull/32341#pullrequestreview-943628402
View reviewed changes https://github.com/python/cpython/pull/32341/files/d55b8fb02cfd203085ac306936d783faa41080f8
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32341/files/d55b8fb02cfd203085ac306936d783faa41080f8#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 15, 2022https://github.com/python/cpython/pull/32341#issuecomment-1100466389
Please reload this pagehttps://github.com/python/cpython/pull/32341
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 15, 2022 https://github.com/python/cpython/pull/32341#ref-commit-4bea386
https://github.com/JelleZijlstra
Fix tests on Python 3.11https://github.com/JelleZijlstra/typing/commit/4bea3861cc244b604be7113baf30be6718c72f59
4bea386https://github.com/JelleZijlstra/typing/commit/4bea3861cc244b604be7113baf30be6718c72f59
python/cpython#32341 (comment)https://github.com/python/cpython/pull/32341#issuecomment-1100466389
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 15, 2022 https://github.com/python/cpython/pull/32341#ref-pullrequest-1205947769
Fix tests on Python 3.11 python/typing#1139 https://github.com/python/typing/pull/1139
mrahtzhttps://github.com/mrahtz
April 16, 2022 17:45https://github.com/python/cpython/pull/32341#commits-pushed-e858fc6
https://github.com/mrahtz
Note that generic[*tuple[()]] should raise TypeErrorhttps://github.com/python/cpython/pull/32341/commits/e858fc6af418027f850a505333dd88f1751ff75d
e858fc6https://github.com/python/cpython/pull/32341/commits/e858fc6af418027f850a505333dd88f1751ff75d
https://github.com/mrahtz
Note that C[T, *tuple[int, ...]][int] raises TypeError only because C…https://github.com/python/cpython/pull/32341/commits/3bc7d262192bb23bfba50f97011cc1bca8aab71b
3bc7d26https://github.com/python/cpython/pull/32341/commits/3bc7d262192bb23bfba50f97011cc1bca8aab71b
https://github.com/mrahtz
State that multiple unpackings should be allowed where possiblehttps://github.com/python/cpython/pull/32341/commits/c980e4f1e85eea9f4c107534fc0efd92a579985f
c980e4fhttps://github.com/python/cpython/pull/32341/commits/c980e4f1e85eea9f4c107534fc0efd92a579985f
https://github.com/mrahtz
Add test for generic[T1, *tuple[int, ...], T2][str, bool, float]https://github.com/python/cpython/pull/32341/commits/95b721074524f89b6e136f9d728ac22410a1e303
95b7210https://github.com/python/cpython/pull/32341/commits/95b721074524f89b6e136f9d728ac22410a1e303
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
Apr 16, 2022https://github.com/python/cpython/pull/32341#issuecomment-1100712617
@JelleZijlstrahttps://github.com/JelleZijlstra
https://github.com/python/cpython/blob/main/Lib/typing.py#L1331https://github.com/python/cpython/blob/main/Lib/typing.py#L1331
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
Update comments according to revised tentative spec athttps://github.com/python/cpython/pull/32341/commits/96394b1f86b13fb82ee07a953f2669560f037ecd
python#91162https://github.com/python/cpython/issues/91162
96394b1https://github.com/python/cpython/pull/32341/commits/96394b1f86b13fb82ee07a953f2669560f037ecd
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 16, 2022 https://github.com/python/cpython/pull/32341#ref-commit-783c8ca
https://github.com/JelleZijlstra
Fix tests on Python 3.11 (https://github.com/python/typing/commit/783c8ca10ffb8b2cd00e62977c052f8d5a31bc3f
#1139https://github.com/python/typing/pull/1139
)https://github.com/python/typing/commit/783c8ca10ffb8b2cd00e62977c052f8d5a31bc3f
783c8cahttps://github.com/python/typing/commit/783c8ca10ffb8b2cd00e62977c052f8d5a31bc3f
python/cpython#32341 (comment)https://github.com/python/cpython/pull/32341#issuecomment-1100466389
mrahtzhttps://github.com/mrahtz
April 18, 2022 08:14https://github.com/python/cpython/pull/32341#commits-pushed-ed9a557
https://github.com/mrahtz
Update expected comments to account for unpacked types only being val…https://github.com/python/cpython/pull/32341/commits/ed9a5576d86d24ebd8502b2d10d1b17ff63c6064
ed9a557https://github.com/python/cpython/pull/32341/commits/ed9a5576d86d24ebd8502b2d10d1b17ff63c6064
https://github.com/mrahtz
Merge branch 'main' into subst-testshttps://github.com/python/cpython/pull/32341/commits/faa9fc3b80fcc25c184c06a2b5faceaeb241e0d8
faa9fc3https://github.com/python/cpython/pull/32341/commits/faa9fc3b80fcc25c184c06a2b5faceaeb241e0d8
https://github.com/mrahtz
Update to reflect results after merging latest mainhttps://github.com/python/cpython/pull/32341/commits/9947fc073b9d9a16f7d5cecba0794214ea737179
9947fc0https://github.com/python/cpython/pull/32341/commits/9947fc073b9d9a16f7d5cecba0794214ea737179
https://github.com/mrahtz
Update ALL tests to reflect results after merging latest mainhttps://github.com/python/cpython/pull/32341/commits/12496fc0ec0b1adb3030d3f89b054f3e50697040
12496fchttps://github.com/python/cpython/pull/32341/commits/12496fc0ec0b1adb3030d3f89b054f3e50697040
https://github.com/mrahtz
Remove comments saying we should get a TypeError in cases where we *d…https://github.com/python/cpython/pull/32341/commits/db9af53d38f31961ac7d97bb174a35a77d5d274e
db9af53https://github.com/python/cpython/pull/32341/commits/db9af53d38f31961ac7d97bb174a35a77d5d274e
https://github.com/mrahtz
Update comments on expected results based on latest tentative spec athttps://github.com/python/cpython/pull/32341/commits/c5b5a63585f5e0cd656ddafd1ff00fd25eded010
p…https://github.com/python/cpython/issues/91162
c5b5a63https://github.com/python/cpython/pull/32341/commits/c5b5a63585f5e0cd656ddafd1ff00fd25eded010
…ython#91162https://github.com/python/cpython/issues/91162
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 29, 2022https://github.com/python/cpython/pull/32341#event-6525981423
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 29, 2022https://github.com/python/cpython/pull/32341#event-6525981521
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 29, 2022https://github.com/python/cpython/pull/32341#issuecomment-1113675814
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
f665616https://github.com/python/cpython/commit/f6656163de483003697d510031827b7512056d55
Apr 29, 2022https://github.com/python/cpython/pull/32341#event-6525996885
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 29, 2022https://github.com/python/cpython/pull/32341#event-6525997213
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
April 29, 2022 20:15https://github.com/python/cpython/pull/32341#event-6526053054
https://github.com/mrahtz
mrahtzhttps://github.com/mrahtz
May 7, 2022 https://github.com/python/cpython/pull/32341#ref-pullrequest-1226606539
gh-91162: Fix substitution of unpacked tuples in generic aliases #92335 https://github.com/python/cpython/pull/92335
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2022 https://github.com/python/cpython/pull/32341#ref-commit-67b187e
https://github.com/JelleZijlstra
Fix tests on Python 3.11 (#1139)https://github.com/python/typing_extensions/commit/67b187e064adb64f9fabf52093a4ee090850bb45
67b187ehttps://github.com/python/typing_extensions/commit/67b187e064adb64f9fabf52093a4ee090850bb45
python/cpython#32341 (comment)https://github.com/python/cpython/pull/32341#issuecomment-1100466389
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2022 https://github.com/python/cpython/pull/32341#ref-commit-58f7043
https://github.com/JelleZijlstra
Fix tests on Python 3.11 (#1139)https://github.com/python/typing_extensions/commit/58f704372d656232651d55639b06735cf05ba22e
58f7043https://github.com/python/typing_extensions/commit/58f704372d656232651d55639b06735cf05ba22e
python/cpython#32341 (comment)https://github.com/python/cpython/pull/32341#issuecomment-1100466389
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2022 https://github.com/python/cpython/pull/32341#ref-commit-48a5fe0
https://github.com/JelleZijlstra
Fix tests on Python 3.11 (#1139)https://github.com/python/typing_extensions/commit/48a5fe07702f4a5068b056b580b6725deb5ad13d
48a5fe0https://github.com/python/typing_extensions/commit/48a5fe07702f4a5068b056b580b6725deb5ad13d
python/cpython#32341 (comment)https://github.com/python/cpython/pull/32341#issuecomment-1100466389
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32341
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/32341/files/f508d12ea51855a6eedbbb28a2d55c7a9a3b904f
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/pradeep90
pradeep90 https://github.com/pradeep90
https://github.com/python/cpython/pull/32341/files/ab01c8a8c24c31f04a8c70242ef374bca23374e7
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
Please reload this pagehttps://github.com/python/cpython/pull/32341
https://github.com/mrahtz
https://github.com/JelleZijlstra
https://github.com/pradeep90
https://github.com/gvanrossum
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.