| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:15da07d2-01af-8318-3e35-9f707fb4572d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB66:1D5ACA:3BC8B9:4EB96C:69697E4B |
| html-safe-nonce | 94d20b1db2dec12959b338c6d3d98fa482ca578d637294409500305fc4a003f2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjY2OjFENUFDQTozQkM4Qjk6NEVCOTZDOjY5Njk3RTRCIiwidmlzaXRvcl9pZCI6IjY1ODExMjYwMDY3NDUwMDE3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 17a963435309a114cd1a0bae4291a15e422701c09f71587f90648d46a5f18cb0 |
| hovercard-subject-tag | pull_request:898234481 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/32283/files |
| twitter:image | https://avatars.githubusercontent.com/u/10137?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10137?s=400&v=4 |
| og:image:alt | @serhiy-storchaka
This time, I checked several rounds carefully, it should be in good state.
Tested with VERBOSE/VVERBOSE macros defined, it builds and runs well.
https://bugs.python.org/issue23689 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 48f380098b30acbb700b04f1724481ca10d574fc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/32283/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32283%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32283%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/32283/files |
| Reload | https://github.com/python/cpython/pull/32283/files |
| Reload | https://github.com/python/cpython/pull/32283/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| python:main | https://github.com/python/cpython/tree/main |
|
Conversation
5
| https://github.com/python/cpython/pull/32283 |
|
Commits
11
| https://github.com/python/cpython/pull/32283/commits |
|
Checks
0
| https://github.com/python/cpython/pull/32283/checks |
|
Files changed
| https://github.com/python/cpython/pull/32283/files |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure
| https://github.com/python/cpython/pull/32283/files#top |
|
Show all changes
11 commits
| https://github.com/python/cpython/pull/32283/files |
|
e5317fe
1. add variables
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/e5317fe2fd80a8fbafd8420d1a9013276b89678f |
|
28e4d2d
2. add _CompileData class to _compile.py
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/28e4d2d97f39897ad437683ee2710573579fd665 |
|
7493fad
3. add repeat_count parameter to _sre.compile() function
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/7493fad15987bad1de1da48c192877b912291555 |
|
b928335
4. emit repeat_count in sre_compile.py
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/b928335409c967ce2a07a362eaad88c4a0662515 |
|
dfec05d
5. change _validate_outer() parameter
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/dfec05de5ca6e68303f2c6b6cbca5c34fc772219 |
|
db7e88b
6. validate in _validate_inner() / _validate_outer()
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/db7e88b2af63d60b3bab3728e0a72a280331d02c |
|
a43cb6e
7. allocate repeats_array for SRE_STATE
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/a43cb6e2d5125a87753467d52180585eb968f93b |
|
1560a0c
8. support code in sre_lib.h
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/1560a0cc5977bd12fbb8bae4e7a2210fa3d4073d |
|
96be025
9. add unit-tests
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/96be0259a7c512c20f14e7fb8234fc7931fdb526 |
|
7ee3e66
a. skip -= field_number
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/7ee3e669b08a84721e036b2f22256abc3f77521b |
|
e95b19f
b. improve unit-test
wjssz Apr 3, 2022
| https://github.com/python/cpython/pull/32283/commits/e95b19f63d36ede3525303e5363738d206083d47 |
|
Clear filters
| https://github.com/python/cpython/pull/32283/files |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
_compiler.py
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
_constants.py
| https://github.com/python/cpython/pull/32283/files#diff-13d8983b3481e2b0584fe946b8a4a0d43092e268242f74742fb20915b597d260 |
|
test_re.py
| https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
|
2022-04-03-13-19-08.bpo-23689.TFSc3E.rst
| https://github.com/python/cpython/pull/32283/files#diff-37fd96baaac2daaed259df860baa16f20cc1084ce0b040c84d782048528811d4 |
|
_sre.c
| https://github.com/python/cpython/pull/32283/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c |
|
_sre.c.h
| https://github.com/python/cpython/pull/32283/files#diff-bdd554b9bc8d7f61bf3f7cd13d35585a571de31b0a4b24dba719b67d94374b9e |
|
sre.h
| https://github.com/python/cpython/pull/32283/files#diff-39041e5cd265563ee9103fe4ab8a2dd1bcfaba8554f7dcbc827eb0538caf1819 |
|
sre_constants.h
| https://github.com/python/cpython/pull/32283/files#diff-fa3757d7529b86b657a4880fbfdc3c2c3aa9bd461422aa946f62b0d76904a7f7 |
|
sre_lib.h
| https://github.com/python/cpython/pull/32283/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6 |
| Lib/re/_compiler.py | https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
View file
| https://github.com/python/cpython/blob/e95b19f63d36ede3525303e5363738d206083d47/Lib/re/_compiler.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/32283/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
|
| https://github.com/python/cpython/pull/32283/files#diff-3e776e84b7a95409df7edfbf70c18876df4409abd1c339f756cbd523188999a6 |
| Lib/re/_constants.py | https://github.com/python/cpython/pull/32283/files#diff-13d8983b3481e2b0584fe946b8a4a0d43092e268242f74742fb20915b597d260 |
|
View file
| https://github.com/python/cpython/blob/e95b19f63d36ede3525303e5363738d206083d47/Lib/re/_constants.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/32283/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/32283/files#diff-13d8983b3481e2b0584fe946b8a4a0d43092e268242f74742fb20915b597d260 |
|
| https://github.com/python/cpython/pull/32283/files#diff-13d8983b3481e2b0584fe946b8a4a0d43092e268242f74742fb20915b597d260 |
| Lib/test/test_re.py | https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
|
View file
| https://github.com/python/cpython/blob/e95b19f63d36ede3525303e5363738d206083d47/Lib/test/test_re.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/32283/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
|
| https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
|
| https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Apr 3, 2022 | https://github.com/python/cpython/pull/32283/files#r841224755 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
| ghost | https://github.com/ghost |
| Apr 3, 2022 | https://github.com/python/cpython/pull/32283/files#r841226072 |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
| https://github.com/python/cpython/pull/32283/files#diff-8e462ca5167ec7a83a5710c179ef56cbae19cd614303fbcf2ec33fd9db914e2a |
| Misc/NEWS.d/next/Library/2022-04-03-13-19-08.bpo-23689.TFSc3E.rst | https://github.com/python/cpython/pull/32283/files#diff-37fd96baaac2daaed259df860baa16f20cc1084ce0b040c84d782048528811d4 |
|
View file
| https://github.com/python/cpython/blob/e95b19f63d36ede3525303e5363738d206083d47/Misc/NEWS.d/next/Library/2022-04-03-13-19-08.bpo-23689.TFSc3E.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/32283/{{ revealButtonHref }} |
| Please reload this page | https://github.com/python/cpython/pull/32283/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |