René's URL Explorer Experiment


Title: [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) by mareksuscak · Pull Request #32256 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) by mareksuscak · Pull Request #32256 · python/cpython

X Title: [3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) by mareksuscak · Pull Request #32256 · python/cpython

Description: This is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one because the one that superseded it and was implemented in Python 3.10 was larger in scope and technically considered a breaking change. This PR fixes bpo-34480. I'm adding two unit tests, one of which is based on a test case included in one of the comments and I want to give full credit for writing it to the original author Karthikeyan Singaravelan (xtreak). https://bugs.python.org/issue34480

Open Graph Description: This is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one becau...

X Description: This is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one becau...

Opengraph URL: https://github.com/python/cpython/pull/32256

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:584bdc60-8926-e938-a40e-64fb2c3c6bfd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD130:C419C:AB1929:E10CAE:696B566D
html-safe-nonce0c1b98882d00e18818d347cb0a840bb2f5e6622e5feff1d6516b0e800b5d0c0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTMwOkM0MTlDOkFCMTkyOTpFMTBDQUU6Njk2QjU2NkQiLCJ2aXNpdG9yX2lkIjoiNzExNTk3NjYwMTc1MjAwMDEwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac64033f8103777caba357838625f3cabf6332968bce499557246e3f8848ffc82f
hovercard-subject-tagpull_request:898128208
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/32256/files
twitter:imagehttps://avatars.githubusercontent.com/u/613647?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/613647?s=400&v=4
og:image:altThis is technically not a backport of the referenced PR because the original PR was superseded by another one and as such was not accepted. I was asked to base this change on the original one becau...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/32256/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32256%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32256%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/32256/files
Reloadhttps://github.com/python/cpython/pull/32256/files
Reloadhttps://github.com/python/cpython/pull/32256/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/32256/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/32256/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:3.9https://github.com/python/cpython/tree/3.9
mareksuscak:fix-issue-34480https://github.com/mareksuscak/cpython/tree/fix-issue-34480
Conversation 17 https://github.com/python/cpython/pull/32256
Commits 6 https://github.com/python/cpython/pull/32256/commits
Checks 0 https://github.com/python/cpython/pull/32256/checks
Files changed https://github.com/python/cpython/pull/32256/files
Please reload this pagehttps://github.com/python/cpython/pull/32256/files
[3.9] bpo-34480: fix bug where match variable is used prior to being defined (GH-17643) https://github.com/python/cpython/pull/32256/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/32256/files
105835c Fix bpo-31844 mareksuscak Apr 2, 2022 https://github.com/python/cpython/pull/32256/commits/105835c63ba6f241863dbb18969a8068e82a4a95
f94036b Add tests mareksuscak Apr 2, 2022 https://github.com/python/cpython/pull/32256/commits/f94036bcca7f54633aa5859fc735003ea664f408
ff38a95 Add comments pointing to the bpo issue and remove whitespace. ezio-melotti Apr 6, 2022 https://github.com/python/cpython/pull/32256/commits/ff38a95e48cad22013539d3f996b2a3b7f063877
ece3393 Merge branch '3.9' into fix-issue-34480 mareksuscak Apr 9, 2022 https://github.com/python/cpython/pull/32256/commits/ece339390a0e2bbe1e93f2102b7db22e6c496780
53755e1 📜🤖 Added by blurb_it. blurb-it[bot] Apr 9, 2022 https://github.com/python/cpython/pull/32256/commits/53755e1f491f798ae687839d7715e4663b59cca8
950fb57 Reword NEWS entry to be more high-level ambv May 16, 2022 https://github.com/python/cpython/pull/32256/commits/950fb5728cd1341e68da3c286da6a93cf4aff358
Clear filters https://github.com/python/cpython/pull/32256/files
Please reload this pagehttps://github.com/python/cpython/pull/32256/files
Please reload this pagehttps://github.com/python/cpython/pull/32256/files
_markupbase.py https://github.com/python/cpython/pull/32256/files#diff-7304624ffcc8be1268e5f86ebf1723034477694ce33456dc330f9c03f2d1e84f
test_htmlparser.py https://github.com/python/cpython/pull/32256/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
2022-04-09-11-28-49.bpo-34480.Pw-GJ6.rst https://github.com/python/cpython/pull/32256/files#diff-2d31b77cabe154700ef75154c2241da53e191b7537a73c754ce3f7b340cc969a
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L37
Lib/_markupbase.pyhttps://github.com/python/cpython/pull/32256/files#diff-7304624ffcc8be1268e5f86ebf1723034477694ce33456dc330f9c03f2d1e84f
View file https://github.com/mareksuscak/cpython/blob/950fb5728cd1341e68da3c286da6a93cf4aff358/Lib/_markupbase.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32256/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32256/files#diff-7304624ffcc8be1268e5f86ebf1723034477694ce33456dc330f9c03f2d1e84f
https://github.com/python/cpython/pull/32256/files#diff-7304624ffcc8be1268e5f86ebf1723034477694ce33456dc330f9c03f2d1e84f
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L38
Lib/test/test_htmlparser.pyhttps://github.com/python/cpython/pull/32256/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
View file https://github.com/mareksuscak/cpython/blob/950fb5728cd1341e68da3c286da6a93cf4aff358/Lib/test/test_htmlparser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32256/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32256/files#diff-af9cfc55cd005b23ab6a39c7c4aacc384812cd0ad58b0cc68af613bcda7ddddd
Misc/NEWS.d/next/Library/2022-04-09-11-28-49.bpo-34480.Pw-GJ6.rsthttps://github.com/python/cpython/pull/32256/files#diff-2d31b77cabe154700ef75154c2241da53e191b7537a73c754ce3f7b340cc969a
View file https://github.com/mareksuscak/cpython/blob/950fb5728cd1341e68da3c286da6a93cf4aff358/Misc/NEWS.d/next/Library/2022-04-09-11-28-49.bpo-34480.Pw-GJ6.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32256/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.