René's URL Explorer Experiment


Title: bpo-43224: Implement pickling of TypeVarTuples by mrahtz · Pull Request #32119 · python/cpython · GitHub

Open Graph Title: bpo-43224: Implement pickling of TypeVarTuples by mrahtz · Pull Request #32119 · python/cpython

X Title: bpo-43224: Implement pickling of TypeVarTuples by mrahtz · Pull Request #32119 · python/cpython

Description: Guess who learned a whole bunch about how pickling works :) Notes: I was a bit horrified to realise that the class I'd renamed to _BoundVarianceMixin also contains a key ingredient for pickling of things that use it! I've refactored its __reduce__ into a separate mixin for clarity. I'm not entirely sure whether these tests make sense - is assertEqual a reasonable way of testing this functionality? Am I correct in thinking we do need to test both assertEqual and assertIs for TypeVarTuples and unpacked TypeVarTuples? This PR doesn't include implementation of pickling support for unpacked native tuple; I'll do that in a future PR. (And I guess we'll also need to add tests for copy?) https://bugs.python.org/issue43224

Open Graph Description: Guess who learned a whole bunch about how pickling works :) Notes: I was a bit horrified to realise that the class I'd renamed to _BoundVarianceMixin also contains a key ingredient for picklin...

X Description: Guess who learned a whole bunch about how pickling works :) Notes: I was a bit horrified to realise that the class I'd renamed to _BoundVarianceMixin also contains a key ingredient for pic...

Opengraph URL: https://github.com/python/cpython/pull/32119

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa7d37e0-646d-00f6-eb6a-3f838c0b0fc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C4:E194E:E88993:133C5CA:696B631A
html-safe-nonce0e1085019721ab37e82566a4ffd1a7306390fd77c7ce083df4ab9c4bb664b8f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUM0OkUxOTRFOkU4ODk5MzoxMzNDNUNBOjY5NkI2MzFBIiwidmlzaXRvcl9pZCI6IjM5MTU3NzQ2NTUzNjM1MDY5NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1e3ed62a2ac4114e51d3e39ff7a718a1bf7d136b2d60371290d72358f1062dc7
hovercard-subject-tagpull_request:889945872
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/32119/files
twitter:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
og:image:altGuess who learned a whole bunch about how pickling works :) Notes: I was a bit horrified to realise that the class I'd renamed to _BoundVarianceMixin also contains a key ingredient for picklin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/32119/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32119%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32119%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/32119/files
Reloadhttps://github.com/python/cpython/pull/32119/files
Reloadhttps://github.com/python/cpython/pull/32119/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/32119/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/32119/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
mrahtz:pep646-pickling-testshttps://github.com/mrahtz/cpython/tree/pep646-pickling-tests
Conversation 27 https://github.com/python/cpython/pull/32119
Commits 12 https://github.com/python/cpython/pull/32119/commits
Checks 0 https://github.com/python/cpython/pull/32119/checks
Files changed 2 https://github.com/python/cpython/pull/32119/files
bpo-43224: Implement pickling of TypeVarTuples https://github.com/python/cpython/pull/32119/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/32119/files
5bdeab6 Implement pickling of TypeVarTuples mrahtz Mar 25, 2022 https://github.com/python/cpython/pull/32119/commits/5bdeab67a609308b59f53e7b5f738269eaf28095
2ea4127 Remove redundant tests mrahtz Mar 26, 2022 https://github.com/python/cpython/pull/32119/commits/2ea4127690b4be44eecf56cbd9fe2ca7f158d643
f234214 Test all pickle protocol versions mrahtz Mar 28, 2022 https://github.com/python/cpython/pull/32119/commits/f234214190a57e013b7e8abee3dc0844a470e581
de68232 Switch other tests to use @all_pickle_protocols too mrahtz Mar 28, 2022 https://github.com/python/cpython/pull/32119/commits/de682324fae78fef09b4530dba92fc0316bd2920
69197c2 Revert "Switch other tests to use @all_pickle_protocols too" mrahtz Mar 30, 2022 https://github.com/python/cpython/pull/32119/commits/69197c2113a138a8d91bd0db786f9b3dde74c5cf
72e3db5 Merge branch 'main' into pep646-pickling-tests mrahtz Apr 6, 2022 https://github.com/python/cpython/pull/32119/commits/72e3db51b77080c3f99dc11c56122e0bf2aeebcc
9a38a91 Tweak comment wording mrahtz Apr 15, 2022 https://github.com/python/cpython/pull/32119/commits/9a38a91c9fec9bd0064e89dfb540d9025dcb4483
8fd2b4f Remove test_pickling_then_unpickling_variadic_class_results_in_equality mrahtz Apr 15, 2022 https://github.com/python/cpython/pull/32119/commits/8fd2b4f8462ad76a3f61df022372de07efba03f5
ea8d5fd Remove parenthetic from comment mrahtz Apr 15, 2022 https://github.com/python/cpython/pull/32119/commits/ea8d5fd85b8a5ae185f7818eaeab195c8969c76e
d638d92 Replace assertEqual with assertIs mrahtz Apr 15, 2022 https://github.com/python/cpython/pull/32119/commits/d638d928a18842e36737ea5555597828b8b04581
c5d8dc6 Remove test_pickling_then_unpickling_variadic_func_results_in_equality mrahtz Apr 15, 2022 https://github.com/python/cpython/pull/32119/commits/c5d8dc6ce1b0209699be21cd90efdba153bdd064
e5501f4 Merge branch 'main' into pep646-pickling-tests JelleZijlstra Apr 21, 2022 https://github.com/python/cpython/pull/32119/commits/e5501f43ba257f978494d4bf9dfd10385373d788
Clear filters https://github.com/python/cpython/pull/32119/files
Please reload this pagehttps://github.com/python/cpython/pull/32119/files
Please reload this pagehttps://github.com/python/cpython/pull/32119/files
test_typing.py https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/mrahtz/cpython/blob/e5501f43ba257f978494d4bf9dfd10385373d788/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32119/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/32119/files
https://github.com/python/cpython/pull/32119/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/typing.pyhttps://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/mrahtz/cpython/blob/e5501f43ba257f978494d4bf9dfd10385373d788/Lib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32119/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/32119/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.