| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:18f8d1f1-950d-3c1b-23b8-c0753a5df9d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E928:29AA29:150F0:1A37D:696B575C |
| html-safe-nonce | ecacb1eeeb2cfbd9257651d846c6c1da727382d2ee235e3d8ba9e8b2c0025939 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTI4OjI5QUEyOToxNTBGMDoxQTM3RDo2OTZCNTc1QyIsInZpc2l0b3JfaWQiOiI4ODY2OTY0NzU2MDY5MzA4MjUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 34106796cca40c743f3a6b30fe2464944fa1c92570b2ded6bfed12b2a99c3e2c |
| hovercard-subject-tag | pull_request:137782031 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3208/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ce2b3d0fb950cfb850009a4cee40e1ab9beb99f4a4da3dd6589d01ca258f0436/python/cpython/pull/3208 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ce2b3d0fb950cfb850009a4cee40e1ab9beb99f4a4da3dd6589d01ca258f0436/python/cpython/pull/3208 |
| og:image:alt | fileinput otherwise works fine with pathlib.Path filenames, but when inplace is set to True, the Path object needs to be converted to a str first, or appending a str suffix with + would fail:
impor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zmwangx |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/3208#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3208 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3208 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/3208 |
| Reload | https://github.com/python/cpython/pull/3208 |
| Reload | https://github.com/python/cpython/pull/3208 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/3208#issue-comment-box |
| ericvsmith | https://github.com/ericvsmith |
| python:master | https://github.com/python/cpython/tree/master |
| zmwangx:fileinput-pathlib-inplace | https://github.com/zmwangx/cpython/tree/fileinput-pathlib-inplace |
|
bpo-31281: Fix pathlib.Path incompatibility in fileinput
| https://github.com/python/cpython/pull/3208#top |
| ericvsmith | https://github.com/ericvsmith |
| python:master | https://github.com/python/cpython/tree/master |
| zmwangx:fileinput-pathlib-inplace | https://github.com/zmwangx/cpython/tree/fileinput-pathlib-inplace |
|
Conversation
4
| https://github.com/python/cpython/pull/3208 |
|
Commits
1
| https://github.com/python/cpython/pull/3208/commits |
|
Checks
0
| https://github.com/python/cpython/pull/3208/checks |
|
Files changed
| https://github.com/python/cpython/pull/3208/files |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/zmwangx |
| zmwangx | https://github.com/zmwangx |
| Aug 26, 2017 | https://github.com/python/cpython/pull/3208#issue-253054552 |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| https://bugs.python.org/issue31281 | https://bugs.python.org/issue31281 |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Aug 26, 2017 | https://github.com/python/cpython/pull/3208#event-1222349176 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 26, 2017 | https://github.com/python/cpython/pull/3208#event-1222349179 |
| https://github.com/ericvsmith |
| ericvsmith | https://github.com/ericvsmith |
|
Aug 27, 2017
| https://github.com/python/cpython/pull/3208#pullrequestreview-58833215 |
|
View reviewed changes
| https://github.com/python/cpython/pull/3208/files |
| Lib/fileinput.py | https://github.com/python/cpython/pull/3208/files#diff-12e480fbf7f53af3020ff003894175735fffdc263ba9680dde66de17c6abcdff |
| ericvsmith | https://github.com/ericvsmith |
| Aug 27, 2017 | https://github.com/python/cpython/pull/3208#discussion_r135422910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| zmwangx | https://github.com/zmwangx |
| Aug 27, 2017 | https://github.com/python/cpython/pull/3208#discussion_r135423364 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ericvsmith | https://github.com/ericvsmith |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| https://github.com/zmwangx |
| zmwangx | https://github.com/zmwangx |
| force-pushed | https://github.com/python/cpython/compare/35ef435976e2214016def9ede88e8e3b81dbaf91..10792d12043c47deb4c82acc6dd5d6162d7cb146 |
| 35ef435 | https://github.com/python/cpython/commit/35ef435976e2214016def9ede88e8e3b81dbaf91 |
| 10792d1 | https://github.com/python/cpython/commit/10792d12043c47deb4c82acc6dd5d6162d7cb146 |
|
Compare
| https://github.com/python/cpython/compare/35ef435976e2214016def9ede88e8e3b81dbaf91..10792d12043c47deb4c82acc6dd5d6162d7cb146 |
| August 27, 2017 22:51 | https://github.com/python/cpython/pull/3208#event-1222936008 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 27, 2017 | https://github.com/python/cpython/pull/3208#event-1222936067 |
| https://github.com/ericvsmith |
| ericvsmith | https://github.com/ericvsmith |
| Aug 28, 2017 | https://github.com/python/cpython/pull/3208#issuecomment-325466600 |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
|
| https://github.com/zmwangx |
| bpo-31281: Fix pathlib.Path incompatibility in fileinput | https://github.com/python/cpython/pull/3208/commits/590e22816849af9d8bd5f6d263c007594aef126c |
| 590e228 | https://github.com/python/cpython/pull/3208/commits/590e22816849af9d8bd5f6d263c007594aef126c |
| https://github.com/zmwangx |
| zmwangx | https://github.com/zmwangx |
| force-pushed | https://github.com/python/cpython/compare/10792d12043c47deb4c82acc6dd5d6162d7cb146..590e22816849af9d8bd5f6d263c007594aef126c |
| 10792d1 | https://github.com/python/cpython/commit/10792d12043c47deb4c82acc6dd5d6162d7cb146 |
| 590e228 | https://github.com/python/cpython/commit/590e22816849af9d8bd5f6d263c007594aef126c |
|
Compare
| https://github.com/python/cpython/compare/10792d12043c47deb4c82acc6dd5d6162d7cb146..590e22816849af9d8bd5f6d263c007594aef126c |
| August 28, 2017 23:15 | https://github.com/python/cpython/pull/3208#event-1224666806 |
| https://github.com/zmwangx |
| zmwangx | https://github.com/zmwangx |
| Aug 28, 2017 | https://github.com/python/cpython/pull/3208#issuecomment-325509233 |
| @ericvsmith | https://github.com/ericvsmith |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
| https://github.com/ericvsmith |
| ericvsmith | https://github.com/ericvsmith |
|
Sep 4, 2017
| https://github.com/python/cpython/pull/3208#pullrequestreview-60454554 |
|
View reviewed changes
| https://github.com/python/cpython/pull/3208/files/590e22816849af9d8bd5f6d263c007594aef126c |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 4, 2017 | https://github.com/python/cpython/pull/3208#event-1233833830 |
| https://github.com/ericvsmith |
| ericvsmith | https://github.com/ericvsmith |
| 06de1ae | https://github.com/python/cpython/commit/06de1aeff94e524bed21d188065c4cd1590fb046 |
| Sep 4, 2017 | https://github.com/python/cpython/pull/3208#event-1233836398 |
| https://github.com/ericvsmith |
| ericvsmith | https://github.com/ericvsmith |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Sep 4, 2017 | https://github.com/python/cpython/pull/3208#event-1233836863 |
| jimmylai | https://github.com/jimmylai |
|
Sep 4, 2017
| https://github.com/python/cpython/pull/3208#ref-commit-923312f |
| Merge branch 'master' of | https://github.com/jimmylai/cpython/commit/923312f9bdda0b656965dc874df6095f9f4c285d |
| https://github.com/python/cpython | https://github.com/python/cpython |
| 923312f | https://github.com/jimmylai/cpython/commit/923312f9bdda0b656965dc874df6095f9f4c285d |
| https://github.com/python/cpython | https://github.com/python/cpython |
| python#3285 | https://github.com/python/cpython/pull/3285 |
| python#3284 | https://github.com/python/cpython/pull/3284 |
| pythongh-3208 | https://github.com/python/cpython/pull/3208 |
| python#3283 | https://github.com/python/cpython/pull/3283 |
| python#3281 | https://github.com/python/cpython/pull/3281 |
| python#2395 | https://github.com/python/cpython/pull/2395 |
| python#3278 | https://github.com/python/cpython/pull/3278 |
| python#3275 | https://github.com/python/cpython/pull/3275 |
| python#3270 | https://github.com/python/cpython/pull/3270 |
| python#3076 | https://github.com/python/cpython/pull/3076 |
| python#3008 | https://github.com/python/cpython/pull/3008 |
| python#3263 | https://github.com/python/cpython/pull/3263 |
| python#3264 | https://github.com/python/cpython/pull/3264 |
| python#3265 | https://github.com/python/cpython/pull/3265 |
| python#1560 | https://github.com/python/cpython/pull/1560 |
| python#3252 | https://github.com/python/cpython/pull/3252 |
| python#3260 | https://github.com/python/cpython/pull/3260 |
| python#1220 | https://github.com/python/cpython/pull/1220 |
| pythonGH-3228 | https://github.com/python/cpython/pull/3228 |
| python#3245 | https://github.com/python/cpython/pull/3245 |
| https://github.com/zmwangx |
| zmwangx | https://github.com/zmwangx |
| September 5, 2017 00:33 | https://github.com/python/cpython/pull/3208#event-1234030885 |
| GadgetSteve | https://github.com/GadgetSteve |
|
Sep 10, 2017
| https://github.com/python/cpython/pull/3208#ref-commit-62d9838 |
|
| https://github.com/zmwangx |
|
| https://github.com/GadgetSteve |
| bpo-31281: Fix pathlib.Path incompatibility in fileinput ( | https://github.com/GadgetSteve/cpython/commit/62d98388422509585fee4e96c0db6f8fc95d61ee |
| pythongh-3208 | https://github.com/python/cpython/pull/3208 |
| ) | https://github.com/GadgetSteve/cpython/commit/62d98388422509585fee4e96c0db6f8fc95d61ee |
| 62d9838 | https://github.com/GadgetSteve/cpython/commit/62d98388422509585fee4e96c0db6f8fc95d61ee |
| https://github.com/Mariatta |
| Mariatta | https://github.com/Mariatta |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 8, 2017 | https://github.com/python/cpython/pull/3208#event-1283083109 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3208 |
|
| https://github.com/ericvsmith |
|
ericvsmith
| https://github.com/ericvsmith |
|
| https://github.com/python/cpython/pull/3208/files/590e22816849af9d8bd5f6d263c007594aef126c |
| Please reload this page | https://github.com/python/cpython/pull/3208 |
|
| https://github.com/zmwangx |
|
| https://github.com/ericvsmith |
|
| https://github.com/Mariatta |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |