René's URL Explorer Experiment


Title: gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked by kumaraditya303 · Pull Request #32073 · python/cpython · GitHub

Open Graph Title: gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked by kumaraditya303 · Pull Request #32073 · python/cpython

X Title: gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked by kumaraditya303 · Pull Request #32073 · python/cpython

Description: This PR fixes the issue by calling the waiters after all the callbacks are executed so that no callbacks are scheduled after the method returns. Issue: gh-88050

Open Graph Description: This PR fixes the issue by calling the waiters after all the callbacks are executed so that no callbacks are scheduled after the method returns. Issue: gh-88050

X Description: This PR fixes the issue by calling the waiters after all the callbacks are executed so that no callbacks are scheduled after the method returns. Issue: gh-88050

Opengraph URL: https://github.com/python/cpython/pull/32073

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:29d2f32d-deed-9a8c-7aac-de7b406c76fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB834:30F550:275A5:3534F:696A0BB4
html-safe-noncebb1ae149613e71e5fc42904e6ae87efcee58a6b1b4297ef7cafae88a3019c907
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODM0OjMwRjU1MDoyNzVBNTozNTM0Rjo2OTZBMEJCNCIsInZpc2l0b3JfaWQiOiI3ODExNjczNTQ0NjM3MTU2Mjc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99de60ebb3aebe1397ed101bba37c1fb2f567fbf705e78ee39db1e3b24b57dcc
hovercard-subject-tagpull_request:886957188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/32073/files
twitter:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
og:image:altThis PR fixes the issue by calling the waiters after all the callbacks are executed so that no callbacks are scheduled after the method returns. Issue: gh-88050
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/32073/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32073%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F32073%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/32073/files
Reloadhttps://github.com/python/cpython/pull/32073/files
Reloadhttps://github.com/python/cpython/pull/32073/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
kumaraditya303:fix-asyncio-subprocesshttps://github.com/kumaraditya303/cpython/tree/fix-asyncio-subprocess
Conversation 32 https://github.com/python/cpython/pull/32073
Commits 25 https://github.com/python/cpython/pull/32073/commits
Checks 0 https://github.com/python/cpython/pull/32073/checks
Files changed https://github.com/python/cpython/pull/32073/files
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
gh-88050: Fix asyncio subprocess kill process cleanly when process is blocked https://github.com/python/cpython/pull/32073/files#top
Show all changes 25 commits https://github.com/python/cpython/pull/32073/files
485b26b bpo-43884: Fix asyncio subprocess kill process cleanly when process i… kumaraditya303 Mar 23, 2022 https://github.com/python/cpython/pull/32073/commits/485b26b6825b09bc581a599f350c58116bbb0772
7c10817 Merge branch 'main' of https://github.com/python/cpython into fix-asy… kumaraditya303 Mar 24, 2022 https://github.com/python/cpython/pull/32073/commits/7c1081792e24427ea3635c8cf5e8991523a2428f
0b87f8d rework kumaraditya303 Mar 24, 2022 https://github.com/python/cpython/pull/32073/commits/0b87f8d2d9a84bf89bbf174a71e638615b1db43c
2bd08cf start from scratch kumaraditya303 Mar 28, 2022 https://github.com/python/cpython/pull/32073/commits/2bd08cf005a37afcbbee3cb042d02f66ce4528f2
6afa6df Merge branch 'main' of https://github.com/python/cpython into fix-asy… kumaraditya303 Mar 28, 2022 https://github.com/python/cpython/pull/32073/commits/6afa6dffe2eb44a7f62ec5bd4a73f918fde6c2f8
a2a3a1d rework kumaraditya303 Mar 28, 2022 https://github.com/python/cpython/pull/32073/commits/a2a3a1dcac03421e05e5dbb1c10d6dc446f038ee
e325b6c remove script kumaraditya303 Mar 28, 2022 https://github.com/python/cpython/pull/32073/commits/e325b6ccaf97aab834c61411abbd889d48312543
6a37501 Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Apr 17, 2022 https://github.com/python/cpython/pull/32073/commits/6a37501684c58a628cdcbf88b11f234f7ad34383
5fa81d6 Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 May 4, 2022 https://github.com/python/cpython/pull/32073/commits/5fa81d68434609ff7d0f2badae58360de81f97a1
74e42a7 Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 May 27, 2022 https://github.com/python/cpython/pull/32073/commits/74e42a73fcd2867c5b07c6434fd41505e511f80d
7946267 another try kumaraditya303 May 27, 2022 https://github.com/python/cpython/pull/32073/commits/79462673ac15759837790c49c5b007449288c858
4f18b7d Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Jul 7, 2022 https://github.com/python/cpython/pull/32073/commits/4f18b7da3a4ef7f66c5514d583fc33d17c09fe10
d896e0b skip unless sleep kumaraditya303 Jul 8, 2022 https://github.com/python/cpython/pull/32073/commits/d896e0bb2e7d4d3b9fedff1828667caa375de2ce
b5de374 📜🤖 Added by blurb_it. blurb-it[bot] Jul 8, 2022 https://github.com/python/cpython/pull/32073/commits/b5de3749c2d35e5857a4dfb1da6c8cea7bc18ca8
727bb9e Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Jul 21, 2022 https://github.com/python/cpython/pull/32073/commits/727bb9e6d711824046438ef4c97700212d8754e1
e7eca7a Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Sep 12, 2022 https://github.com/python/cpython/pull/32073/commits/e7eca7a355928a33333bf4f8ffc3f4905124313c
8b2cee6 fix test on windows kumaraditya303 Oct 1, 2022 https://github.com/python/cpython/pull/32073/commits/8b2cee6adae75c0bcb1768b211a9801d2184663d
53fbc9a fix comment kumaraditya303 Oct 1, 2022 https://github.com/python/cpython/pull/32073/commits/53fbc9a8d2bfc147db364f712f145d1ef63f4559
77c76dd Merge branch 'main' of https://github.com/python/cpython into fix-asy… kumaraditya303 Oct 1, 2022 https://github.com/python/cpython/pull/32073/commits/77c76ddbd34747ee05979fb74c49d29776534ba4
e223141 Update Misc/NEWS.d/next/Library/2022-07-08-08-39-35.gh-issue-88050.0a… kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/e223141489cd91e2edd83ec38d2e7c7e17fe5738
4ac1184 Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/4ac11845bc3891139dd7868af40d6a0df9db8626
69a9fda fixup test as Guido suggested kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/69a9fda6eb1efdfd1916458cb3e5462c777508c2
678cc76 Merge branch 'main' into fix-asyncio-subprocess kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/678cc760e34278e81ac824a75e1f998e4efcf45a
ba0382d fix killing on windows kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/ba0382d827ff8d1ac0d7748f7d641f4868b9d299
90e7ac5 Merge branch 'fix-asyncio-subprocess' of https://github.com/kumaradit… kumaraditya303 Oct 5, 2022 https://github.com/python/cpython/pull/32073/commits/90e7ac569f9be2dd7460afddf9c3d55da5ee7efb
Clear filters https://github.com/python/cpython/pull/32073/files
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
base_subprocess.py https://github.com/python/cpython/pull/32073/files#diff-1872d71f2f6b89c01ddde298ca5cd387f5dcbbd90a5341463761bc69338ea69a
test_subprocess.py https://github.com/python/cpython/pull/32073/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2
2022-07-08-08-39-35.gh-issue-88050.0aOC_m.rst https://github.com/python/cpython/pull/32073/files#diff-15c66afa01745b3fdaeeb21ef9bdfe9001624f4bb8a101005c00a9e0e372528d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L369
Lib/asyncio/base_subprocess.pyhttps://github.com/python/cpython/pull/32073/files#diff-1872d71f2f6b89c01ddde298ca5cd387f5dcbbd90a5341463761bc69338ea69a
View file https://github.com/kumaraditya303/cpython/blob/90e7ac569f9be2dd7460afddf9c3d55da5ee7efb/Lib/asyncio/base_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32073/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32073/files#diff-1872d71f2f6b89c01ddde298ca5cd387f5dcbbd90a5341463761bc69338ea69a
https://github.com/python/cpython/pull/32073/files#diff-1872d71f2f6b89c01ddde298ca5cd387f5dcbbd90a5341463761bc69338ea69a
https://github.com/python/cpython/pull/32073/files#diff-1872d71f2f6b89c01ddde298ca5cd387f5dcbbd90a5341463761bc69338ea69a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_subprocess.pyhttps://github.com/python/cpython/pull/32073/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2
View file https://github.com/kumaraditya303/cpython/blob/90e7ac569f9be2dd7460afddf9c3d55da5ee7efb/Lib/test/test_asyncio/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32073/{{ revealButtonHref }}
https://github.com/python/cpython/pull/32073/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2
https://github.com/python/cpython/pull/32073/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
Please reload this pagehttps://github.com/python/cpython/pull/32073/files
https://github.com/python/cpython/pull/32073/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2
Misc/NEWS.d/next/Library/2022-07-08-08-39-35.gh-issue-88050.0aOC_m.rsthttps://github.com/python/cpython/pull/32073/files#diff-15c66afa01745b3fdaeeb21ef9bdfe9001624f4bb8a101005c00a9e0e372528d
View file https://github.com/kumaraditya303/cpython/blob/90e7ac569f9be2dd7460afddf9c3d55da5ee7efb/Misc/NEWS.d/next/Library/2022-07-08-08-39-35.gh-issue-88050.0aOC_m.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/32073/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.