Title: bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects by ericsnowcurrently · Pull Request #32061 · python/cpython · GitHub
Open Graph Title: bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects by ericsnowcurrently · Pull Request #32061 · python/cpython
X Title: bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects by ericsnowcurrently · Pull Request #32061 · python/cpython
Description: We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed in the repo). However, building $(PYTHON_FOR_FREEZE) fails if one of its source files had a global object added or removed, without generate-global-objects.py running first. So make regen-global-objects would sometimes fail. We solve this by running generate-global-objects.py before and after regen-deepfreeze. To speed things up and cut down on noise, we also avoid updating the global objects files if there are no changes. https://bugs.python.org/issue46712
Open Graph Description: We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed in t...
X Description: We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed ...
Opengraph URL: https://github.com/python/cpython/pull/32061
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:737f7ec9-8968-d57c-c79a-f34540ffb0a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C318:192D74:CF6D38:1107B20:696B2842 |
| html-safe-nonce | fbe67b26dcab2cc935d1fcd028720a96d1496f5e0b58670f37eaf9cbe97341f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzE4OjE5MkQ3NDpDRjZEMzg6MTEwN0IyMDo2OTZCMjg0MiIsInZpc2l0b3JfaWQiOiI1OTAxMzI2ODkwODY0MTU4Nzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1b84b2be55117e9429c8f4b437307ed243caa7a26fb609c1f79d2aaa20c503fc |
| hovercard-subject-tag | pull_request:886582873 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/32061/files |
| twitter:image | https://avatars.githubusercontent.com/u/1152074?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1152074?s=400&v=4 |
| og:image:alt | We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed in t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width