René's URL Explorer Experiment


Title: bpo-43224: Fix Tuple[()].__args__ by mrahtz · Pull Request #31845 · python/cpython · GitHub

Open Graph Title: bpo-43224: Fix Tuple[()].__args__ by mrahtz · Pull Request #31845 · python/cpython

X Title: bpo-43224: Fix Tuple[()].__args__ by mrahtz · Pull Request #31845 · python/cpython

Description: Here's a fun inconsistency: >>> Tuple[()].__args__ ((),) >>> tuple[()].__args__ () Even though there's an explicit test for the former behaviour, I don't think it's right: Argument 1: If foo.__args__ is (bar,), that says that foo is being parameterised by bar. When we do Tuple[()], it's really just to get around the fact that Tuple[] is invalid syntax - what we're really meaning to say is that we're not parameterising it with anything. Tuple[()].__args__ should therefore be empty. Argument 2: Everything in Tuple[...].__args__ should be a type. () is not a type. This matters for PEP 646, where we were expecting that a TypeVarTuple with no arguments would expand to nothing rather than (). If we were to change things so it was consistent with the current behaviour of Tuple[()], we'd have T = TypeVar('T') Ts = TypeVarTuple('Ts') class C(Generic[T, *Ts]): pass Alias = C[int, *Ts] Alias[()] # C[int, ()] which definitely isn't what we want. @ilevkivskyi who added the test for the former behaviour, according to the git blame. Is there something I'm missing here? https://bugs.python.org/issue43224

Open Graph Description: Here's a fun inconsistency: >>> Tuple[()].__args__ ((),) >>> tuple[()].__args__ () Even though there's an explicit test for the former behaviour, I don't think it'...

X Description: Here's a fun inconsistency: >>> Tuple[()].__args__ ((),) >>> tuple[()].__args__ () Even though there's an explicit test for the former beha...

Opengraph URL: https://github.com/python/cpython/pull/31845

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4935d2c6-8ecf-42fb-0e62-093c98c40922
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8D0:14FC13:1D232E8:269DC83:696AFE46
html-safe-noncee5cea072bc6f4085f6ee0c90dbf8bdca7423f8aef283bd8bc0db254203258371
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEQwOjE0RkMxMzoxRDIzMkU4OjI2OURDODM6Njk2QUZFNDYiLCJ2aXNpdG9yX2lkIjoiNDUxOTE5ODAwNTQ2NTM4MjQ3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac94114eef72f6d146080a815d22c01f485b667a638ce0057233fffde2f81cee7f
hovercard-subject-tagpull_request:878385732
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/31845/files
twitter:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
og:image:altHere's a fun inconsistency: >>> Tuple[()].__args__ ((),) >>> tuple[()].__args__ () Even though there's an explicit test for the former behaviour, I don't think it'...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31845/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31845%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31845%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31845/files
Reloadhttps://github.com/python/cpython/pull/31845/files
Reloadhttps://github.com/python/cpython/pull/31845/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31845/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31845/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mrahtzhttps://github.com/mrahtz
python:mainhttps://github.com/python/cpython/tree/main
mrahtz:fix-tuple-argshttps://github.com/mrahtz/cpython/tree/fix-tuple-args
Conversation 2 https://github.com/python/cpython/pull/31845
Commits 1 https://github.com/python/cpython/pull/31845/commits
Checks 0 https://github.com/python/cpython/pull/31845/checks
Files changed https://github.com/python/cpython/pull/31845/files
Please reload this pagehttps://github.com/python/cpython/pull/31845/files
bpo-43224: Fix Tuple[()].__args__ https://github.com/python/cpython/pull/31845/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/31845/files
04b2394 Fix Tuple[()].__args__ mrahtz Mar 13, 2022 https://github.com/python/cpython/pull/31845/commits/04b23947c897adb55934b2d6ffba4a97a0a0619c
Clear filters https://github.com/python/cpython/pull/31845/files
Please reload this pagehttps://github.com/python/cpython/pull/31845/files
Please reload this pagehttps://github.com/python/cpython/pull/31845/files
test_typing.py https://github.com/python/cpython/pull/31845/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/31845/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/31845/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/mrahtz/cpython/blob/04b23947c897adb55934b2d6ffba4a97a0a0619c/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31845/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31845/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/31845/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/typing.pyhttps://github.com/python/cpython/pull/31845/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/mrahtz/cpython/blob/04b23947c897adb55934b2d6ffba4a97a0a0619c/Lib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31845/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31845/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/31845/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.