| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3cf66d74-77c6-606b-09a1-bd38818f71ae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D268:23E3D6:96A623:D0BA54:696A82B2 |
| html-safe-nonce | c11b52dddbe94a093e35d8d815a6230584dc7536699d47106629d11e24dd1a83 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjY4OjIzRTNENjo5NkE2MjM6RDBCQTU0OjY5NkE4MkIyIiwidmlzaXRvcl9pZCI6IjI4NDc0MDI0NTUzMTE0ODM1NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 101a0dceb495e133dd5db5212ec9376850ac89268fa997a626514e27cb1cb123 |
| hovercard-subject-tag | pull_request:878371665 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/31844/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a70b4752a5dcdfd5621ccb69b773c3d34b99207015ee335e3a4f4662fe065ee0/python/cpython/pull/31844 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a70b4752a5dcdfd5621ccb69b773c3d34b99207015ee335e3a4f4662fe065ee0/python/cpython/pull/31844 |
| og:image:alt | Here are some more tests for the updated type variable substitution logic in #31800 (along with a fix for converting e.g. *tuple[int] into just int).
There are existing tests for some of this in e.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mrahtz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5998c30593994bf2589055aef7b22d368a499367 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/31844#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31844 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31844 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/31844 |
| Reload | https://github.com/python/cpython/pull/31844 |
| Reload | https://github.com/python/cpython/pull/31844 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/31844#issue-comment-box |
| mrahtz | https://github.com/mrahtz |
| python:main | https://github.com/python/cpython/tree/main |
| mrahtz:typevartuple-subst-tests | https://github.com/mrahtz/cpython/tree/typevartuple-subst-tests |
|
bpo-43224: Add more tests for typevar substitution
| https://github.com/python/cpython/pull/31844#top |
| mrahtz | https://github.com/mrahtz |
| python:main | https://github.com/python/cpython/tree/main |
| mrahtz:typevartuple-subst-tests | https://github.com/mrahtz/cpython/tree/typevartuple-subst-tests |
|
Conversation
2
| https://github.com/python/cpython/pull/31844 |
|
Commits
3
| https://github.com/python/cpython/pull/31844/commits |
|
Checks
0
| https://github.com/python/cpython/pull/31844/checks |
|
Files changed
| https://github.com/python/cpython/pull/31844/files |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/mrahtz |
| mrahtz | https://github.com/mrahtz |
| Mar 13, 2022 | https://github.com/python/cpython/pull/31844#issue-1167558129 |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
| #31800 | https://github.com/python/cpython/pull/31800 |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| @pradeep90 | https://github.com/pradeep90 |
| @serhiy-storchaka | https://github.com/serhiy-storchaka |
| #31828 | https://github.com/python/cpython/pull/31828 |
| https://bugs.python.org/issue43224 | https://bugs.python.org/issue43224 |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
| mrahtz | https://github.com/mrahtz |
| March 13, 2022 11:38 | https://github.com/python/cpython/pull/31844#commits-pushed-eb1a7ab |
|
| https://github.com/mrahtz |
| Refactor typevar substitution into separate helper for easier testing | https://github.com/python/cpython/pull/31844/commits/eb1a7ab74c24829131bb177f0bc24aa6bba82799 |
| eb1a7ab | https://github.com/python/cpython/pull/31844/commits/eb1a7ab74c24829131bb177f0bc24aa6bba82799 |
|
| https://github.com/mrahtz |
| Deal properly with e.g. *tuple[int] | https://github.com/python/cpython/pull/31844/commits/f500d5909fcca23392a361271957a3e55f86f9d1 |
| f500d59 | https://github.com/python/cpython/pull/31844/commits/f500d5909fcca23392a361271957a3e55f86f9d1 |
|
| https://github.com/mrahtz |
| Add more tests for typevar substitution | https://github.com/python/cpython/pull/31844/commits/8611053d00b2cc95035031cf435c2cf9b1577c44 |
| 8611053 | https://github.com/python/cpython/pull/31844/commits/8611053d00b2cc95035031cf435c2cf9b1577c44 |
| https://github.com/mrahtz |
| mrahtz | https://github.com/mrahtz |
| Fidget-Spinner | https://github.com/Fidget-Spinner |
| JelleZijlstra | https://github.com/JelleZijlstra |
| gvanrossum | https://github.com/gvanrossum |
| code owners | https://github.com/python/cpython/blob/3543ddb4c4ebc26fb2d6c67a97e66f5267876f72/.github/CODEOWNERS#L133 |
| March 13, 2022 11:50 | https://github.com/python/cpython/pull/31844#event-6231003274 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 13, 2022 | https://github.com/python/cpython/pull/31844#event-6231003324 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Mar 13, 2022 | https://github.com/python/cpython/pull/31844#event-6231003335 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Mar 17, 2022
| https://github.com/python/cpython/pull/31844#pullrequestreview-912754217 |
|
View reviewed changes
| https://github.com/python/cpython/pull/31844/files/8611053d00b2cc95035031cf435c2cf9b1577c44 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Mar 17, 2022 | https://github.com/python/cpython/pull/31844#event-6256739119 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 17, 2022 | https://github.com/python/cpython/pull/31844#issuecomment-1070814745 |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
| https://github.com/mrahtz |
| mrahtz | https://github.com/mrahtz |
| Apr 5, 2022 | https://github.com/python/cpython/pull/31844#issuecomment-1089179937 |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
| https://github.com/mrahtz |
| mrahtz | https://github.com/mrahtz |
| Apr 5, 2022 | https://github.com/python/cpython/pull/31844#event-6373803147 |
| https://github.com/python/cpython/pull/31844 |
| mrahtz | https://github.com/python/cpython/pull/31844 |
|
Apr 11, 2022
| https://github.com/python/cpython/pull/31844#ref-issue-1199052823 |
|
Add support for PEP 646
#87390
| https://github.com/python/cpython/issues/87390 |
| https://github.com/mrahtz |
| mrahtz | https://github.com/mrahtz |
| May 1, 2022 15:30 | https://github.com/python/cpython/pull/31844#event-6529686689 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31844 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/31844/files/8611053d00b2cc95035031cf435c2cf9b1577c44 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/Fidget-Spinner |
|
Fidget-Spinner
| https://github.com/Fidget-Spinner |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Please reload this page | https://github.com/python/cpython/pull/31844 |
|
| https://github.com/mrahtz |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |