René's URL Explorer Experiment


Title: gh-91090: Make started multiprocessing.Process instances and started multiprocessing.managers.BaseManager instances serialisable by geryogam · Pull Request #31701 · python/cpython · GitHub

Open Graph Title: gh-91090: Make started multiprocessing.Process instances and started multiprocessing.managers.BaseManager instances serialisable by geryogam · Pull Request #31701 · python/cpython

X Title: gh-91090: Make started multiprocessing.Process instances and started multiprocessing.managers.BaseManager instances serialisable by geryogam · Pull Request #31701 · python/cpython

Description: Since starting a multiprocessing.Process instance p stores a weak reference at p._popen.finalizer._weakref which makes p unserialisable, we solve that issue by storing only the _key of the finalizer (instead of the whole finalizer) whose mapping to the finalizer is stored in the multiprocessing.util._finalizer_registry dictionary. Likewise, we also make started multiprocessing.managers.BaseManager instances serialisable. Issue: gh-91090

Open Graph Description: Since starting a multiprocessing.Process instance p stores a weak reference at p._popen.finalizer._weakref which makes p unserialisable, we solve that issue by storing only the _key of the finalize...

X Description: Since starting a multiprocessing.Process instance p stores a weak reference at p._popen.finalizer._weakref which makes p unserialisable, we solve that issue by storing only the _key of the finalize...

Opengraph URL: https://github.com/python/cpython/pull/31701

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f4569053-9637-bfe4-69b0-4595e6c05974
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD02:1A500C:C6CD7:100B81:696AD471
html-safe-nonce1aa7bc289c55280024fc17b805fb4278755c8b7caa7cfaf22f1ed803a3d35e17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDAyOjFBNTAwQzpDNkNENzoxMDBCODE6Njk2QUQ0NzEiLCJ2aXNpdG9yX2lkIjoiMjY5MjkxNjg0OTY1NjEyNDUyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceb7d5723e82baf0135edb495e3369148cbd383aaba874fa31239b360237c2b48
hovercard-subject-tagpull_request:872345328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/31701/files
twitter:imagehttps://avatars.githubusercontent.com/u/33548838?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/33548838?s=400&v=4
og:image:altSince starting a multiprocessing.Process instance p stores a weak reference at p._popen.finalizer._weakref which makes p unserialisable, we solve that issue by storing only the _key of the finalize...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31701/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31701%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31701%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31701/files
Reloadhttps://github.com/python/cpython/pull/31701/files
Reloadhttps://github.com/python/cpython/pull/31701/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31701/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31701/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
geryogamhttps://github.com/geryogam
python:mainhttps://github.com/python/cpython/tree/main
geryogam:patch-21https://github.com/geryogam/cpython/tree/patch-21
Conversation 11 https://github.com/python/cpython/pull/31701
Commits 26 https://github.com/python/cpython/pull/31701/commits
Checks 0 https://github.com/python/cpython/pull/31701/checks
Files changed 5 https://github.com/python/cpython/pull/31701/files
gh-91090: Make started multiprocessing.Process instances and started multiprocessing.managers.BaseManager instances serialisable https://github.com/python/cpython/pull/31701/files#top
Show all changes 26 commits https://github.com/python/cpython/pull/31701/files
d628fc1 Update popen_spawn_posix.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/d628fc1bf59fcf1e82a4a6aa912c0cbcf8f4381f
e369d5e Update popen_fork.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/e369d5e554b5b3816f0a8543ae66275b61936912
590f446 Update popen_forkserver.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/590f44643e50a1a7eaa2f9a2321a7fd3880580de
941e4c0 Update popen_spawn_win32.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/941e4c074aae3a3e89476e987c46d2222690fca0
e2a93dc Update managers.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/e2a93dcd6ead74542c17744d38fc8862e255d71b
2513628 Update popen_spawn_win32.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/2513628df54796444a15f77f4d61d8d2b929cd46
c55302b Update popen_fork.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/c55302bab84003e8734deec4144bfc0f2ab81335
409349f Update popen_forkserver.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/409349f53f44595c33b6a1cccf08491523806b3d
2eeeeb6 Update popen_spawn_posix.py geryogam Mar 5, 2022 https://github.com/python/cpython/pull/31701/commits/2eeeeb6e4c7be488aeea9bcec16eed450a01c4b7
ade0b2a Add unit tests geryogam Nov 29, 2022 https://github.com/python/cpython/pull/31701/commits/ade0b2adb83c5e6a1c5d2306bb8c373bd794afbc
71eb4e1 Add a NEWS entry geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/71eb4e15d314a0885b7add448b7fd5d85d7199cb
1419e0d Make State instances pickable with the old text protocol geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/1419e0d95803e9c890ed6b93fc60a79a0584e117
1e53631 Add restoration of spawning_popen geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/1e5363173be9103e0e45d9fcdc88350b49c0db94
56f0bb8 Revert "Update popen_spawn_posix.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/56f0bb8d9891609c433a33eb240691e72ddc828c
9f76108 Revert "Update popen_forkserver.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/9f761088c709e5a46986e97e247f06d1e89ceeec
5c7719d Revert "Update popen_fork.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/5c7719d7bd10042be562b6e2c8d8d6f6b226baa7
24b53f1 Revert "Update popen_spawn_win32.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/24b53f1421d9a81e8fa5ef0a29c150bcb6161c98
04eac3c Revert "Update managers.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/04eac3ce5dcf50f3ec24272fad64afa91dbb4353
9638a36 Revert "Update popen_spawn_win32.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/9638a367f59fcd5ba5b6fc44d62b10f6b15313a4
242d027 Revert "Update popen_forkserver.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/242d0270e19d5e01493ad67cb4d64f142c8b9c45
dbbbe1b Revert "Update popen_fork.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/dbbbe1b0dd80c5a74b51627d1a5db629623967cc
88056fe Revert "Update popen_spawn_posix.py" geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/88056fe4676e0504ebb4a170426f88657de4cbbb
f055d11 Use a simpler implementation of serialisability based on __getstate__… geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/f055d118f24089513c4f0ca700ab6c45674d7287
3c6f5da Restore finalizer attribute names geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/3c6f5dabe14a2bd320d9a8e2fd672bc0724bb2b4
fe89f2d Move __getstate__/__setstate__ to the right Popen classes geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/fe89f2daf7ab99aa26f0fafe1472ebecca2ceda2
c2ab61e Remove an empty line introduced by mistake in the last commit geryogam Nov 30, 2022 https://github.com/python/cpython/pull/31701/commits/c2ab61e80c26bf86fb801e50e38cc115d17997d3
Clear filters https://github.com/python/cpython/pull/31701/files
Please reload this pagehttps://github.com/python/cpython/pull/31701/files
Please reload this pagehttps://github.com/python/cpython/pull/31701/files
managers.py https://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
popen_fork.py https://github.com/python/cpython/pull/31701/files#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
popen_spawn_win32.py https://github.com/python/cpython/pull/31701/files#diff-5da4b9804b675cab86b1a1fc6009ce993001a750b75d852501cac25b9ef2c9ff
_test_multiprocessing.py https://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
2022-11-30-11-25-08.bpo-46934.zk8HaW.rst https://github.com/python/cpython/pull/31701/files#diff-fc8ead322aea20bba85ff3905d329bce4c4134cd95227dc9db64f59ffb7ebcb4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L519
Lib/multiprocessing/managers.pyhttps://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
View file https://github.com/python/cpython/blob/c2ab61e80c26bf86fb801e50e38cc115d17997d3/Lib/multiprocessing/managers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31701/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
https://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
https://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
https://github.com/python/cpython/pull/31701/files#diff-9e59d8c837ebf181d34af715ac88bb8a4b6141ec18b703cef2c3c8136391abf7
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L519
Lib/multiprocessing/popen_fork.pyhttps://github.com/python/cpython/pull/31701/files#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
View file https://github.com/python/cpython/blob/c2ab61e80c26bf86fb801e50e38cc115d17997d3/Lib/multiprocessing/popen_fork.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31701/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31701/files#diff-987f24caa2ffbe521a904960fa8d359de6562cc519ed58a4f0521e80d06a35d2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L519
Lib/multiprocessing/popen_spawn_win32.pyhttps://github.com/python/cpython/pull/31701/files#diff-5da4b9804b675cab86b1a1fc6009ce993001a750b75d852501cac25b9ef2c9ff
View file https://github.com/python/cpython/blob/c2ab61e80c26bf86fb801e50e38cc115d17997d3/Lib/multiprocessing/popen_spawn_win32.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31701/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31701/files#diff-5da4b9804b675cab86b1a1fc6009ce993001a750b75d852501cac25b9ef2c9ff
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L520
Lib/test/_test_multiprocessing.pyhttps://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
View file https://github.com/python/cpython/blob/c2ab61e80c26bf86fb801e50e38cc115d17997d3/Lib/test/_test_multiprocessing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31701/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
https://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
https://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
https://github.com/python/cpython/pull/31701/files#diff-c3db62f7c1928499afd71830c22c8bb8f56843a4533cecf69137973d73c489fc
Misc/NEWS.d/next/Library/2022-11-30-11-25-08.bpo-46934.zk8HaW.rsthttps://github.com/python/cpython/pull/31701/files#diff-fc8ead322aea20bba85ff3905d329bce4c4134cd95227dc9db64f59ffb7ebcb4
View file https://github.com/python/cpython/blob/c2ab61e80c26bf86fb801e50e38cc115d17997d3/Misc/NEWS.d/next/Library/2022-11-30-11-25-08.bpo-46934.zk8HaW.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31701/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.