René's URL Explorer Experiment


Title: gh-68320, gh-88302 - Allow for `pathlib.Path` subclassing by barneygale · Pull Request #31691 · python/cpython · GitHub

Open Graph Title: gh-68320, gh-88302 - Allow for `pathlib.Path` subclassing by barneygale · Pull Request #31691 · python/cpython

X Title: gh-68320, gh-88302 - Allow for `pathlib.Path` subclassing by barneygale · Pull Request #31691 · python/cpython

Description: Users may wish to define subclasses of pathlib.PurePath and Path to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError...

Open Graph Description: Users may wish to define subclasses of pathlib.PurePath and Path to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError...

X Description: Users may wish to define subclasses of pathlib.PurePath and Path to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError...

Opengraph URL: https://github.com/python/cpython/pull/31691

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e2f6bb1-286a-440d-fcff-f48c3ba2591f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3E6:564B0:13D4645:1BFA65F:6969188E
html-safe-nonceabcb7cfe1eedf4fd80f762e43d7ad13b4e27747e68a8f3da88f1628ed705ae6d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0U2OjU2NEIwOjEzRDQ2NDU6MUJGQTY1Rjo2OTY5MTg4RSIsInZpc2l0b3JfaWQiOiI3ODI1MTc4MjIzMTkwODA4NzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ee29054c7d67b10f74e3931f655501fe57d77390e97c0ad824a149edacdefe6
hovercard-subject-tagpull_request:872134193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/31691/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b70b4d5aa314d0655c4aa37f9bf64d76b6e41b1c67e0495b0faf62d68fb1aee1/python/cpython/pull/31691
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b70b4d5aa314d0655c4aa37f9bf64d76b6e41b1c67e0495b0faf62d68fb1aee1/python/cpython/pull/31691
og:image:altUsers may wish to define subclasses of pathlib.PurePath and Path to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebarneygale
hostnamegithub.com
expected-hostnamegithub.com
None0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd206f7ed6207863172be4a783826e86bd2375c3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31691#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31691
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31691
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31691
Reloadhttps://github.com/python/cpython/pull/31691
Reloadhttps://github.com/python/cpython/pull/31691
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31691
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31691
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/31691#issue-comment-box
brettcannonhttps://github.com/brettcannon
python:mainhttps://github.com/python/cpython/tree/main
barneygale:bpo-44136-remove-pathlib-flavour-2https://github.com/barneygale/cpython/tree/bpo-44136-remove-pathlib-flavour-2
gh-68320, gh-88302 - Allow for pathlib.Path subclassing https://github.com/python/cpython/pull/31691#top
brettcannonhttps://github.com/brettcannon
python:mainhttps://github.com/python/cpython/tree/main
barneygale:bpo-44136-remove-pathlib-flavour-2https://github.com/barneygale/cpython/tree/bpo-44136-remove-pathlib-flavour-2
Conversation 172 https://github.com/python/cpython/pull/31691
Commits 53 https://github.com/python/cpython/pull/31691/commits
Checks 0 https://github.com/python/cpython/pull/31691/checks
Files changed https://github.com/python/cpython/pull/31691/files
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Mar 5, 2022https://github.com/python/cpython/pull/31691#issue-1160192071
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://discuss.python.org/t/make-pathlib-extensible/3428/42https://discuss.python.org/t/make-pathlib-extensible/3428/42
#68320https://github.com/python/cpython/issues/68320
#88302https://github.com/python/cpython/issues/88302
Direct sub-classing of pathlib.Path #68320https://github.com/python/cpython/issues/68320
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
bpo-24132, bpo-44136 - Fix pathlib.Path subclassing.https://github.com/python/cpython/pull/31691/commits/7371220586c8367d80867f340381740347d7aea1
7371220https://github.com/python/cpython/pull/31691/commits/7371220586c8367d80867f340381740347d7aea1
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Mar 5, 2022https://github.com/python/cpython/pull/31691#event-6188591386
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 5, 2022https://github.com/python/cpython/pull/31691#event-6188591392
https://github.com/barneygale
Add testshttps://github.com/python/cpython/pull/31691/commits/8431d1214140a9a1ab02b178bdf84bf083dd2425
8431d12https://github.com/python/cpython/pull/31691/commits/8431d1214140a9a1ab02b178bdf84bf083dd2425
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Mar 5, 2022 https://github.com/python/cpython/pull/31691#ref-pullrequest-1122230489
bpo-24132: Add pathlib._AbstractPath #31085 https://github.com/python/cpython/pull/31085
https://github.com/barneygale
Add tests for PurePath subclasseshttps://github.com/python/cpython/pull/31691/commits/bf2ad3aead98c85b181c5cae2541135e0f110523
bf2ad3ahttps://github.com/python/cpython/pull/31691/commits/bf2ad3aead98c85b181c5cae2541135e0f110523
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 5, 2022 https://github.com/python/cpython/pull/31691#pullrequestreview-900971589
View reviewed changes https://github.com/python/cpython/pull/31691/files/bf2ad3aead98c85b181c5cae2541135e0f110523
Misc/NEWS.d/next/Library/2022-03-05-02-14-09.bpo-24132.W6iORO.rsthttps://github.com/python/cpython/pull/31691/files/bf2ad3aead98c85b181c5cae2541135e0f110523#diff-91c7091668fd4c037e5f8110c32036f50ed3dc2ad4eb6229e06bebafe7fa7c10
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/merwok
merwokhttps://github.com/merwok
Mar 5, 2022 https://github.com/python/cpython/pull/31691#pullrequestreview-900984673
View reviewed changes https://github.com/python/cpython/pull/31691/files/bf2ad3aead98c85b181c5cae2541135e0f110523
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/bf2ad3aead98c85b181c5cae2541135e0f110523#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
barneygalehttps://github.com/barneygale
March 5, 2022 20:17https://github.com/python/cpython/pull/31691#commits-pushed-4036e2e
https://github.com/barneygale
https://github.com/AlexWaygood
Update Misc/NEWS.d/next/Library/2022-03-05-02-14-09.bpo-24132.W6iORO.rsthttps://github.com/python/cpython/pull/31691/commits/4036e2e955cc9720447f7b3700a2b9b755e32cf2
4036e2ehttps://github.com/python/cpython/pull/31691/commits/4036e2e955cc9720447f7b3700a2b9b755e32cf2
https://github.com/barneygale
Rename PurePath._pathmod to PurePath._flavour to reduce the diff.https://github.com/python/cpython/pull/31691/commits/0d08533ca9c4938873ff826ea098cacef0d2374d
0d08533https://github.com/python/cpython/pull/31691/commits/0d08533ca9c4938873ff826ea098cacef0d2374d
https://github.com/barneygale
Merge branch 'bpo-44136-remove-pathlib-flavour-2' of github.com:barne…https://github.com/python/cpython/pull/31691/commits/0ad8022acfc0389e3c976c2e43b364762dc7278b
0ad8022https://github.com/python/cpython/pull/31691/commits/0ad8022acfc0389e3c976c2e43b364762dc7278b
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
March 7, 2022 22:26https://github.com/python/cpython/pull/31691#event-6198399998
barneygalehttps://github.com/barneygale
March 25, 2022 04:39https://github.com/python/cpython/pull/31691#commits-pushed-28992fc
https://github.com/barneygale
Undo an unnecessary change to Path.__new__()https://github.com/python/cpython/pull/31691/commits/28992fc69d90afe67b99ba967ea28250d565af30
28992fchttps://github.com/python/cpython/pull/31691/commits/28992fc69d90afe67b99ba967ea28250d565af30
https://github.com/barneygale
Remove _casefold() and _casefold_parts() methods.https://github.com/python/cpython/pull/31691/commits/dbec2300fe7010282b78a64284b08073d35ec6d4
dbec230https://github.com/python/cpython/pull/31691/commits/dbec2300fe7010282b78a64284b08073d35ec6d4
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 6, 2022https://github.com/python/cpython/pull/31691#issuecomment-1090687101
@brettcannonhttps://github.com/brettcannon
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Apr 7, 2022https://github.com/python/cpython/pull/31691#issuecomment-1092118651
@barneygalehttps://github.com/barneygale
PEP 594https://peps.python.org/pep-0594/
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 15, 2022 https://github.com/python/cpython/pull/31691#ref-issue-1203217586
OSError when try convert URI to pathlib.Path #91504 https://github.com/python/cpython/issues/91504
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 24, 2022https://github.com/python/cpython/pull/31691#event-6485993647
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Apr 27, 2022https://github.com/python/cpython/pull/31691#event-6510454104
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Apr 27, 2022https://github.com/python/cpython/pull/31691#event-6510454269
barneygalehttps://github.com/barneygale
April 29, 2022 17:38https://github.com/python/cpython/pull/31691#commits-pushed-d814ee4
https://github.com/barneygale
Merge branch 'main' into bpo-44136-remove-pathlib-flavour-2https://github.com/python/cpython/pull/31691/commits/d814ee4b4cd01ca15a6e74f5e9262a9abda18cfc
d814ee4https://github.com/python/cpython/pull/31691/commits/d814ee4b4cd01ca15a6e74f5e9262a9abda18cfc
https://github.com/barneygale
Further simplify overall diff by inlining code from compile_pattern()https://github.com/python/cpython/pull/31691/commits/63f1d6834f7087881c3704ae2fa6a2842cdf3815
63f1d68https://github.com/python/cpython/pull/31691/commits/63f1d6834f7087881c3704ae2fa6a2842cdf3815
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 29, 2022https://github.com/python/cpython/pull/31691#event-6526066633
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 29, 2022https://github.com/python/cpython/pull/31691#event-6526066905
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Apr 29, 2022 https://github.com/python/cpython/pull/31691#pullrequestreview-958241511
View reviewed changes https://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815
brettcannonhttps://github.com/brettcannon
https://github.com/python/cpython/pull/31691#pullrequestreview-958241511
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
Lib/pathlib.pyhttps://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 29, 2022https://github.com/python/cpython/pull/31691#event-6526519121
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 29, 2022https://github.com/python/cpython/pull/31691#issuecomment-1113756938
Please reload this pagehttps://github.com/python/cpython/pull/31691
barneygalehttps://github.com/barneygale
April 29, 2022 23:35https://github.com/python/cpython/pull/31691#commits-pushed-8dddfdf
https://github.com/barneygale
https://github.com/brettcannon
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/31691/commits/8dddfdf995791e1cc081078cb73b79f2f35488f9
8dddfdfhttps://github.com/python/cpython/pull/31691/commits/8dddfdf995791e1cc081078cb73b79f2f35488f9
https://github.com/barneygale
Address a couple bits of review feedbackhttps://github.com/python/cpython/pull/31691/commits/b4da721300395af003f1237d071c7e14bfb1925a
b4da721https://github.com/python/cpython/pull/31691/commits/b4da721300395af003f1237d071c7e14bfb1925a
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Dec 23, 2022 https://github.com/python/cpython/pull/31691#pullrequestreview-1229447403
View reviewed changes https://github.com/python/cpython/pull/31691/files/40dc5147b6da2c16d42f817d6eec24b30501e24f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Dec 23, 2022https://github.com/python/cpython/pull/31691#event-8106115163
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
a68e585https://github.com/python/cpython/commit/a68e585c8b7b27323f67905868467ce0588a1dae
Dec 23, 2022https://github.com/python/cpython/pull/31691#event-8106117598
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 23, 2022https://github.com/python/cpython/pull/31691#event-8106117687
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Dec 23, 2022https://github.com/python/cpython/pull/31691#issuecomment-1364372989
@barneygalehttps://github.com/barneygale
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Dec 23, 2022https://github.com/python/cpython/pull/31691#issuecomment-1364411440
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/zmievsa
zmievsahttps://github.com/zmievsa
Dec 24, 2022https://github.com/python/cpython/pull/31691#issuecomment-1364500299
@barneygalehttps://github.com/barneygale
Please reload this pagehttps://github.com/python/cpython/pull/31691
iritkatrielhttps://github.com/iritkatriel
Dec 28, 2022 https://github.com/python/cpython/pull/31691#ref-commit-fdc73cb
https://github.com/gvanrossum
https://github.com/ucodery
https://github.com/carltongibson
https://github.com/hugovk
https://github.com/jonburdo
https://github.com/slateny
https://github.com/JelleZijlstra
https://github.com/graingert
https://github.com/tbwolfe
https://github.com/rkojedzinszky
https://github.com/fnesveda
https://github.com/pablogsal
https://github.com/sobolevn
https://github.com/ambv
https://github.com/sweeneyde
https://github.com/bizzyvinci
https://github.com/CAM-Gerlach
https://github.com/peendebak
https://github.com/hauntsaninja
https://github.com/kumaraditya303
https://github.com/YuriNek0
https://github.com/serhiy-storchaka
https://github.com/shihai1991
https://github.com/amaajemyfren
https://github.com/brandtbucher
https://github.com/jollyroger182
https://github.com/eendebakpt
https://github.com/penguin-wwy
https://github.com/eli-schwartz
https://github.com/itamaro
https://github.com/AlexWaygood
https://github.com/eric-wieser
https://github.com/iritkatriel
https://github.com/byllyfish
https://github.com/encukou
https://github.com/Fidget-Spinner
https://github.com/carljm
https://github.com/FFY00
https://github.com/rhettinger
https://github.com/barneygale
https://github.com/brettcannon
https://github.com/AA-Turner
https://github.com/eryksun
https://github.com/seberg
https://github.com/illia-v
https://github.com/JosephSBoyle
https://github.com/Fraetor
https://github.com/MonadChains
https://github.com/bartbroere
https://github.com/glyph
https://github.com/Kentzo
https://github.com/yourlefthandman
https://github.com/Jackenmen
Merged main into regmachine branch (https://github.com/iritkatriel/cpython/commit/fdc73cb26a59fd5dc4c6158f9bedfb55aa5c7df6
#50https://github.com/iritkatriel/cpython/pull/50
)https://github.com/iritkatriel/cpython/commit/fdc73cb26a59fd5dc4c6158f9bedfb55aa5c7df6
fdc73cbhttps://github.com/iritkatriel/cpython/commit/fdc73cb26a59fd5dc4c6158f9bedfb55aa5c7df6
CVE-2020-10735https://github.com/advisories/GHSA-6jr7-xr67-mgxw
python#100306https://github.com/python/cpython/pull/100306
pythongh-94912https://github.com/python/cpython/issues/94912
python#99247https://github.com/python/cpython/pull/99247
python#100330https://github.com/python/cpython/pull/100330
pythongh-89727https://github.com/python/cpython/issues/89727
python#99803https://github.com/python/cpython/pull/99803
pythongh-69929https://github.com/python/cpython/issues/69929
python#92015https://github.com/python/cpython/pull/92015
pythongh-89051https://github.com/python/cpython/issues/89051
python#93927https://github.com/python/cpython/pull/93927
python#89051https://github.com/python/cpython/issues/89051
pythongh-88211https://github.com/python/cpython/issues/88211
python#99625https://github.com/python/cpython/pull/99625
pythongh-100348https://github.com/python/cpython/issues/100348
python#100349https://github.com/python/cpython/pull/100349
pythongh-99925https://github.com/python/cpython/issues/99925
pythonGH-99926https://github.com/python/cpython/pull/99926
python#99246https://github.com/python/cpython/pull/99246
pythongh-99576https://github.com/python/cpython/issues/99576
pythonGH-99616https://github.com/python/cpython/pull/99616
pythongh-100188https://github.com/python/cpython/issues/100188
python#100189https://github.com/python/cpython/pull/100189
pythongh-99991https://github.com/python/cpython/issues/99991
python#100198https://github.com/python/cpython/pull/100198
pythongh-91081https://github.com/python/cpython/issues/91081
python#91499https://github.com/python/cpython/pull/91499
pythongh-85267https://github.com/python/cpython/issues/85267
python#98796https://github.com/python/cpython/pull/98796
python#83685https://github.com/python/cpython/issues/83685
python#85267https://github.com/python/cpython/issues/85267
python#85267https://github.com/python/cpython/issues/85267
python#68155https://github.com/python/cpython/issues/68155
python#85267https://github.com/python/cpython/issues/85267
pythonGH-100363https://github.com/python/cpython/issues/100363
python#100364https://github.com/python/cpython/pull/100364
pythonGH-100133https://github.com/python/cpython/issues/100133
python#100154https://github.com/python/cpython/pull/100154
pythongh-100374https://github.com/python/cpython/issues/100374
pythongh-100375https://github.com/python/cpython/pull/100375
pythongh-100129https://github.com/python/cpython/issues/100129
pythonGH-100142https://github.com/python/cpython/pull/100142
python#100396https://github.com/python/cpython/pull/100396
pythongh-78878https://github.com/python/cpython/issues/78878
python#14837https://github.com/python/cpython/pull/14837
pythonGH-69564https://github.com/python/cpython/issues/69564
python#20621https://github.com/python/cpython/pull/20621
pythonGH-99554https://github.com/python/cpython/issues/99554
pythonGH-99556https://github.com/python/cpython/pull/99556
python#100423https://github.com/python/cpython/pull/100423
pythongh-99761https://github.com/python/cpython/issues/99761
python#100064https://github.com/python/cpython/pull/100064
pythonGH-99770https://github.com/python/cpython/issues/99770
pythonGH-99771https://github.com/python/cpython/pull/99771
pythongh-78997https://github.com/python/cpython/issues/78997
python#100424https://github.com/python/cpython/pull/100424
pythongh-100344https://github.com/python/cpython/issues/100344
python#100345https://github.com/python/cpython/pull/100345
pythonGH-99554https://github.com/python/cpython/issues/99554
pythonGH-100435https://github.com/python/cpython/pull/100435
pythongh-85432https://github.com/python/cpython/issues/85432
python#99993https://github.com/python/cpython/pull/99993
pythongh-57762https://github.com/python/cpython/issues/57762
python#98837https://github.com/python/cpython/pull/98837
pythongh-48496https://github.com/python/cpython/issues/48496
python#93068https://github.com/python/cpython/pull/93068
python#100449https://github.com/python/cpython/pull/100449
pythongh-76963https://github.com/python/cpython/issues/76963
pythonGH-5576https://github.com/python/cpython/pull/5576
pythonGH-100459https://github.com/python/cpython/issues/100459
pythonGH-100460https://github.com/python/cpython/pull/100460
pythongh-99110https://github.com/python/cpython/issues/99110
python#100182https://github.com/python/cpython/pull/100182
pythongh-98712https://github.com/python/cpython/issues/98712
python#98710https://github.com/python/cpython/pull/98710
pythongh-92216https://github.com/python/cpython/issues/92216
pythonGH-99979https://github.com/python/cpython/pull/99979
pythongh-100288https://github.com/python/cpython/issues/100288
pythonGH-100289https://github.com/python/cpython/pull/100289
pythongh-100288https://github.com/python/cpython/issues/100288
pythonGH-100289https://github.com/python/cpython/pull/100289
python#100468https://github.com/python/cpython/pull/100468
c3c7848https://github.com/iritkatriel/cpython/commit/c3c7848a48b74a321632202e4bdcf2f465fb1cc6
pythongh-94155https://github.com/python/cpython/issues/94155
python#100183https://github.com/python/cpython/pull/100183
pythongh-83076https://github.com/python/cpython/issues/83076
python#100252https://github.com/python/cpython/pull/100252
pythongh-99482https://github.com/python/cpython/issues/99482
python#99484https://github.com/python/cpython/pull/99484
python#19883https://github.com/python/cpython/pull/19883
pythonGH-100425https://github.com/python/cpython/issues/100425
pythonGH-100426https://github.com/python/cpython/pull/100426
pythongh-68320https://github.com/python/cpython/issues/68320
pythongh-88302https://github.com/python/cpython/issues/88302
pythonGH-31691https://github.com/python/cpython/pull/31691
pythongh-99947https://github.com/python/cpython/issues/99947
pythonGH-99946https://github.com/python/cpython/pull/99946
pythonGH-100480https://github.com/python/cpython/pull/100480
pythongh-94808https://github.com/python/cpython/issues/94808
python#99472https://github.com/python/cpython/pull/99472
pythongh-100454https://github.com/python/cpython/issues/100454
python#100456https://github.com/python/cpython/pull/100456
pythongh-100268https://github.com/python/cpython/issues/100268
python#100439https://github.com/python/cpython/pull/100439
pythongh-77771https://github.com/python/cpython/issues/77771
python#92716https://github.com/python/cpython/pull/92716
pythonGH-91166https://github.com/python/cpython/issues/91166
python#31871https://github.com/python/cpython/pull/31871
pythonGH-91166https://github.com/python/cpython/issues/91166
python#31871https://github.com/python/cpython/pull/31871
pythonGH-100493https://github.com/python/cpython/pull/100493
pythongh-100357https://github.com/python/cpython/issues/100357
python#100358https://github.com/python/cpython/pull/100358
python#100495https://github.com/python/cpython/pull/100495
pythongh-99908https://github.com/python/cpython/issues/99908
python#100499https://github.com/python/cpython/pull/100499
pythongh-100474https://github.com/python/cpython/issues/100474
pythonGH-100475https://github.com/python/cpython/pull/100475
pythongh-100287https://github.com/python/cpython/issues/100287
python#100496https://github.com/python/cpython/pull/100496
pythongh-99535https://github.com/python/cpython/issues/99535
python#99990https://github.com/python/cpython/pull/99990
pythongh-100428https://github.com/python/cpython/issues/100428
python#100437https://github.com/python/cpython/pull/100437
python#99536https://github.com/python/cpython/pull/99536
pythongh-100472https://github.com/python/cpython/issues/100472
python#100473https://github.com/python/cpython/pull/100473
pythongh-100519https://github.com/python/cpython/issues/100519
python#99588https://github.com/python/cpython/pull/99588
pythongh-99308https://github.com/python/cpython/issues/99308
python#99311https://github.com/python/cpython/pull/99311
pythongh-92446https://github.com/python/cpython/issues/92446
python#94627https://github.com/python/cpython/pull/94627
python#92450https://github.com/python/cpython/pull/92450
python#100525https://github.com/python/cpython/pull/100525
pythongh-100520https://github.com/python/cpython/issues/100520
python#100524https://github.com/python/cpython/pull/100524
pythongh-99509https://github.com/python/cpython/issues/99509
python#99511https://github.com/python/cpython/pull/99511
pythongh-94603https://github.com/python/cpython/issues/94603
pythongh-94604https://github.com/python/cpython/pull/94604
python#100551https://github.com/python/cpython/pull/100551
pythongh-100553https://github.com/python/cpython/issues/100553
python#100555https://github.com/python/cpython/pull/100555
pythonGH-98831https://github.com/python/cpython/issues/98831
python#100545https://github.com/python/cpython/pull/100545
https://github.com/browniebroke
browniebrokehttps://github.com/browniebroke
Jan 17, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1535859198
Fake pathlib not working with Python 3.12-dev pytest-dev/pyfakefs#770 https://github.com/pytest-dev/pyfakefs/issues/770
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jan 27, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1558898987
Improve Windows performance of pathlib.Path.is_file and friends #101357 https://github.com/python/cpython/issues/101357
https://github.com/mzipay
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 6, 2023https://github.com/python/cpython/pull/31691#issuecomment-1498639315
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/zmievsa
zmievsahttps://github.com/zmievsa
Apr 6, 2023https://github.com/python/cpython/pull/31691#issuecomment-1498902903
@mzipayhttps://github.com/mzipay
https://mail.python.org/archives/list/python-dev@python.org/message/WG5VOX4R4WS5MHUR5NTF4IL3BKF4UI4Y/https://mail.python.org/archives/list/python-dev@python.org/message/WG5VOX4R4WS5MHUR5NTF4IL3BKF4UI4Y/
https://user-images.githubusercontent.com/17561586/230361572-0aa01b6e-9619-4627-8782-3039ab114d57.png
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/mzipay
mzipayhttps://github.com/mzipay
Apr 6, 2023https://github.com/python/cpython/pull/31691#issuecomment-1499202879
@barneygalehttps://github.com/barneygale
lines 302-317https://github.com/python/cpython/blob/v3.12.0a6/Lib/pathlib.py#L302
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/mzipay
mzipayhttps://github.com/mzipay
Apr 6, 2023https://github.com/python/cpython/pull/31691#issuecomment-1499361674
#85281https://github.com/python/cpython/issues/85281
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 6, 2023https://github.com/python/cpython/pull/31691#issuecomment-1499470933
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 8, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1659587305
Vestigial pathlib 'flavour' tests make assertions about internal method #103379 https://github.com/python/cpython/issues/103379
https://github.com/TeamSpen210
TeamSpen210https://github.com/TeamSpen210
Apr 10, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1660686501
Static tools doesn't see class members (at least for trio.Path) python-trio/trio#2630 https://github.com/python-trio/trio/issues/2630
GH-81079: Add case_sensitive argument to pathlib.Path.glob() #102710 https://github.com/python/cpython/pull/102710
Optimize pathlib.Path.glob() by avoiding repeated calls to os.path.normcase() #104104 https://github.com/python/cpython/issues/104104
barneygalehttps://github.com/barneygale
May 2, 2023 https://github.com/python/cpython/pull/31691#ref-commit-93ad73f
https://github.com/barneygale
pythonGH-104104https://github.com/python/cpython/issues/104104
: Optimizehttps://github.com/barneygale/cpython/commit/93ad73f3a9d396e7e856cfeacaf2bad0e69ccb4a
pathlib.Path.glob()https://github.com/barneygale/cpython/commit/93ad73f3a9d396e7e856cfeacaf2bad0e69ccb4a
by avoiding repeated …https://github.com/barneygale/cpython/commit/93ad73f3a9d396e7e856cfeacaf2bad0e69ccb4a
93ad73fhttps://github.com/barneygale/cpython/commit/93ad73f3a9d396e7e856cfeacaf2bad0e69ccb4a
python#31691https://github.com/python/cpython/pull/31691
https://github.com/barneygale
barneygalehttps://github.com/barneygale
May 2, 2023 https://github.com/python/cpython/pull/31691#ref-pullrequest-1693033549
GH-104104: Optimize pathlib.Path.glob() by avoiding repeated calls to os.path.normcase() #104105 https://github.com/python/cpython/pull/104105
barneygalehttps://github.com/barneygale
May 2, 2023 https://github.com/python/cpython/pull/31691#ref-commit-47770a1
https://github.com/barneygale
GH-104104https://github.com/python/cpython/issues/104104
: Optimizehttps://github.com/python/cpython/commit/47770a1e91d096fd1c689eb0c78b0f9e76b43639
pathlib.Path.glob()https://github.com/python/cpython/commit/47770a1e91d096fd1c689eb0c78b0f9e76b43639
by avoiding repeated calls …https://github.com/python/cpython/commit/47770a1e91d096fd1c689eb0c78b0f9e76b43639
47770a1https://github.com/python/cpython/commit/47770a1e91d096fd1c689eb0c78b0f9e76b43639
GH-104105https://github.com/python/cpython/pull/104105
GH-31691https://github.com/python/cpython/pull/31691
https://github.com/hugovk
hugovkhttps://github.com/hugovk
May 25, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1725294196
pathlib: Where does "self._flavour" comes from? (3.11 to 3.12 migration) #104921 https://github.com/python/cpython/issues/104921
https://github.com/barneygale
barneygalehttps://github.com/barneygale
May 25, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1726527756
pathlib.PureWindowsPath comparison results vary between Windows and Posix #104947 https://github.com/python/cpython/issues/104947
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Jun 23, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1771779163
User subclasses of pathlib.PurePath are os.PathLike #106037 https://github.com/python/cpython/issues/106037
https://github.com/Qonfused
Qonfusedhttps://github.com/Qonfused
Jun 28, 2023 https://github.com/python/cpython/pull/31691#ref-pullrequest-1766227649
Python rewrite Qonfused/OCE-Build#4 https://github.com/Qonfused/OCE-Build/pull/4
https://github.com/woodrowbarlow
woodrowbarlowhttps://github.com/woodrowbarlow
Jul 11, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1799779080
Support pathlib-like API woodrowbarlow/c64os-util#30 https://github.com/woodrowbarlow/c64os-util/issues/30
https://github.com/brot
brothttps://github.com/brot
Sep 4, 2023 https://github.com/python/cpython/pull/31691#ref-issue-1848311837
Python 3.12 - AttributeError: module 'pathlib' has no attribute '_Flavour' devopshq/artifactory#430 https://github.com/devopshq/artifactory/issues/430
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31691
https://github.com/merwok
merwok https://github.com/merwok
https://github.com/python/cpython/pull/31691/files/f73f426d1eb2625722f1e6a8287c2b495ed6f0bc
https://github.com/eryksun
eryksun https://github.com/eryksun
https://github.com/python/cpython/pull/31691/files/3692fdf498fba56e46f21a0e3ac89e0821f79bd8
https://github.com/arhadthedev
arhadthedev https://github.com/arhadthedev
https://github.com/python/cpython/pull/31691/files/63f1d6834f7087881c3704ae2fa6a2842cdf3815
https://github.com/AA-Turner
AA-Turner https://github.com/AA-Turner
https://github.com/python/cpython/pull/31691/files/4d6e4f3ee6d6017a59cfc0ea8a9e27653c28332e
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/31691/files/48b49b624753a9a3f73e225700f81ad21b93b6e4
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/python/cpython/pull/31691/files/40dc5147b6da2c16d42f817d6eec24b30501e24f
https://github.com/gst
gst https://github.com/gst
https://github.com/python/cpython/pull/31691/files/51893c11c5e794f1072acbe57b0ae921a431c33d
topic-pathlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib
Direct sub-classing of pathlib.Path https://github.com/python/cpython/issues/68320
Please reload this pagehttps://github.com/python/cpython/pull/31691
https://github.com/barneygale
https://github.com/brettcannon
https://github.com/bedevere-bot
https://github.com/zmievsa
https://github.com/mzipay
https://github.com/gst
https://github.com/merwok
https://github.com/eryksun
https://github.com/arhadthedev
https://github.com/AA-Turner
https://github.com/AlexWaygood
https://github.com/the-knights-who-say-ni
https://github.com/ezio-melotti
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.