René's URL Explorer Experiment


Title: bpo-46764: Fix wrapping bound method with @classmethod by msullivan · Pull Request #31367 · python/cpython · GitHub

Open Graph Title: bpo-46764: Fix wrapping bound method with @classmethod by msullivan · Pull Request #31367 · python/cpython

X Title: bpo-46764: Fix wrapping bound method with @classmethod by msullivan · Pull Request #31367 · python/cpython

Description: Since #8405, @classmethod now has special case behavior to call its argument's tp_descr_get if it exists. This breaks wrapping a bound method with it, since bound method's have a do-nothing tp_descr_get. Drop that do-nothing tp_descr_get. https://bugs.python.org/issue46764

Open Graph Description: Since #8405, @classmethod now has special case behavior to call its argument's tp_descr_get if it exists. This breaks wrapping a bound method with it, since bound method's have a do-nothing...

X Description: Since #8405, @classmethod now has special case behavior to call its argument's tp_descr_get if it exists. This breaks wrapping a bound method with it, since bound method's have a do...

Opengraph URL: https://github.com/python/cpython/pull/31367

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5167963e-39c1-443d-483b-2023fb78f218
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0CA:20445:1DF75E:27E21E:6A5FEAEC
html-safe-noncea01b252de610733904a8ed76288b1da0a8ab703e6ad7f4b20048a730feee5aab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMENBOjIwNDQ1OjFERjc1RToyN0UyMUU6NkE1RkVBRUMiLCJ2aXNpdG9yX2lkIjoiNDU5NjIzMDU0MTc0MjY5NzE5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd7882b19bb4c2463d1d56359723a04dfb6a4ce3d103177ab6928d187d9420efb
hovercard-subject-tagpull_request:853929805
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/31367/files
twitter:imagehttps://avatars.githubusercontent.com/u/340349?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/340349?s=400&v=4
og:image:altSince #8405, @classmethod now has special case behavior to call its argument's tp_descr_get if it exists. This breaks wrapping a bound method with it, since bound method's have a do-nothing...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneba296ecd3a3521238fe43b3b3b08cc09207ddc21173e16ee656db03803de8e2b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6e50fb37e29e4aa0df6386cb485e58b0e3ca97ab
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31367/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31367%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31367%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31367/files
Reloadhttps://github.com/python/cpython/pull/31367/files
Reloadhttps://github.com/python/cpython/pull/31367/files
Please reload this pagehttps://github.com/python/cpython/pull/31367/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31367/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhettingerhttps://github.com/rhettinger
python:mainhttps://github.com/python/cpython/tree/main
msullivan:fix-issue-46764https://github.com/msullivan/cpython/tree/fix-issue-46764
Conversation 5 https://github.com/python/cpython/pull/31367
Commits 3 https://github.com/python/cpython/pull/31367/commits
Checks 0 https://github.com/python/cpython/pull/31367/checks
Files changed https://github.com/python/cpython/pull/31367/files
Please reload this pagehttps://github.com/python/cpython/pull/31367/files
bpo-46764: Fix wrapping bound method with @classmethod https://github.com/python/cpython/pull/31367/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/31367/files
a2b46ca bpo-46764: Fix wrapping bound method with @classmethod msullivan Feb 16, 2022 https://github.com/python/cpython/pull/31367/commits/a2b46cae10a148a502260a7eb1cb356ab446743c
9581566 📜🤖 Added by blurb_it. blurb-it[bot] Feb 16, 2022 https://github.com/python/cpython/pull/31367/commits/95815660cc27ff9512931e37edb5cecab2f1f005
fcbe203 Merge branch 'main' into fix-issue-46764 JelleZijlstra May 2, 2022 https://github.com/python/cpython/pull/31367/commits/fcbe203d346ce4628fea7648dfa010f505b79653
Clear filters https://github.com/python/cpython/pull/31367/files
Please reload this pagehttps://github.com/python/cpython/pull/31367/files
Please reload this pagehttps://github.com/python/cpython/pull/31367/files
test_decorators.py https://github.com/python/cpython/pull/31367/files#diff-9b0e146d781fe420af084a173b86ca0c980b7ef10c8905a8ff2dbf28305df11b
2022-02-16-03-23-38.bpo-46764.wEY4bS.rst https://github.com/python/cpython/pull/31367/files#diff-70db29aff53d050381ca811224ce2e12f5e98e028da70160deb061e89b2ce90d
classobject.c https://github.com/python/cpython/pull/31367/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
Lib/test/test_decorators.pyhttps://github.com/python/cpython/pull/31367/files#diff-9b0e146d781fe420af084a173b86ca0c980b7ef10c8905a8ff2dbf28305df11b
View file https://github.com/msullivan/cpython/blob/fcbe203d346ce4628fea7648dfa010f505b79653/Lib/test/test_decorators.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31367/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31367/files#diff-9b0e146d781fe420af084a173b86ca0c980b7ef10c8905a8ff2dbf28305df11b
https://github.com/python/cpython/pull/31367/files#diff-9b0e146d781fe420af084a173b86ca0c980b7ef10c8905a8ff2dbf28305df11b
Misc/NEWS.d/next/Core and Builtins/2022-02-16-03-23-38.bpo-46764.wEY4bS.rsthttps://github.com/python/cpython/pull/31367/files#diff-70db29aff53d050381ca811224ce2e12f5e98e028da70160deb061e89b2ce90d
View file https://github.com/msullivan/cpython/blob/fcbe203d346ce4628fea7648dfa010f505b79653/Misc/NEWS.d/next/Core%20and%20Builtins/2022-02-16-03-23-38.bpo-46764.wEY4bS.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31367/{{ revealButtonHref }}
Objects/classobject.chttps://github.com/python/cpython/pull/31367/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
View file https://github.com/msullivan/cpython/blob/fcbe203d346ce4628fea7648dfa010f505b79653/Objects/classobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31367/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31367/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com/python/cpython/pull/31367/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com/python/cpython/pull/31367/files#diff-d36823aa86f63074d7ae49b390602ea3840cabe4b54484c42aab8ea6b04a1479
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.