René's URL Explorer Experiment


Title: bpo-45274: Fix one race condition Thread.join by bensimner · Pull Request #31290 · python/cpython · GitHub

Open Graph Title: bpo-45274: Fix one race condition Thread.join by bensimner · Pull Request #31290 · python/cpython

X Title: bpo-45274: Fix one race condition Thread.join by bensimner · Pull Request #31290 · python/cpython

Description: If the tstate lock acquire() fails, the tstate lock might still be locked, and the thread still running. This change makes sure we check that we acquired the lock, and not just that it is held (by ...

Open Graph Description: If the tstate lock acquire() fails, the tstate lock might still be locked, and the thread still running. This change makes sure we check that we acquired the lock, and not just that it is held (by ...

X Description: If the tstate lock acquire() fails, the tstate lock might still be locked, and the thread still running. This change makes sure we check that we acquired the lock, and not just that it is held (by ...

Opengraph URL: https://github.com/python/cpython/pull/31290

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d3f37abe-44f2-79db-6cd8-3751341aea2a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC606:216B79:1B3A51D:23EB6CF:696B90EB
html-safe-nonced788b759536a50825c8ffff2c7ebaea54efef7caf4396faa0b8b6296362b4bae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjA2OjIxNkI3OToxQjNBNTFEOjIzRUI2Q0Y6Njk2QjkwRUIiLCJ2aXNpdG9yX2lkIjoiMjY3NDA3MTgzNDUzNjQxNTQ2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59472137c72774e27a8051a3b272bb9dd090b256584f0c9fe036a9beefc98341
hovercard-subject-tagpull_request:848304676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/31290/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e336d63ca80ea3e9f19f881cf0aef84ff745e84684406cb03cccdf56aeb6ddc/python/cpython/pull/31290
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e336d63ca80ea3e9f19f881cf0aef84ff745e84684406cb03cccdf56aeb6ddc/python/cpython/pull/31290
og:image:altIf the tstate lock acquire() fails, the tstate lock might still be locked, and the thread still running. This change makes sure we check that we acquired the lock, and not just that it is held (by ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebensimner
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31290#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31290
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31290
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31290
Reloadhttps://github.com/python/cpython/pull/31290
Reloadhttps://github.com/python/cpython/pull/31290
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31290
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31290
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/31290#issue-comment-box
bensimnerhttps://github.com/bensimner
python:mainhttps://github.com/python/cpython/tree/main
bensimner:threading_joinhttps://github.com/bensimner/cpython/tree/threading_join
bpo-45274: Fix one race condition Thread.join https://github.com/python/cpython/pull/31290#top
bensimnerhttps://github.com/bensimner
python:mainhttps://github.com/python/cpython/tree/main
bensimner:threading_joinhttps://github.com/bensimner/cpython/tree/threading_join
Conversation 2 https://github.com/python/cpython/pull/31290
Commits 1 https://github.com/python/cpython/pull/31290/commits
Checks 0 https://github.com/python/cpython/pull/31290/checks
Files changed https://github.com/python/cpython/pull/31290/files
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/bensimner
bensimnerhttps://github.com/bensimner
Feb 12, 2022https://github.com/python/cpython/pull/31290#issue-1133339620
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://bugs.python.org/issue45274https://bugs.python.org/issue45274
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://github.com/bensimner
Fix one race condition Thread.joinhttps://github.com/python/cpython/pull/31290/commits/aa608dd2a4cc7a6e95448d0f101fd7f978a78b2c
aa608ddhttps://github.com/python/cpython/pull/31290/commits/aa608dd2a4cc7a6e95448d0f101fd7f978a78b2c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 12, 2022https://github.com/python/cpython/pull/31290#event-6054913072
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Feb 12, 2022https://github.com/python/cpython/pull/31290#event-6054913105
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Apr 11, 2022https://github.com/python/cpython/pull/31290#issuecomment-1095661097
https://bugs.python.org/issue45274https://bugs.python.org/issue45274
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://github.com/bensimner
bensimnerhttps://github.com/bensimner
Apr 11, 2022https://github.com/python/cpython/pull/31290#event-6412953477
https://github.com/bensimner
bensimnerhttps://github.com/bensimner
Apr 11, 2022https://github.com/python/cpython/pull/31290#issuecomment-1095671684
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://bugs.python.org/issue46726https://bugs.python.org/issue46726
Please reload this pagehttps://github.com/python/cpython/pull/31290
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31290
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/31290
https://github.com/bensimner
https://github.com/iritkatriel
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.