René's URL Explorer Experiment

Title: bpo-46752: Introduce task groups in asyncio by gvanrossum · Pull Request #31270 · python/cpython · GitHub

Open Graph Title: bpo-46752: Introduce task groups in asyncio by gvanrossum · Pull Request #31270 · python/cpython

X Title: bpo-46752: Introduce task groups in asyncio by gvanrossum · Pull Request #31270 · python/cpython

Description: This is EdgeDB's TaskGroup class, adapted for Python 3.11. In the individual commits you can see how I evolved this from the version in EdgeDB. Here's a to-do list: Figure out why in test_taskgroup_14 I get a nested ExceptionGroup, while the original got a flat MultiError. Fix the test framework's complaint about the event loop policy being changed. Design question: Do we need TaskGroupError? Implementing it correctly is awkward. We could just raise BaseExceptionGroup. If we decide to keep it, we need to fix it to do the hack where it inherits from BaseException iff at least one of the exceptions does. We also need to override derive(). Add tests for handling BaseException, KeyboardInterrupt and SystemExit. Make test_taskgroup_21 work? (It wasn't working in EdgeDB either, so it was crudely disabled.) Add a public API to tasks.py to replace __cancel_requested__, and get rid of the monkey-patching. Design question: Should we allow creating new tasks while __aexit__() is already waiting? Add a test showing the need for the .uncancel() call in __aexit__() (currently on line 97). Dropping that line does not cause any tests to fail. Ensure the taskgroup tests are run with the C and Python Task implementations. Rename tests to have meaningful names. I have a few ideas for minor cleanups that I will do later. What should we do with the copyright header? @1st1. Create a bpo issue. Add a NEWS blurb. Documentation and What's New entry (in a separate PR, probably). I also learned a few things about the ergonomics of ExceptionGroup: The BaseException hacks are clever but awkward to replicate in a subclass. The str() of an EG is rather sparse (Yury's version adds the number of sub-exceptions and their types). Yury's version also has a convenience method that returns the set of sub-exception types. Unsure about the nesting issue (see above). CC: @iritkatriel, @1st1 Co-authored-by: Yury Selivanov yury@edgedb.com Co-authored-by: Andrew Svetlov andrew.svetlov@gmail.com https://bugs.python.org/issue46752

Open Graph Description: This is EdgeDB's TaskGroup class, adapted for Python 3.11. In the individual commits you can see how I evolved this from the version in EdgeDB. Here's a to-do list: Figure out why in test...

X Description: This is EdgeDB's TaskGroup class, adapted for Python 3.11. In the individual commits you can see how I evolved this from the version in EdgeDB. Here's a to-do list: Figure out why...

Opengraph URL: https://github.com/python/cpython/pull/31270

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width