René's URL Explorer Experiment


Title: bpo-46615: Don't crash when set operations mutate the sets by sweeneyde · Pull Request #31120 · python/cpython · GitHub

Open Graph Title: bpo-46615: Don't crash when set operations mutate the sets by sweeneyde · Pull Request #31120 · python/cpython

X Title: bpo-46615: Don't crash when set operations mutate the sets by sweeneyde · Pull Request #31120 · python/cpython

Description: Users of set_next should call Py_INCREF on the resulting set keys to avoid use-after-free. https://bugs.python.org/issue46615

Open Graph Description: Users of set_next should call Py_INCREF on the resulting set keys to avoid use-after-free. https://bugs.python.org/issue46615

X Description: Users of set_next should call Py_INCREF on the resulting set keys to avoid use-after-free. https://bugs.python.org/issue46615

Opengraph URL: https://github.com/python/cpython/pull/31120

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1036f0b4-4832-bf2f-a295-531de741bdaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC960:22F528:320FF1:46D4E3:696A1DF8
html-safe-nonce961c000179614236de75d8e2108ab35fb3601d55296587a36b9e3a0d745bc7b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTYwOjIyRjUyODozMjBGRjE6NDZENEUzOjY5NkExREY4IiwidmlzaXRvcl9pZCI6IjYwMzE1NDk5OTg2MzEwOTk4OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae5f2ec0aaa1647f20880f46a8041f69bf89ec037ce56f964ba567888b68cf07
hovercard-subject-tagpull_request:839908918
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/31120/files
twitter:imagehttps://avatars.githubusercontent.com/u/36520290?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/36520290?s=400&v=4
og:image:altUsers of set_next should call Py_INCREF on the resulting set keys to avoid use-after-free. https://bugs.python.org/issue46615
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31120/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31120%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31120%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31120/files
Reloadhttps://github.com/python/cpython/pull/31120/files
Reloadhttps://github.com/python/cpython/pull/31120/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sweeneydehttps://github.com/sweeneyde
python:mainhttps://github.com/python/cpython/tree/main
sweeneyde:set_crashershttps://github.com/sweeneyde/cpython/tree/set_crashers
Conversation 25 https://github.com/python/cpython/pull/31120
Commits 12 https://github.com/python/cpython/pull/31120/commits
Checks 0 https://github.com/python/cpython/pull/31120/checks
Files changed https://github.com/python/cpython/pull/31120/files
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
bpo-46615: Don't crash when set operations mutate the sets https://github.com/python/cpython/pull/31120/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/31120/files
8f858b0 Don't crash when set operations mutate the sets sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/8f858b0b87ab61e0c25c9e9b2dbdc8866e14eda6
ba679c2 📜🤖 Added by blurb_it. blurb-it[bot] Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/ba679c2d915bfde722b6c87d8941bce4d2b5239b
780bca9 make new test, don't repeat ops on empty sets sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/780bca95b66fc8900f0fb8dc3fe0db777b55cf67
16e990d Paramerize tests by type sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/16e990dfdf64dc9386a1757b15a11df9b7131bae
0f42bb8 test xor as well sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/0f42bb89744ba204ac9ff9284edaa3f003942668
c83c426 Catch RuntimeError explicitly. Only test methods that are actually pr… sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/c83c426dfc259d674d795afff2bfd9d2aedfc9f2
a8951b0 More consistent naming of TestCase classes sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/a8951b0616a048fbc63e2bdfffa9b7b25135d5cc
44e40c2 Factor out a common DECREF sweeneyde Feb 4, 2022 https://github.com/python/cpython/pull/31120/commits/44e40c2900dc18f972c92a631b88d6e73a00a5ed
b4091fd Factor out another common DECREF sweeneyde Feb 6, 2022 https://github.com/python/cpython/pull/31120/commits/b4091fdee0437e6e9c434be5a571f0b2e36fd827
0858513 Update Objects/setobject.c sweeneyde Feb 11, 2022 https://github.com/python/cpython/pull/31120/commits/0858513c7e9e72304b39677e660f9a3e8423ce39
2ab5f4e Re-use key variable sweeneyde Feb 11, 2022 https://github.com/python/cpython/pull/31120/commits/2ab5f4ecf084ba6f0d2daef1df1a02a170e69e5b
c16cba3 newline in NEWS entry sweeneyde Feb 11, 2022 https://github.com/python/cpython/pull/31120/commits/c16cba3da24a2f59512429d6a44b5a19f23d111c
Clear filters https://github.com/python/cpython/pull/31120/files
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
test_set.py https://github.com/python/cpython/pull/31120/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
2022-02-04-04-33-18.bpo-46615.puArY9.rst https://github.com/python/cpython/pull/31120/files#diff-00620ecb9e3ccabc027333ecaa15e9196837f591042e20d0b127388651498ef7
setobject.c https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Lib/test/test_set.pyhttps://github.com/python/cpython/pull/31120/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
View file https://github.com/sweeneyde/cpython/blob/c16cba3da24a2f59512429d6a44b5a19f23d111c/Lib/test/test_set.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31120/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31120/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
JelleZijlstrahttps://github.com/JelleZijlstra
Feb 11, 2022https://github.com/python/cpython/pull/31120/files#r804309023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
sweeneydehttps://github.com/sweeneyde
Feb 11, 2022https://github.com/python/cpython/pull/31120/files#r804319455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
https://github.com/python/cpython/pull/31120/files#diff-16129e9911d8b23ed7e37808ea9891475f6e3cc94c2bd5ff22602dc0cba336da
Misc/NEWS.d/next/Core and Builtins/2022-02-04-04-33-18.bpo-46615.puArY9.rsthttps://github.com/python/cpython/pull/31120/files#diff-00620ecb9e3ccabc027333ecaa15e9196837f591042e20d0b127388651498ef7
View file https://github.com/sweeneyde/cpython/blob/c16cba3da24a2f59512429d6a44b5a19f23d111c/Misc/NEWS.d/next/Core%20and%20Builtins/2022-02-04-04-33-18.bpo-46615.puArY9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31120/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L215
Objects/setobject.chttps://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
View file https://github.com/sweeneyde/cpython/blob/c16cba3da24a2f59512429d6a44b5a19f23d111c/Objects/setobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31120/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Please reload this pagehttps://github.com/python/cpython/pull/31120/files
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/31120/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.