René's URL Explorer Experiment


Title: bpo-46329: Fix refleak in specialized `isinstance` error path by Fidget-Spinner · Pull Request #31005 · python/cpython · GitHub

Open Graph Title: bpo-46329: Fix refleak in specialized `isinstance` error path by Fidget-Spinner · Pull Request #31005 · python/cpython

X Title: bpo-46329: Fix refleak in specialized `isinstance` error path by Fidget-Spinner · Pull Request #31005 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Since cls is POP-ed, error doesn't decref it since it decrefs from TOS down. https://bugs.python.org/issue46329

X Description: Since cls is POP-ed, error doesn't decref it since it decrefs from TOS down. https://bugs.python.org/issue46329

Opengraph URL: https://github.com/python/cpython/pull/31005

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e13ae405-340a-0702-53a8-b7e4b11e5e1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF8E:1CCA14:53655:6D770:6A52DAC9
html-safe-nonce1f4ae1516b821ea84c8b8949bede45df09fba5a0d81d379bb55e9420b530de7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjhFOjFDQ0ExNDo1MzY1NTo2RDc3MDo2QTUyREFDOSIsInZpc2l0b3JfaWQiOiI5MDUwMTczODYxNzY5OTYwMTM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac44423af4316d9d3af4e196d1eb6eabf501bea85ef2c43398b28c924bc1bb0c08
hovercard-subject-tagpull_request:835026132
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/31005/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2f9562a707cd42c9db79160febb297cb276c71158aaa75d15e39426ae17e2043/python/cpython/pull/31005
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f9562a707cd42c9db79160febb297cb276c71158aaa75d15e39426ae17e2043/python/cpython/pull/31005
og:image:altSince cls is POP-ed, error doesn't decref it since it decrefs from TOS down. https://bugs.python.org/issue46329
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFidget-Spinner
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31005#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31005
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31005
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31005
Reloadhttps://github.com/python/cpython/pull/31005
Reloadhttps://github.com/python/cpython/pull/31005
Please reload this pagehttps://github.com/python/cpython/pull/31005
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31005
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:fix_isinstance_refleakhttps://github.com/Fidget-Spinner/cpython/tree/fix_isinstance_refleak
Conversationhttps://github.com/python/cpython/pull/31005
Commits1 (1)https://github.com/python/cpython/pull/31005/commits
Checkshttps://github.com/python/cpython/pull/31005/checks
Files changedhttps://github.com/python/cpython/pull/31005/files
bpo-46329: Fix refleak in specialized isinstance error pathhttps://github.com/python/cpython/pull/31005#top
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
Fidget-Spinner:fix_isinstance_refleakhttps://github.com/Fidget-Spinner/cpython/tree/fix_isinstance_refleak
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Jan 29, 2022https://github.com/python/cpython/pull/31005#issue-1118095557
Please reload this pagehttps://github.com/python/cpython/pull/31005
https://bugs.python.org/issue46329https://bugs.python.org/issue46329
Please reload this pagehttps://github.com/python/cpython/pull/31005
https://github.com/Fidget-Spinner
fix refleak in isinstance error pathhttps://github.com/python/cpython/pull/31005/commits/e420d032d334192ace884ee60310afd862af1cd2
e420d03https://github.com/python/cpython/pull/31005/commits/e420d032d334192ace884ee60310afd862af1cd2
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/8b1b27f1939cc4060531d198fdb09242f247ca7c/.github/CODEOWNERS#L20
January 29, 2022 07:25https://github.com/python/cpython/pull/31005#event-5974622440
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5974622463
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5974622469
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5974622974
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Jan 29, 2022https://github.com/python/cpython/pull/31005#issuecomment-1024856248
@pablogsalhttps://github.com/pablogsal
GH-30855https://github.com/python/cpython/pull/30855
Please reload this pagehttps://github.com/python/cpython/pull/31005
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 29, 2022 https://github.com/python/cpython/pull/31005#pullrequestreview-866892884
View reviewed changes https://github.com/python/cpython/pull/31005/files/e420d032d334192ace884ee60310afd862af1cd2
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5974645600
https://github.com/markshannon
markshannonhttps://github.com/markshannon
Jan 29, 2022https://github.com/python/cpython/pull/31005#issuecomment-1024881754
@pablogsalhttps://github.com/pablogsal
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/31005
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
8fb3649https://github.com/python/cpython/commit/8fb36494501aad5b0c1d34311c9743c60bb9926c
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5975147628
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 29, 2022https://github.com/python/cpython/pull/31005#event-5975147665
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
January 29, 2022 14:38https://github.com/python/cpython/pull/31005#event-5975151968
pablogsalhttps://github.com/pablogsal
Jan 29, 2022 https://github.com/python/cpython/pull/31005#ref-commit-d8e8cbc
https://github.com/pablogsal
Revert "fFx refleak in isinstance error path (https://github.com/python/cpython/commit/d8e8cbcfa2dbf1e0eaf0a338d69f62a83f7e7b5e
GH-31005https://github.com/python/cpython/pull/31005
)"https://github.com/python/cpython/commit/d8e8cbcfa2dbf1e0eaf0a338d69f62a83f7e7b5e
d8e8cbchttps://github.com/python/cpython/commit/d8e8cbcfa2dbf1e0eaf0a338d69f62a83f7e7b5e
8fb3649https://github.com/python/cpython/commit/8fb36494501aad5b0c1d34311c9743c60bb9926c
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jan 29, 2022 https://github.com/python/cpython/pull/31005#ref-pullrequest-1118287032
Revert "bpo-46329: Split calls into precall and call instructions." #31011 https://github.com/python/cpython/pull/31011
ambvhttps://github.com/ambv
Jan 31, 2022 https://github.com/python/cpython/pull/31005#ref-commit-ada2b00
https://github.com/pablogsal
https://github.com/ambv
Revert "fFx refleak in isinstance error path (https://github.com/python/cpython/commit/ada2b00c7c5ba8396659905218a0e07f2f744585
GH-31005https://github.com/python/cpython/pull/31005
)"https://github.com/python/cpython/commit/ada2b00c7c5ba8396659905218a0e07f2f744585
ada2b00https://github.com/python/cpython/commit/ada2b00c7c5ba8396659905218a0e07f2f744585
8fb3649https://github.com/python/cpython/commit/8fb36494501aad5b0c1d34311c9743c60bb9926c
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31005
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
https://github.com/python/cpython/pull/31005/files/e420d032d334192ace884ee60310afd862af1cd2
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/31005
https://github.com/Fidget-Spinner
https://github.com/markshannon
https://github.com/brandtbucher
https://github.com/pablogsal
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.