René's URL Explorer Experiment


Title: bpo-10746: ctypes: Fix PEP 3118 type codes for c_long, c_bool, c_int by pv · Pull Request #31 · python/cpython · GitHub

Open Graph Title: bpo-10746: ctypes: Fix PEP 3118 type codes for c_long, c_bool, c_int by pv · Pull Request #31 · python/cpython

X Title: bpo-10746: ctypes: Fix PEP 3118 type codes for c_long, c_bool, c_int by pv · Pull Request #31 · python/cpython

Description: Ctypes currently produces wrong pep3118 type codes for several types. E.g. memoryview(ctypes.c_long()).format gives "' endian specification in the struct syntax also turns on the "standard size" mode, which makes type characters have a platform-independent meaning, which does not match with the codes used internally in ctypes. The struct module format syntax also does not allow specifying native-size non-native-endian items. This commit adds a converter function that maps the internal ctypes codes to appropriate struct module standard-size codes in the pep3118 format strings. The tests are modified to check for this. Example of the current problem in practice: >>> import numpy, ctypes >>> numpy.asarray(memoryview(ctypes.c_long(42))) /usr/lib64/python3.5/site-packages/numpy/core/numeric.py:482: RuntimeWarning: Item size computed from the PEP 3118 buffer format string does not match the actual item size. return array(a, dtype, copy=False, order=order) Traceback (most recent call last): File "", line 1, in File "/usr/lib64/python3.5/site-packages/numpy/core/numeric.py", line 482, in asarray return array(a, dtype, copy=False, order=order) ValueError: setting an array element with a sequence. struct format string syntax bpo-10746 https://bugs.python.org/issue10746

Open Graph Description: Ctypes currently produces wrong pep3118 type codes for several types. E.g. memoryview(ctypes.c_long()).format gives "<l" on 64-bit platforms, but it should be "<q" instead...

X Description: Ctypes currently produces wrong pep3118 type codes for several types. E.g. memoryview(ctypes.c_long()).format gives &quot;&lt;l&quot; on 64-bit platforms, but it should be &quot;&am...

Opengraph URL: https://github.com/python/cpython/pull/31

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:01e8bb7f-f731-a479-7715-137e351b65cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB74A:1ED5B9:118B2D:1790C8:6969C7F9
html-safe-noncec578865a4cad3c60ab2b11844d454f14a80ce7473849c53016195499bd101707
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzRBOjFFRDVCOToxMThCMkQ6MTc5MEM4OjY5NjlDN0Y5IiwidmlzaXRvcl9pZCI6IjQ2NDkzNzIyMDk0NzE2NzIyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8229186fbe38b6d7f9d406f425a9f710cab62d71ebbb1f67632d6a776c39d102
hovercard-subject-tagpull_request:105764856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/31/files
twitter:imagehttps://avatars.githubusercontent.com/u/35046?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35046?s=400&v=4
og:image:altCtypes currently produces wrong pep3118 type codes for several types. E.g. memoryview(ctypes.c_long()).format gives "<l" on 64-bit platforms, but it should be "<q" instead...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/31/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F31%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/31/files
Reloadhttps://github.com/python/cpython/pull/31/files
Reloadhttps://github.com/python/cpython/pull/31/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/31/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/31/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
pv:bpo-10746https://github.com/pv/cpython/tree/bpo-10746
Conversation 35 https://github.com/python/cpython/pull/31
Commits 1 https://github.com/python/cpython/pull/31/commits
Checks 0 https://github.com/python/cpython/pull/31/checks
Files changed https://github.com/python/cpython/pull/31/files
Please reload this pagehttps://github.com/python/cpython/pull/31/files
bpo-10746: ctypes: Fix PEP 3118 type codes for c_long, c_bool, c_int https://github.com/python/cpython/pull/31/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/31/files
4cb7409 bpo-10746: Fix ctypes PEP 3118 type codes for c_long, c_bool, c_int pv Feb 11, 2017 https://github.com/python/cpython/pull/31/commits/4cb740948ecc6286efbcaac9b1fb1289d28080a4
Clear filters https://github.com/python/cpython/pull/31/files
Please reload this pagehttps://github.com/python/cpython/pull/31/files
Please reload this pagehttps://github.com/python/cpython/pull/31/files
test_pep3118.py https://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
2017-08-28-13-01-05.bpo-10746.nmAvfu.rst https://github.com/python/cpython/pull/31/files#diff-5fdbf341dd3102146044b0c926dab2bd10ebec697db59a8ef96fc358f8272eb0
_ctypes.c https://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
Lib/ctypes/test/test_pep3118.pyhttps://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
View file https://github.com/pv/cpython/blob/4cb740948ecc6286efbcaac9b1fb1289d28080a4/Lib/ctypes/test/test_pep3118.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
https://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
https://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
https://github.com/python/cpython/pull/31/files#diff-88eb89c9eb8c08f34a9ec8529fb144b19e50c03ac8309b149d35ffd10a7d6864
Misc/NEWS.d/next/Library/2017-08-28-13-01-05.bpo-10746.nmAvfu.rsthttps://github.com/python/cpython/pull/31/files#diff-5fdbf341dd3102146044b0c926dab2bd10ebec697db59a8ef96fc358f8272eb0
View file https://github.com/pv/cpython/blob/4cb740948ecc6286efbcaac9b1fb1289d28080a4/Misc/NEWS.d/next/Library/2017-08-28-13-01-05.bpo-10746.nmAvfu.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31/{{ revealButtonHref }}
Modules/_ctypes/_ctypes.chttps://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
View file https://github.com/pv/cpython/blob/4cb740948ecc6286efbcaac9b1fb1289d28080a4/Modules/_ctypes/_ctypes.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/31/{{ revealButtonHref }}
https://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com/python/cpython/pull/31/files#diff-402bc51df93eaaca2e2f2551ec0206d8af190722ae4703c178554b565d7c14b4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.