René's URL Explorer Experiment


Title: bpo-41370: Evaluate strings as forward refs in PEP 585 generics by NiklasRosenstein · Pull Request #30900 · python/cpython · GitHub

Open Graph Title: bpo-41370: Evaluate strings as forward refs in PEP 585 generics by NiklasRosenstein · Pull Request #30900 · python/cpython

X Title: bpo-41370: Evaluate strings as forward refs in PEP 585 generics by NiklasRosenstein · Pull Request #30900 · python/cpython

Description: This Pull Requests suggests a change to typing._eval_type() that considers strings in PEP 585 generics (ie. instances of types.GenericAlias) as forward references. This is necessary because ForwardRef is not and likely will not be implemented in C, and thus strings used as forward references in PEP 585 are not currently evaluated by typing.get_type_hints(). https://bugs.python.org/issue41370 A test case that uses assertIs() currently fails because in the current state _eval_type() creates a copy of the same generic alias with transformed arguments, thus for any PEP 585 generic alias x, the comparison x is typing.get_type_hints(func)['X'] will evaluate to False, assuming func has a field/argument annotation X: x. I think that this can be worked around, and happy to propose an updated implementation. I created this PR as a proof of concept until a there is consent that in spirit this change to get_type_hints() is something that should happen. So for now I'll keep it as it is. ====================================================================== FAIL: test_get_type_hints_annotated (__main__.GetTypeHintTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/niklas/git/cpython/Lib/test/test_typing.py", line 3298, in test_get_type_hints_annotated self.assertIs( ^^^^^^^^^^^^^^ AssertionError: tuple[typing.Annotated[~T, (1, 0)], ...] is not tuple[typing.Annotated[~T, (1, 0)], ...] Open todos/questions Fix test_get_type_hints_annotated in test_typing.py Do we actually need to treat types.GenericAlias separately or is it safe to assume that a string argument is always a forward reference? Backport to 3.10 as a bugfix? Co-Authored-By: Guido van Rossum guido@python.org https://bugs.python.org/issue41370

Open Graph Description: This Pull Requests suggests a change to typing._eval_type() that considers strings in PEP 585 generics (ie. instances of types.GenericAlias) as forward references. This is necessary because Forward...

X Description: This Pull Requests suggests a change to typing._eval_type() that considers strings in PEP 585 generics (ie. instances of types.GenericAlias) as forward references. This is necessary because Forward...

Opengraph URL: https://github.com/python/cpython/pull/30900

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:f7d91799-8fa8-6fe9-81c1-56c76e6dcb5b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id804C:2483D2:4A9B1F8:6385696:69959955
html-safe-noncedcba3563b1494ffaa055d7d063888cbba00df5823fe32c5c55de621d4445b9b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDRDOjI0ODNEMjo0QTlCMUY4OjYzODU2OTY6Njk5NTk5NTUiLCJ2aXNpdG9yX2lkIjoiNDc0MTExOTA5ODc5NjQ4MDg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9c8ff71d7d81e0232b20f09e161c1686a4dc6b7047f111fc76e665fa10d5db11
hovercard-subject-tagpull_request:831927247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
twitter:imagehttps://avatars.githubusercontent.com/u/1318438?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1318438?s=400&v=4
og:image:altThis Pull Requests suggests a change to typing._eval_type() that considers strings in PEP 585 generics (ie. instances of types.GenericAlias) as forward references. This is necessary because Forward...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4bd759bc5f83244e2a0de29b937365905c0fefd238b6f077c24a49830375b4df
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6de0b4814d356b3d1ba4b5c6f757c6d4b967559b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30900%2Fcommits%2F3416713dd4c885c942f342190ca103ade254eb25
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30900%2Fcommits%2F3416713dd4c885c942f342190ca103ade254eb25
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Reloadhttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Reloadhttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.5k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
Conversation 17 https://github.com/python/cpython/pull/30900
Commits 10 https://github.com/python/cpython/pull/30900/commits
Checks 0 https://github.com/python/cpython/pull/30900/checks
Files changed https://github.com/python/cpython/pull/30900/files
Please reload this pagehttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
bpo-41370: Evaluate strings as forward refs in PEP 585 generics https://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25#top
Show all changes 10 commits https://github.com/python/cpython/pull/30900/files
e820e3a convert strings in PEP 585 generic aliases (`types.GenericAlias`) to … NiklasRosenstein Jan 25, 2022 https://github.com/python/cpython/pull/30900/commits/e820e3a776ac25cc5ba371b7f5bed78755eba64f
d7f57c7 add unittest for new get_type_hints() behaviour on PEP 585 generics w… NiklasRosenstein Jan 25, 2022 https://github.com/python/cpython/pull/30900/commits/d7f57c7eb10ce94e9b6d32bbab92277e22420d8b
26ab740 add unit test for `from __future__ import annotations` NiklasRosenstein Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/26ab74013e8274457724eba1a9e83a98a719176d
a04bd5d add test for recursive type NiklasRosenstein Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/a04bd5d8867f71f0ba2497a0ef65f8d8b8833959
3416713 📜🤖 Added by blurb_it. blurb-it[bot] Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
30a3564 Double backticks because RST. NiklasRosenstein Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/30a3564f176bb1b1c0a2931fc78fe25ad9f88710
13a3505 Update Lib/typing.py NiklasRosenstein Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/13a350520b239da22a4e4f5d33da407ba70589f5
33d286a Update Misc/NEWS.d/next/Library/2022-01-27-11-54-16.bpo-41370.gYxCPE.rst NiklasRosenstein Jan 27, 2022 https://github.com/python/cpython/pull/30900/commits/33d286a3728b234dd89485e81da8a1daaa5f00a9
6cd96b1 Merge branch 'main' into issue41370 NiklasRosenstein Feb 22, 2022 https://github.com/python/cpython/pull/30900/commits/6cd96b17663c2b32d4f04a4de92e7deaa91ce2b5
39c5b06 Replace assertIs with assertEqual in test_get_type_hints_annotated NiklasRosenstein Mar 3, 2022 https://github.com/python/cpython/pull/30900/commits/39c5b0641acb8ab55a09712bb5a65075c7e9ccd6
Clear filters https://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Please reload this pagehttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Please reload this pagehttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
Prev https://github.com/python/cpython/pull/30900/commits/a04bd5d8867f71f0ba2497a0ef65f8d8b8833959
Next https://github.com/python/cpython/pull/30900/commits/30a3564f176bb1b1c0a2931fc78fe25ad9f88710
Please reload this pagehttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25
https://github.com/apps/blurb-it
blurb-it[bot]https://github.com/python/cpython/commits?author=blurb-it%5Bbot%5D
Misc/NEWS.d/next/Library/2022-01-27-11-54-16.bpo-41370.gYxCPE.rsthttps://github.com/python/cpython/pull/30900/commits/3416713dd4c885c942f342190ca103ade254eb25#diff-f26c70358c3a485b307d1b2f3bb7bef7065ad3a0a0a33d862c9744d3ec94f1ac
View file https://github.com/python/cpython/blob/3416713dd4c885c942f342190ca103ade254eb25/Misc/NEWS.d/next/Library/2022-01-27-11-54-16.bpo-41370.gYxCPE.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30900/commits/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.