Title: bpo-46523: fix tests rerun when `setUp[Class|Module]` fails by sobolevn · Pull Request #30895 · python/cpython · GitHub
Open Graph Title: bpo-46523: fix tests rerun when `setUp[Class|Module]` fails by sobolevn · Pull Request #30895 · python/cpython
X Title: bpo-46523: fix tests rerun when `setUp[Class|Module]` fails by sobolevn · Pull Request #30895 · python/cpython
Description: Problem There were two problems: Tests were trying to rerun setUpClass as a test name. It is visible here: Re-running test_typing in verbose mode (matching: setUpClass) Rerun was not considered an error even if there were errors. I've fixed both problems. Local testing setUpModule » ./python.exe -m test -w -v test_typing == CPython 3.11.0a4+ (heads/main-dirty:ef3ef6fa43, Jan 20 2022, 20:48:25) [Clang 11.0.0 (clang-1100.0.33.16)] == macOS-10.14.6-x86_64-i386-64bit little-endian == cwd: /Users/sobolev/Desktop/cpython/build/test_python_6745æ == CPU count: 4 == encodings: locale=UTF-8, FS=utf-8 0:00:00 load avg: 9.85 Run tests sequentially 0:00:00 load avg: 9.85 [1/1] test_typing setUpModule (test.test_typing) ... ERROR ====================================================================== ERROR: setUpModule (test.test_typing) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_typing.py", line 43, in setUpModule raise TypeError('mo') ^^^^^^^^^^^^^^^^^^^^^ TypeError: mo ---------------------------------------------------------------------- Ran 0 tests in 0.004s FAILED (errors=1) test test_typing failed test_typing failed (1 error) == Tests result: FAILURE == 1 test failed: test_typing 0:00:00 load avg: 9.85 0:00:00 load avg: 9.85 Re-running failed tests in verbose mode 0:00:00 load avg: 9.85 Re-running test_typing in verbose mode (matching: test_typing) setUpModule (test.test_typing) ... ERROR ====================================================================== ERROR: setUpModule (test.test_typing) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_typing.py", line 43, in setUpModule raise TypeError('mo') ^^^^^^^^^^^^^^^^^^^^^ TypeError: mo ---------------------------------------------------------------------- Ran 0 tests in 0.003s FAILED (errors=1) test test_typing failed 1 test failed again: test_typing == Tests result: FAILURE then FAILURE == 1 test failed: test_typing 1 re-run test: test_typing Total duration: 378 ms Tests result: FAILURE then FAILURE setUpClass https://gist.github.com/sobolevn/adcaf0d470226b8644f70ef81178e028 setUp https://gist.github.com/sobolevn/acf04e0f7ea785e1fa4c45a94f545743 https://bugs.python.org/issue46523
Open Graph Description: Problem There were two problems: Tests were trying to rerun setUpClass as a test name. It is visible here: Re-running test_typing in verbose mode (matching: setUpClass) Rerun was not considered an...
X Description: Problem There were two problems: Tests were trying to rerun setUpClass as a test name. It is visible here: Re-running test_typing in verbose mode (matching: setUpClass) Rerun was not considered an...
Opengraph URL: https://github.com/python/cpython/pull/30895
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f043a202-b75d-0471-ff24-d6ef7ed6a2bb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1A2:2FB293:8B96A7:BEC797:6969E3C9 |
| html-safe-nonce | bb75c4c3759ca56c2e34598918ad0011d7484654ae4ce395bfc77f8f22ec62b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUEyOjJGQjI5Mzo4Qjk2QTc6QkVDNzk3OjY5NjlFM0M5IiwidmlzaXRvcl9pZCI6IjM2ODUwMDAyMjU2ODg3NzM1NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 044ab44050d07b3d941a6168e8b2f205549dfdf3b0066d84ce7be12b9a7a3c8e |
| hovercard-subject-tag | pull_request:831854223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/30895/files |
| twitter:image | https://avatars.githubusercontent.com/u/4660275?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4660275?s=400&v=4 |
| og:image:alt | Problem There were two problems: Tests were trying to rerun setUpClass as a test name. It is visible here: Re-running test_typing in verbose mode (matching: setUpClass) Rerun was not considered an... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width