René's URL Explorer Experiment

Title: bpo-46425: fix direct invocation of `test_importlib` by sobolevn · Pull Request #30682 · python/cpython · GitHub

Open Graph Title: bpo-46425: fix direct invocation of `test_importlib` by sobolevn · Pull Request #30682 · python/cpython

X Title: bpo-46425: fix direct invocation of `test_importlib` by sobolevn · Pull Request #30682 · python/cpython

Description: Multiple tests in test_importlib were not suited to direct invocation. Why? Some tests did miss unittest.main() call Some tests used relative import style, here's how it were: » ./python.exe ./Lib/test/test_importlib/test_open.py Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 4, in from . import data01 ^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package In several places relative imports were used in setUp(). It was also problematic: » ./python.exe ./Lib/test/test_importlib/test_open.py ..................../Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py:71: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__ from . import namespacedata01 EEEEEE............ ====================================================================== ERROR: test_open_binary (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ====================================================================== ERROR: test_open_binary_FileNotFoundError (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ====================================================================== ERROR: test_open_text_FileNotFoundError (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ====================================================================== ERROR: test_open_text_default_encoding (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ====================================================================== ERROR: test_open_text_given_encoding (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ====================================================================== ERROR: test_open_text_with_errors (__main__.OpenDiskNamespaceTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/./Lib/test/test_importlib/test_open.py", line 71, in setUp from . import namespacedata01 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ImportError: attempted relative import with no known parent package ---------------------------------------------------------------------- Ran 38 tests in 0.017s FAILED (errors=6) Now, all test_importlib modules pass the local check 🎉 Size of the PR This PR is quite big. If desireable, I can split it into multiple parts. CC @corona10 as my mentor. https://bugs.python.org/issue46425

Open Graph Description: Multiple tests in test_importlib were not suited to direct invocation. Why? Some tests did miss unittest.main() call Some tests used relative import style, here's how it were: » ./python.exe ...

X Description: Multiple tests in test_importlib were not suited to direct invocation. Why? Some tests did miss unittest.main() call Some tests used relative import style, here's how it were: » ./python....

Opengraph URL: https://github.com/python/cpython/pull/30682

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width