René's URL Explorer Experiment


Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython · GitHub

Open Graph Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

X Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails there's no need to generate an error message in bytes only to have it be turned it into a str later. https://bugs.python.org/issue31178

Open Graph Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...

X Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because th...

Opengraph URL: https://github.com/python/cpython/pull/3066

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:996888e8-b149-de07-9f32-caeb324760f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA08:446DE:6C3A992:989CA32:6A510497
html-safe-nonceca4e28d023a59baaca640e588691e4a3147deb3139362671eb686b3cb045e94b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTA4OjQ0NkRFOjZDM0E5OTI6OTg5Q0EzMjo2QTUxMDQ5NyIsInZpc2l0b3JfaWQiOiIzMjA2NDM3NzU5NjQ5NjQ1NzE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4e1885fe2b3396e251aad32ae41e43a736f7a6b7216dea34ce75f3ccaff7442f
hovercard-subject-tagpull_request:135201315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3066/files
twitter:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
og:image:altThis particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3066/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3066/files
Reloadhttps://github.com/python/cpython/pull/3066/files
Reloadhttps://github.com/python/cpython/pull/3066/files
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:subprocess-errorhttps://github.com/ammaraskar/cpython/tree/subprocess-error
Conversation 55 https://github.com/python/cpython/pull/3066
Commits 9 https://github.com/python/cpython/pull/3066/commits
Checks 0 https://github.com/python/cpython/pull/3066/checks
Files changed https://github.com/python/cpython/pull/3066/files
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
bpo-31178: Avoid concatenating bytes with str in subprocess error https://github.com/python/cpython/pull/3066/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/3066/files
8f8b86a bpo-31178: Avoid concatenating bytes with str in subprocess error ammaraskar Aug 10, 2017 https://github.com/python/cpython/pull/3066/commits/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
c277e29 Do not attempt to decode in exception path ammaraskar Aug 16, 2017 https://github.com/python/cpython/pull/3066/commits/c277e292235de4ec798ef335f692cc2aad1f839a
df3e1d3 Add tests and remove surrogatepass ammaraskar Aug 17, 2017 https://github.com/python/cpython/pull/3066/commits/df3e1d392b71509e205be5535a8be1fa5d582eef
7410ae2 Use repr instead of str in bad path ammaraskar Aug 17, 2017 https://github.com/python/cpython/pull/3066/commits/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
f007582 Add UnicodeError to except in case the junk contains 2 colons ammaraskar Aug 17, 2017 https://github.com/python/cpython/pull/3066/commits/f007582b2c8de3f71c258c8f57f7661860af7b55
f061ff1 Changes for Serhiy's review ammaraskar Aug 17, 2017 https://github.com/python/cpython/pull/3066/commits/f061ff1129cb02bc65fa35918c2bd06ab9163da5
7a36648 Avoid harcoding EISDIR errno ammaraskar Aug 20, 2017 https://github.com/python/cpython/pull/3066/commits/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
2707615 Mock __del__ with a subclass instead of mocking the method ammaraskar Aug 20, 2017 https://github.com/python/cpython/pull/3066/commits/270761590347bf19baecd09bd1d3ad6ea6d236d8
8634c2b Add news entry ammaraskar Sep 5, 2017 https://github.com/python/cpython/pull/3066/commits/8634c2b86da7c8569957e3d0986be5c89a90d232
Clear filters https://github.com/python/cpython/pull/3066/files
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
subprocess.py https://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
test_subprocess.py https://github.com/python/cpython/pull/3066/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
2017-09-05-14-55-28.bpo-31178.JrSFo7.rst https://github.com/python/cpython/pull/3066/files#diff-ba19e197cad818fa97f53229a8479dd7be9d0c231e8a130035cd81e04245980a
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
View file https://github.com/ammaraskar/cpython/blob/8634c2b86da7c8569957e3d0986be5c89a90d232/Lib/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3066/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 16, 2017https://github.com/python/cpython/pull/3066/files#r133401600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017https://github.com/python/cpython/pull/3066/files#r133409173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133659481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133666379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133697117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@serhiy-storchakahttps://github.com/serhiy-storchaka
@ammaraskarhttps://github.com/ammaraskar
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133726909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3066 (comment)https://github.com/python/cpython/pull/3066#discussion_r133686665
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133659966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133667082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133686665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066/files#r133688496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066/files
https://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
View file https://github.com/ammaraskar/cpython/blob/8634c2b86da7c8569957e3d0986be5c89a90d232/Lib/test/test_subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3066/{{ revealButtonHref }}
https://github.com/python/cpython/pull/3066/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
https://github.com/python/cpython/pull/3066/files#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
Misc/NEWS.d/next/Library/2017-09-05-14-55-28.bpo-31178.JrSFo7.rsthttps://github.com/python/cpython/pull/3066/files#diff-ba19e197cad818fa97f53229a8479dd7be9d0c231e8a130035cd81e04245980a
View file https://github.com/ammaraskar/cpython/blob/8634c2b86da7c8569957e3d0986be5c89a90d232/Misc/NEWS.d/next/Library/2017-09-05-14-55-28.bpo-31178.JrSFo7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/3066/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.