René's URL Explorer Experiment


Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython · GitHub

Open Graph Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

X Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...

X Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because th...

Opengraph URL: https://github.com/python/cpython/pull/3066

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:4ecf05b2-8dda-c2d8-6772-8df1ffcd02a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5C4:B97C3:8CD45A2:C493419:6A50781B
html-safe-nonce7eea5eaf552f17c250129d97bc26005cfb5597994b512fd746d61dcf9f2efe91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUM0OkI5N0MzOjhDRDQ1QTI6QzQ5MzQxOTo2QTUwNzgxQiIsInZpc2l0b3JfaWQiOiI2MjUzNTQxNzM5ODkxNTU0MzMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e13c9237f2d3c3f02477f8a22adf9b9baf7e74c8f63f360a9f82cbc86d28de8
hovercard-subject-tagpull_request:135201315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/3066/commits
twitter:imagehttps://opengraph.githubassets.com/2b80f146330797e319940fd4ebf9c4cefb29f071d7fdbde99b0c61e5539dc2f6/python/cpython/pull/3066
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b80f146330797e319940fd4ebf9c4cefb29f071d7fdbde99b0c61e5539dc2f6/python/cpython/pull/3066
og:image:altThis particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameammaraskar
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3066/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3066/commits
Reloadhttps://github.com/python/cpython/pull/3066/commits
Reloadhttps://github.com/python/cpython/pull/3066/commits
Please reload this pagehttps://github.com/python/cpython/pull/3066/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3066/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:subprocess-errorhttps://github.com/ammaraskar/cpython/tree/subprocess-error
Conversationhttps://github.com/python/cpython/pull/3066
Commits9 (9)https://github.com/python/cpython/pull/3066/commits
Checkshttps://github.com/python/cpython/pull/3066/checks
Files changedhttps://github.com/python/cpython/pull/3066/files
bpo-31178: Avoid concatenating bytes with str in subprocess errorhttps://github.com/python/cpython/pull/3066/commits#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:subprocess-errorhttps://github.com/ammaraskar/cpython/tree/subprocess-error
bpo-31178: Avoid concatenating bytes with str in subprocess errorhttps://github.com/python/cpython/pull/3066/commits/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
8f8b86ahttps://github.com/python/cpython/pull/3066/commits/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
https://github.com/python/cpython/tree/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
Do not attempt to decode in exception pathhttps://github.com/python/cpython/pull/3066/commits/c277e292235de4ec798ef335f692cc2aad1f839a
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
c277e29https://github.com/python/cpython/pull/3066/commits/c277e292235de4ec798ef335f692cc2aad1f839a
https://github.com/python/cpython/tree/c277e292235de4ec798ef335f692cc2aad1f839a
Add tests and remove surrogatepasshttps://github.com/python/cpython/pull/3066/commits/df3e1d392b71509e205be5535a8be1fa5d582eef
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
df3e1d3https://github.com/python/cpython/pull/3066/commits/df3e1d392b71509e205be5535a8be1fa5d582eef
https://github.com/python/cpython/tree/df3e1d392b71509e205be5535a8be1fa5d582eef
Use repr instead of str in bad pathhttps://github.com/python/cpython/pull/3066/commits/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
7410ae2https://github.com/python/cpython/pull/3066/commits/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
https://github.com/python/cpython/tree/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
Add UnicodeError to except in case the junk contains 2 colonshttps://github.com/python/cpython/pull/3066/commits/f007582b2c8de3f71c258c8f57f7661860af7b55
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
f007582https://github.com/python/cpython/pull/3066/commits/f007582b2c8de3f71c258c8f57f7661860af7b55
https://github.com/python/cpython/tree/f007582b2c8de3f71c258c8f57f7661860af7b55
Changes for Serhiy's reviewhttps://github.com/python/cpython/pull/3066/commits/f061ff1129cb02bc65fa35918c2bd06ab9163da5
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
f061ff1https://github.com/python/cpython/pull/3066/commits/f061ff1129cb02bc65fa35918c2bd06ab9163da5
https://github.com/python/cpython/tree/f061ff1129cb02bc65fa35918c2bd06ab9163da5
Avoid harcoding EISDIR errnohttps://github.com/python/cpython/pull/3066/commits/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
7a36648https://github.com/python/cpython/pull/3066/commits/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
https://github.com/python/cpython/tree/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
Mock __del__ with a subclass instead of mocking the methodhttps://github.com/python/cpython/pull/3066/commits/270761590347bf19baecd09bd1d3ad6ea6d236d8
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
2707615https://github.com/python/cpython/pull/3066/commits/270761590347bf19baecd09bd1d3ad6ea6d236d8
https://github.com/python/cpython/tree/270761590347bf19baecd09bd1d3ad6ea6d236d8
Add news entryhttps://github.com/python/cpython/pull/3066/commits/8634c2b86da7c8569957e3d0986be5c89a90d232
https://github.com/ammaraskar
ammaraskarhttps://github.com/python/cpython/commits?author=ammaraskar
8634c2bhttps://github.com/python/cpython/pull/3066/commits/8634c2b86da7c8569957e3d0986be5c89a90d232
https://github.com/python/cpython/tree/8634c2b86da7c8569957e3d0986be5c89a90d232
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.