René's URL Explorer Experiment


Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython · GitHub

Open Graph Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

X Title: bpo-31178: Avoid concatenating bytes with str in subprocess error by ammaraskar · Pull Request #3066 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...

X Description: This particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because th...

Opengraph URL: https://github.com/python/cpython/pull/3066

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4c20a0ca-5e39-044c-4a0c-61eb0a0f55e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C1C:512E3:7AF4872:ACEB656:6A505242
html-safe-nonce3c541028ba3ebb9f68508eaa037c96b80104329ea136e64fd4a6b12e3d78250b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzFDOjUxMkUzOjdBRjQ4NzI6QUNFQjY1Njo2QTUwNTI0MiIsInZpc2l0b3JfaWQiOiI3MzM0NjI0MTAxMDg3MDcyODM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d2f14d51d1f00fd0a2841328a339e913c1237ab840905147561fe815eddedea
hovercard-subject-tagpull_request:135201315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/3066/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2b80f146330797e319940fd4ebf9c4cefb29f071d7fdbde99b0c61e5539dc2f6/python/cpython/pull/3066
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b80f146330797e319940fd4ebf9c4cefb29f071d7fdbde99b0c61e5539dc2f6/python/cpython/pull/3066
og:image:altThis particular fix makes most sense in my opinion because a decode is only required if we're dealing with the subprocess output. If we're falling back to a default error because that fails...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameammaraskar
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/3066#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/3066
Reloadhttps://github.com/python/cpython/pull/3066
Reloadhttps://github.com/python/cpython/pull/3066
Please reload this pagehttps://github.com/python/cpython/pull/3066
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/3066
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:subprocess-errorhttps://github.com/ammaraskar/cpython/tree/subprocess-error
Conversationhttps://github.com/python/cpython/pull/3066
Commits9 (9)https://github.com/python/cpython/pull/3066/commits
Checkshttps://github.com/python/cpython/pull/3066/checks
Files changedhttps://github.com/python/cpython/pull/3066/files
bpo-31178: Avoid concatenating bytes with str in subprocess errorhttps://github.com/python/cpython/pull/3066#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:subprocess-errorhttps://github.com/ammaraskar/cpython/tree/subprocess-error
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 10, 2017https://github.com/python/cpython/pull/3066#issue-249448711
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://bugs.python.org/issue31178https://bugs.python.org/issue31178
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/957d0e9b59bd27ca7c473560634d8b5dbe66338c/.github/CODEOWNERS#L31
August 10, 2017 19:17https://github.com/python/cpython/pull/3066#event-1201547857
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 10, 2017https://github.com/python/cpython/pull/3066#event-1201547906
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 10, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-55670690
View reviewed changes https://github.com/python/cpython/pull/3066/files
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132572979
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132575138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
vstinnerhttps://github.com/vstinner
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132584638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132585968
Please reload this pagehttps://github.com/python/cpython/pull/3066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132573199
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132574064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
vstinnerhttps://github.com/vstinner
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132576338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 10, 2017https://github.com/python/cpython/pull/3066#discussion_r132578641
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 11, 2017https://github.com/python/cpython/pull/3066#discussion_r132638592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
gpsheadhttps://github.com/gpshead
Aug 14, 2017https://github.com/python/cpython/pull/3066#discussion_r133080131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133408004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
bpo-31178: Avoid concatenating bytes with str in subprocess errorhttps://github.com/python/cpython/pull/3066/commits/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
8f8b86ahttps://github.com/python/cpython/pull/3066/commits/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
force-pushedhttps://github.com/python/cpython/compare/6c0717ba07424fa406f3150e676732c5d25f627f..8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
6c0717bhttps://github.com/python/cpython/commit/6c0717ba07424fa406f3150e676732c5d25f627f
8f8b86ahttps://github.com/python/cpython/commit/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
Compare https://github.com/python/cpython/compare/6c0717ba07424fa406f3150e676732c5d25f627f..8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
August 10, 2017 21:56https://github.com/python/cpython/pull/3066#event-1201783148
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 11, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-55740646
View reviewed changes https://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3066#pullrequestreview-55740646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 11, 2017https://github.com/python/cpython/pull/3066#discussion_r132638327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 11, 2017https://github.com/python/cpython/pull/3066#discussion_r132671389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
4d07804#diff-cc136486b4a8e112e64b57436a0619ebR1207https://github.com/python/cpython/commit/4d078046605a53e061aedfb2694baade6d3f5483#diff-cc136486b4a8e112e64b57436a0619ebR1207
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 11, 2017https://github.com/python/cpython/pull/3066#discussion_r132671537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 11, 2017https://github.com/python/cpython/pull/3066#discussion_r132638592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 16, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-56575573
View reviewed changes https://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133401600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133409173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133659481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133666379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133697117
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@serhiy-storchakahttps://github.com/serhiy-storchaka
@ammaraskarhttps://github.com/ammaraskar
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133726909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3066 (comment)https://github.com/python/cpython/pull/3066#discussion_r133686665
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133401683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 16, 2017https://github.com/python/cpython/pull/3066#issuecomment-322717411
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Aug 16, 2017https://github.com/python/cpython/pull/3066#event-1207925604
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-56582863
View reviewed changes https://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133408004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 16, 2017https://github.com/python/cpython/pull/3066#discussion_r133409173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 16, 2017https://github.com/python/cpython/pull/3066#issuecomment-322725797
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
August 16, 2017 09:36https://github.com/python/cpython/pull/3066#commits-pushed-c277e29
https://github.com/ammaraskar
Do not attempt to decode in exception pathhttps://github.com/python/cpython/pull/3066/commits/c277e292235de4ec798ef335f692cc2aad1f839a
c277e29https://github.com/python/cpython/pull/3066/commits/c277e292235de4ec798ef335f692cc2aad1f839a
https://github.com/ammaraskar
Add tests and remove surrogatepasshttps://github.com/python/cpython/pull/3066/commits/df3e1d392b71509e205be5535a8be1fa5d582eef
df3e1d3https://github.com/python/cpython/pull/3066/commits/df3e1d392b71509e205be5535a8be1fa5d582eef
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#issuecomment-322972722
59fd1bfhttps://github.com/python/cpython/commit/59fd1bfcc1dc04b346141da6eb15de9c64d5d4ea
https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 17, 2017https://github.com/python/cpython/pull/3066#issuecomment-322972730
Nobody expects the Spanish Inquisition!https://youtu.be/Nf_Y4MbUCLY
@serhiy-storchakahttps://github.com/serhiy-storchaka
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Aug 17, 2017https://github.com/python/cpython/pull/3066#event-1209492419
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 17, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-56864379
View reviewed changes https://github.com/python/cpython/pull/3066/files/df3e1d392b71509e205be5535a8be1fa5d582eef
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/8f8b86a7d8d139a66525b6d29e3dc63acc2d6915#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133659481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/df3e1d392b71509e205be5535a8be1fa5d582eef#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133659966
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133667082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133686665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522https://github.com/python/cpython/blob/master/Modules/_posixsubprocess.c#L522
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133688496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/df3e1d392b71509e205be5535a8be1fa5d582eef#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133660107
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133668478
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ammaraskarhttps://github.com/ammaraskar
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133684220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files/df3e1d392b71509e205be5535a8be1fa5d582eef#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
vstinnerhttps://github.com/vstinner
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133660458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133685455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 17, 2017https://github.com/python/cpython/pull/3066#issuecomment-323013286
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Aug 17, 2017https://github.com/python/cpython/pull/3066#event-1209748447
https://github.com/ammaraskar
Use repr instead of str in bad pathhttps://github.com/python/cpython/pull/3066/commits/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
7410ae2https://github.com/python/cpython/pull/3066/commits/7410ae22c5100afd9cc2f5757f3822e4fe5e3beb
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#issuecomment-323043681
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 17, 2017https://github.com/python/cpython/pull/3066#issuecomment-323043689
Nobody expects the Spanish Inquisition!https://youtu.be/Nf_Y4MbUCLY
@serhiy-storchakahttps://github.com/serhiy-storchaka
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Aug 17, 2017https://github.com/python/cpython/pull/3066#event-1209951004
https://github.com/ammaraskar
Add UnicodeError to except in case the junk contains 2 colonshttps://github.com/python/cpython/pull/3066/commits/f007582b2c8de3f71c258c8f57f7661860af7b55
f007582https://github.com/python/cpython/pull/3066/commits/f007582b2c8de3f71c258c8f57f7661860af7b55
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-56901533
View reviewed changes https://github.com/python/cpython/pull/3066/files/f007582b2c8de3f71c258c8f57f7661860af7b55
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f007582b2c8de3f71c258c8f57f7661860af7b55#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133691941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f007582b2c8de3f71c258c8f57f7661860af7b55#diff-619941af4b328b6abf2dc02c54e774fc17acc1ac4172c14db27d6097cbbff92a
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133693572
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133723926
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133729881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f007582b2c8de3f71c258c8f57f7661860af7b55#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133694586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 17, 2017https://github.com/python/cpython/pull/3066#discussion_r133720059
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
Changes for Serhiy's reviewhttps://github.com/python/cpython/pull/3066/commits/f061ff1129cb02bc65fa35918c2bd06ab9163da5
f061ff1https://github.com/python/cpython/pull/3066/commits/f061ff1129cb02bc65fa35918c2bd06ab9163da5
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 17, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-56945178
View reviewed changes https://github.com/python/cpython/pull/3066/files/f061ff1129cb02bc65fa35918c2bd06ab9163da5
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 19, 2017https://github.com/python/cpython/pull/3066#issuecomment-323531004
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Aug 20, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-57364322
View reviewed changes https://github.com/python/cpython/pull/3066/files/f061ff1129cb02bc65fa35918c2bd06ab9163da5
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f061ff1129cb02bc65fa35918c2bd06ab9163da5#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
gpsheadhttps://github.com/gpshead
Aug 20, 2017https://github.com/python/cpython/pull/3066#discussion_r134106976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f061ff1129cb02bc65fa35918c2bd06ab9163da5#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
gpsheadhttps://github.com/gpshead
Aug 20, 2017https://github.com/python/cpython/pull/3066#discussion_r134106977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
ammaraskarhttps://github.com/ammaraskar
Aug 20, 2017https://github.com/python/cpython/pull/3066#discussion_r134114764
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 20, 2017https://github.com/python/cpython/pull/3066#issuecomment-323566055
you will be put in the comfy chair!https://www.youtube.com/watch?v=Nf_Y4MbUCLY&feature=youtu.be&t=4m7s
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 20, 2017https://github.com/python/cpython/pull/3066#event-1213099138
ammaraskarhttps://github.com/ammaraskar
August 20, 2017 08:53https://github.com/python/cpython/pull/3066#commits-pushed-7a36648
https://github.com/ammaraskar
Avoid harcoding EISDIR errnohttps://github.com/python/cpython/pull/3066/commits/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
7a36648https://github.com/python/cpython/pull/3066/commits/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
https://github.com/ammaraskar
Mock __del__ with a subclass instead of mocking the methodhttps://github.com/python/cpython/pull/3066/commits/270761590347bf19baecd09bd1d3ad6ea6d236d8
2707615https://github.com/python/cpython/pull/3066/commits/270761590347bf19baecd09bd1d3ad6ea6d236d8
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 20, 2017https://github.com/python/cpython/pull/3066#issuecomment-323584256
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Aug 20, 2017https://github.com/python/cpython/pull/3066#event-1213185570
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 20, 2017https://github.com/python/cpython/pull/3066#issuecomment-323584259
Nobody expects the Spanish Inquisition!https://youtu.be/Nf_Y4MbUCLY
@gpsheadhttps://github.com/gpshead
@serhiy-storchakahttps://github.com/serhiy-storchaka
@Haypohttps://github.com/Haypo
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Aug 20, 2017 https://github.com/python/cpython/pull/3066#ref-issue-251487804
Don't re-ping reviewers who have already approved. python/bedevere#54 https://github.com/python/bedevere/issues/54
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 28, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-58879910
View reviewed changes https://github.com/python/cpython/pull/3066/files/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
Lib/test/test_subprocess.pyhttps://github.com/python/cpython/pull/3066/files/f061ff1129cb02bc65fa35918c2bd06ab9163da5..7a36648700aef6f36d4ca0a55b9fd8afa8b77568#diff-5825be1d1a8e2c68a9321c3d4d04980a72bd4354e35e70bd2407e5e28460c782
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 28, 2017https://github.com/python/cpython/pull/3066#discussion_r135466496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Aug 29, 2017https://github.com/python/cpython/pull/3066#issuecomment-325661968
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
Add news entryhttps://github.com/python/cpython/pull/3066/commits/8634c2b86da7c8569957e3d0986be5c89a90d232
8634c2bhttps://github.com/python/cpython/pull/3066/commits/8634c2b86da7c8569957e3d0986be5c89a90d232
https://github.com/ammaraskar
ammaraskarhttps://github.com/ammaraskar
Sep 5, 2017https://github.com/python/cpython/pull/3066#issuecomment-327270250
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 6, 2017https://github.com/python/cpython/pull/3066#event-1236208382
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 6, 2017 https://github.com/python/cpython/pull/3066#pullrequestreview-60814073
View reviewed changes https://github.com/python/cpython/pull/3066/files/8634c2b86da7c8569957e3d0986be5c89a90d232
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Sep 6, 2017https://github.com/python/cpython/pull/3066#event-1236208877
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
vstinnerhttps://github.com/vstinner
stale reviewhttps://github.com/python/cpython/pull/3066#pullrequestreview-56864379
September 6, 2017 06:40https://github.com/python/cpython/pull/3066#event-1236210046
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
3fc499bhttps://github.com/python/cpython/commit/3fc499bca18454b9f432b9b0106cab662bfeb549
Sep 6, 2017https://github.com/python/cpython/pull/3066#event-1236211503
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 6, 2017https://github.com/python/cpython/pull/3066#issuecomment-327390113
@ammaraskarhttps://github.com/ammaraskar
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/3066
gpsheadhttps://github.com/gpshead
Sep 6, 2017 https://github.com/python/cpython/pull/3066#ref-commit-c06d774
https://github.com/ammaraskar
https://github.com/gpshead
[3.6] bpo-31178: Avoid concatenating bytes with str in subprocess err…https://github.com/gpshead/cpython/commit/c06d774c94e59b272cee89ca91b378cae47b4811
c06d774https://github.com/gpshead/cpython/commit/c06d774c94e59b272cee89ca91b378cae47b4811
pythonGH-3066https://github.com/python/cpython/pull/3066
3fc499bhttps://github.com/gpshead/cpython/commit/3fc499bca18454b9f432b9b0106cab662bfeb549
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 6, 2017 https://github.com/python/cpython/pull/3066#ref-pullrequest-255688585
[3.6] bpo-31178: Avoid concatenating bytes with str in subprocess error #3388 https://github.com/python/cpython/pull/3388
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
Sep 6, 2017 https://github.com/python/cpython/pull/3066#ref-issue-255693504
Notify when backport PR could not be created automatically python/miss-islington#8 https://github.com/python/miss-islington/issues/8
gpsheadhttps://github.com/gpshead
Sep 6, 2017 https://github.com/python/cpython/pull/3066#ref-commit-3bad165
https://github.com/gpshead
[3.6]https://github.com/python/cpython/commit/3bad1650a03fdc8cfdd4cce154e1b2c07e3e4fa0
bpo-31178https://bugs.python.org/issue?@action=redirect&bpo=31178
: Avoid concatenating bytes with str in subprocess err…https://github.com/python/cpython/commit/3bad1650a03fdc8cfdd4cce154e1b2c07e3e4fa0
3bad165https://github.com/python/cpython/commit/3bad1650a03fdc8cfdd4cce154e1b2c07e3e4fa0
GH-3066https://github.com/python/cpython/pull/3066
#3388https://github.com/python/cpython/pull/3388
3fc499bhttps://github.com/python/cpython/commit/3fc499bca18454b9f432b9b0106cab662bfeb549
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 6, 2017https://github.com/python/cpython/pull/3066#event-1237611549
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 8, 2017https://github.com/python/cpython/pull/3066#event-1283083031
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F3066
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/3066/files/f007582b2c8de3f71c258c8f57f7661860af7b55
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/3066/files/7a36648700aef6f36d4ca0a55b9fd8afa8b77568
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/3066/files/8634c2b86da7c8569957e3d0986be5c89a90d232
Please reload this pagehttps://github.com/python/cpython/pull/3066
https://github.com/ammaraskar
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com/miss-islington
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/Mariatta
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.