René's URL Explorer Experiment


Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython · GitHub

Open Graph Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython

X Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython

Description: The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from ceval.c to exceptions.c and sets me up to get a notification for PRs touching exceptions and tracebacks. https://bugs.python.org/issue46221 https://bugs.python.org/issue46219

Open Graph Description: The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...

X Description: The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...

Opengraph URL: https://github.com/python/cpython/pull/30289

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61b4dc32-7a16-40cb-6c8a-f074d370713c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3E0:3BC6BD:2CCAE56:3E35809:6A5E9C69
html-safe-nonceb81c3a62960ed727a71e2009cadde2e2c49a2956b7ecb1eb6d4a0a992bd08c1a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0UwOjNCQzZCRDoyQ0NBRTU2OjNFMzU4MDk6NkE1RTlDNjkiLCJ2aXNpdG9yX2lkIjoiNDU4Mjk4OTcxMDUwMTIyMzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2ae578cdc7f1664af8c06b60cd42f278b52d4bf311027a0963f73d9f556264d6
hovercard-subject-tagpull_request:811517076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/30289/files
twitter:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
og:image:altThe functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/30289/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30289%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30289%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30289/files
Reloadhttps://github.com/python/cpython/pull/30289/files
Reloadhttps://github.com/python/cpython/pull/30289/files
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:simplify-except-starhttps://github.com/iritkatriel/cpython/tree/simplify-except-star
Conversation 5 https://github.com/python/cpython/pull/30289
Commits 9 https://github.com/python/cpython/pull/30289/commits
Checks 0 https://github.com/python/cpython/pull/30289/checks
Files changed https://github.com/python/cpython/pull/30289/files
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. https://github.com/python/cpython/pull/30289/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/30289/files
514b036 remove lasti from PREP_RERAISE_STAR. Do not use POP_EXCEPT_AND_RERAIS… iritkatriel Dec 29, 2021 https://github.com/python/cpython/pull/30289/commits/514b036124e853e2e9a67c3ba1bb2ac4aebeaae4
ee9f0f2 moved PREP_RERAISE_STAR helpers from ceval.c to exceptions.c iritkatriel Dec 29, 2021 https://github.com/python/cpython/pull/30289/commits/ee9f0f2106e708515e76f6f3a0d5daaecacf40e7
22c68a7 POP_JUMP_IF_TRUE --> JUMP_IF_TRUE_OR_POP iritkatriel Dec 29, 2021 https://github.com/python/cpython/pull/30289/commits/22c68a77e1f013329227f64dbed8cbf08e25a9e6
1c05b92 📜🤖 Added by blurb_it. blurb-it[bot] Dec 29, 2021 https://github.com/python/cpython/pull/30289/commits/1c05b922d0ce56f6b241d1da5b54f77ae83ca9fe
2a49fe9 do not assume that an exception group is truthy iritkatriel Dec 30, 2021 https://github.com/python/cpython/pull/30289/commits/2a49fe94529792ec02bdbaf2ffe5f39159161a5b
4b39f20 update codeowners iritkatriel Jan 1, 2022 https://github.com/python/cpython/pull/30289/commits/4b39f2050f8f135a411fa1230de715171720152a
bfac878 change bpo iritkatriel Jan 1, 2022 https://github.com/python/cpython/pull/30289/commits/bfac8783409e5f3f8e4a5395002a1504e18287f1
46c8ea9 Revert "📜🤖 Added by blurb_it." iritkatriel Jan 1, 2022 https://github.com/python/cpython/pull/30289/commits/46c8ea9c46b59045c2095d0ef6a6eb75590c9272
3e51647 add news iritkatriel Jan 1, 2022 https://github.com/python/cpython/pull/30289/commits/3e51647c09afe823a2a8894827c0c7275b9c32a8
Clear filters https://github.com/python/cpython/pull/30289/files
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
CODEOWNERS https://github.com/python/cpython/pull/30289/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
dis.rst https://github.com/python/cpython/pull/30289/files#diff-eaa488fc50d23b30ca8b24ab19e9c91c1c941339847af993e908f006eec0653b
pycore_pyerrors.h https://github.com/python/cpython/pull/30289/files#diff-369651c1fa6d49298aa234ee75042525ef4bf3ebe405d275156d96dd5d6f11ca
_bootstrap_external.py https://github.com/python/cpython/pull/30289/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
test_except_star.py https://github.com/python/cpython/pull/30289/files#diff-3623b9ecbbd6819499fedaa0b37013f7b941801923c5f5c73d20ef573208a287
2022-01-01-14-23-57.bpo-46221.7oGp-I.rst https://github.com/python/cpython/pull/30289/files#diff-71facb05d0be5043a3e6104492f30e7a7b996fa7b3947680947a142ec5d4c1ab
exceptions.c https://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
ceval.c https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
compile.c https://github.com/python/cpython/pull/30289/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L66
.github/CODEOWNERShttps://github.com/python/cpython/pull/30289/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/.github/CODEOWNERS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
https://github.com/python/cpython/pull/30289/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
Doc/library/dis.rsthttps://github.com/python/cpython/pull/30289/files#diff-eaa488fc50d23b30ca8b24ab19e9c91c1c941339847af993e908f006eec0653b
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Doc/library/dis.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-eaa488fc50d23b30ca8b24ab19e9c91c1c941339847af993e908f006eec0653b
https://github.com/python/cpython/pull/30289/files#diff-eaa488fc50d23b30ca8b24ab19e9c91c1c941339847af993e908f006eec0653b
Include/internal/pycore_pyerrors.hhttps://github.com/python/cpython/pull/30289/files#diff-369651c1fa6d49298aa234ee75042525ef4bf3ebe405d275156d96dd5d6f11ca
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Include/internal/pycore_pyerrors.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-369651c1fa6d49298aa234ee75042525ef4bf3ebe405d275156d96dd5d6f11ca
https://github.com/python/cpython/pull/30289/files#diff-369651c1fa6d49298aa234ee75042525ef4bf3ebe405d275156d96dd5d6f11ca
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L260
Lib/importlib/_bootstrap_external.pyhttps://github.com/python/cpython/pull/30289/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Lib/importlib/_bootstrap_external.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/pull/30289/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/pull/30289/files#diff-efefe383b3a81d16150c280db0b64eed7569254299418f64cc0d749f8e16f3a4
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L246
Lib/test/test_except_star.pyhttps://github.com/python/cpython/pull/30289/files#diff-3623b9ecbbd6819499fedaa0b37013f7b941801923c5f5c73d20ef573208a287
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Lib/test/test_except_star.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-3623b9ecbbd6819499fedaa0b37013f7b941801923c5f5c73d20ef573208a287
https://github.com/python/cpython/pull/30289/files#diff-3623b9ecbbd6819499fedaa0b37013f7b941801923c5f5c73d20ef573208a287
Misc/NEWS.d/next/Core and Builtins/2022-01-01-14-23-57.bpo-46221.7oGp-I.rsthttps://github.com/python/cpython/pull/30289/files#diff-71facb05d0be5043a3e6104492f30e7a7b996fa7b3947680947a142ec5d4c1ab
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Misc/NEWS.d/next/Core%20and%20Builtins/2022-01-01-14-23-57.bpo-46221.7oGp-I.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L247
Objects/exceptions.chttps://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Objects/exceptions.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/pull/30289/files#diff-96c4ad902cdfac48712fef8fff0d0c78a71eb135fb48264f3ebb67db1013fc94
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L222
Python/ceval.chttps://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
View file https://github.com/iritkatriel/cpython/blob/3e51647c09afe823a2a8894827c0c7275b9c32a8/Python/ceval.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30289/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/30289/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Please reload this pagehttps://github.com/python/cpython/pull/30289/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.