René's URL Explorer Experiment


Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython · GitHub

Open Graph Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython

X Title: bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...

X Description: The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...

Opengraph URL: https://github.com/python/cpython/pull/30289

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4a21af42-a8dd-177f-2ae0-697d835996c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBC2:2B9CDD:423CDB8:57CCF46:6A5D732B
html-safe-nonce86154b3279fbfb1197c247eebe0d9d6a8fc3bd15ddaa3755bb8b175c4fdc0b84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkMyOjJCOUNERDo0MjNDREI4OjU3Q0NGNDY6NkE1RDczMkIiLCJ2aXNpdG9yX2lkIjoiNjc4ODU2NzY0OTkwNjE2MDQyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd7443409df126e6af071d13f0087a840d92aa0b5fc6d865bba22674b68cf5edb
hovercard-subject-tagpull_request:811517076
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/30289/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/72390c14d22be25210dab85444aaa1b08bfad590c52797cedc3c6ec8fe5f3bc8/python/cpython/pull/30289
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/72390c14d22be25210dab85444aaa1b08bfad590c52797cedc3c6ec8fe5f3bc8/python/cpython/pull/30289
og:image:altThe functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change. Otherwise, this just moves code from...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiritkatriel
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/30289#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30289
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30289
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30289
Reloadhttps://github.com/python/cpython/pull/30289
Reloadhttps://github.com/python/cpython/pull/30289
Please reload this pagehttps://github.com/python/cpython/pull/30289
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/30289
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:simplify-except-starhttps://github.com/iritkatriel/cpython/tree/simplify-except-star
Conversationhttps://github.com/python/cpython/pull/30289
Commits9 (9)https://github.com/python/cpython/pull/30289/commits
Checkshttps://github.com/python/cpython/pull/30289/checks
Files changedhttps://github.com/python/cpython/pull/30289/files
bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy.https://github.com/python/cpython/pull/30289#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:simplify-except-starhttps://github.com/iritkatriel/cpython/tree/simplify-except-star
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Dec 29, 2021https://github.com/python/cpython/pull/30289#issue-1090562372
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://bugs.python.org/issue46221https://bugs.python.org/issue46221
https://bugs.python.org/issue46219https://bugs.python.org/issue46219
Please reload this pagehttps://github.com/python/cpython/pull/30289
iritkatrielhttps://github.com/iritkatriel
December 29, 2021 11:59https://github.com/python/cpython/pull/30289#commits-pushed-514b036
https://github.com/iritkatriel
remove lasti from PREP_RERAISE_STAR. Do not use POP_EXCEPT_AND_RERAIS…https://github.com/python/cpython/pull/30289/commits/514b036124e853e2e9a67c3ba1bb2ac4aebeaae4
514b036https://github.com/python/cpython/pull/30289/commits/514b036124e853e2e9a67c3ba1bb2ac4aebeaae4
https://github.com/iritkatriel
moved PREP_RERAISE_STAR helpers from ceval.c to exceptions.chttps://github.com/python/cpython/pull/30289/commits/ee9f0f2106e708515e76f6f3a0d5daaecacf40e7
ee9f0f2https://github.com/python/cpython/pull/30289/commits/ee9f0f2106e708515e76f6f3a0d5daaecacf40e7
https://github.com/iritkatriel
POP_JUMP_IF_TRUE --> JUMP_IF_TRUE_OR_POPhttps://github.com/python/cpython/pull/30289/commits/22c68a77e1f013329227f64dbed8cbf08e25a9e6
22c68a7https://github.com/python/cpython/pull/30289/commits/22c68a77e1f013329227f64dbed8cbf08e25a9e6
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
gvanrossumhttps://github.com/gvanrossum
December 29, 2021 14:37https://github.com/python/cpython/pull/30289#event-5825007347
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/66c47b63a0df3143fe48d6efc1183eecda2a363d/.github/CODEOWNERS#L20
December 29, 2021 14:37https://github.com/python/cpython/pull/30289#event-5825007356
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 29, 2021https://github.com/python/cpython/pull/30289#event-5825007488
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 29, 2021https://github.com/python/cpython/pull/30289#event-5825007598
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Dec 29, 2021 https://github.com/python/cpython/pull/30289#pullrequestreview-841447656
View reviewed changes https://github.com/python/cpython/pull/30289/files/22c68a77e1f013329227f64dbed8cbf08e25a9e6
Python/ceval.chttps://github.com/python/cpython/pull/30289/files/22c68a77e1f013329227f64dbed8cbf08e25a9e6#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/30289/commits/1c05b922d0ce56f6b241d1da5b54f77ae83ca9fe
1c05b92https://github.com/python/cpython/pull/30289/commits/1c05b922d0ce56f6b241d1da5b54f77ae83ca9fe
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
December 30, 2021 11:55https://github.com/python/cpython/pull/30289#event-5827716686
iritkatrielhttps://github.com/iritkatriel
January 1, 2022 10:43https://github.com/python/cpython/pull/30289#commits-pushed-2a49fe9
https://github.com/iritkatriel
do not assume that an exception group is truthyhttps://github.com/python/cpython/pull/30289/commits/2a49fe94529792ec02bdbaf2ffe5f39159161a5b
2a49fe9https://github.com/python/cpython/pull/30289/commits/2a49fe94529792ec02bdbaf2ffe5f39159161a5b
https://github.com/iritkatriel
update codeownershttps://github.com/python/cpython/pull/30289/commits/4b39f2050f8f135a411fa1230de715171720152a
4b39f20https://github.com/python/cpython/pull/30289/commits/4b39f2050f8f135a411fa1230de715171720152a
https://github.com/iritkatriel
change bpohttps://github.com/python/cpython/pull/30289/commits/bfac8783409e5f3f8e4a5395002a1504e18287f1
bfac878https://github.com/python/cpython/pull/30289/commits/bfac8783409e5f3f8e4a5395002a1504e18287f1
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Jan 1, 2022https://github.com/python/cpython/pull/30289#event-5831714688
iritkatrielhttps://github.com/iritkatriel
January 1, 2022 14:22https://github.com/python/cpython/pull/30289#commits-pushed-46c8ea9
https://github.com/iritkatriel
Revert "📜🤖 Added by blurb_it."https://github.com/python/cpython/pull/30289/commits/46c8ea9c46b59045c2095d0ef6a6eb75590c9272
46c8ea9https://github.com/python/cpython/pull/30289/commits/46c8ea9c46b59045c2095d0ef6a6eb75590c9272
1c05b92https://github.com/iritkatriel/cpython/commit/1c05b922d0ce56f6b241d1da5b54f77ae83ca9fe
https://github.com/iritkatriel
add newshttps://github.com/python/cpython/pull/30289/commits/3e51647c09afe823a2a8894827c0c7275b9c32a8
3e51647https://github.com/python/cpython/pull/30289/commits/3e51647c09afe823a2a8894827c0c7275b9c32a8
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
January 1, 2022 14:37https://github.com/python/cpython/pull/30289#event-5831740496
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
brandtbucherhttps://github.com/brandtbucher
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
January 1, 2022 14:37https://github.com/python/cpython/pull/30289#event-5831740919
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Jan 2, 2022https://github.com/python/cpython/pull/30289#issuecomment-1003687395
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 2, 2022 https://github.com/python/cpython/pull/30289#pullrequestreview-842399602
View reviewed changes https://github.com/python/cpython/pull/30289/files/3e51647c09afe823a2a8894827c0c7275b9c32a8
erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/python/cpython/pull/30289#pullrequestreview-842399602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Jan 2, 2022https://github.com/python/cpython/pull/30289#issuecomment-1003793328
@erlend-aaslandhttps://github.com/erlend-aasland
@brandtbucherhttps://github.com/brandtbucher
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
65e7c1fhttps://github.com/python/cpython/commit/65e7c1f90e9136fc61f4af029b065d9f6c5664c3
Jan 2, 2022https://github.com/python/cpython/pull/30289#event-5833151633
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 2, 2022https://github.com/python/cpython/pull/30289#event-5833151661
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
January 13, 2022 15:33https://github.com/python/cpython/pull/30289#event-5888453065
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30289
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/python/cpython/pull/30289/files/3e51647c09afe823a2a8894827c0c7275b9c32a8
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
Please reload this pagehttps://github.com/python/cpython/pull/30289
https://github.com/iritkatriel
https://github.com/erlend-aasland
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.