René's URL Explorer Experiment


Title: bpo-46162: make `property` generic by sobolevn · Pull Request #30238 · python/cpython · GitHub

Open Graph Title: bpo-46162: make `property` generic by sobolevn · Pull Request #30238 · python/cpython

X Title: bpo-46162: make `property` generic by sobolevn · Pull Request #30238 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Original discussion: python/typing#985 https://bugs.python.org/issue46162 Related, cached_property is already generic: https://github.com/python/cpython/blob/main/Lib/functools.py#L1002

X Description: Original discussion: python/typing#985 https://bugs.python.org/issue46162 Related, cached_property is already generic: https://github.com/python/cpython/blob/main/Lib/functools.py#L1002

Opengraph URL: https://github.com/python/cpython/pull/30238

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e8fa7c10-27f9-58ab-5962-12599507f65f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE308:2A4B31:2C6028:3C320E:6B00267A
html-safe-nonce8e958669ce168a110c589be4b29eafc0283632c31cba950aa1e92b18bbfe8f02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzA4OjJBNEIzMToyQzYwMjg6M0MzMjBFOjZCMDAyNjdBIiwidmlzaXRvcl9pZCI6IjM4NjQ4MDA5NjU2MTM4NTYzNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac104b622098f046a574aff5548fe55231c2724c1819d3f948185b77e91f5a4ce6
hovercard-subject-tagpull_request:809023628
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/30238/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d3c723e7c585bd91b18a44def16c8308d225de77b56c77c82c75acc7080140a2/python/cpython/pull/30238
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d3c723e7c585bd91b18a44def16c8308d225de77b56c77c82c75acc7080140a2/python/cpython/pull/30238
og:image:altOriginal discussion: python/typing#985 https://bugs.python.org/issue46162 Related, cached_property is already generic: https://github.com/python/cpython/blob/main/Lib/functools.py#L1002
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/30238#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30238
Reloadhttps://github.com/python/cpython/pull/30238
Reloadhttps://github.com/python/cpython/pull/30238
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-46162https://github.com/sobolevn/cpython/tree/issue-46162
Conversationhttps://github.com/python/cpython/pull/30238
Commits6 (6)https://github.com/python/cpython/pull/30238/commits
Checkshttps://github.com/python/cpython/pull/30238/checks
Files changedhttps://github.com/python/cpython/pull/30238/files
bpo-46162: make property generichttps://github.com/python/cpython/pull/30238#top
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-46162https://github.com/sobolevn/cpython/tree/issue-46162
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 23, 2021https://github.com/python/cpython/pull/30238#issue-1087555267
Please reload this pagehttps://github.com/python/cpython/pull/30238
python/typing#985https://github.com/python/typing/issues/985
https://bugs.python.org/issue46162https://bugs.python.org/issue46162
https://github.com/python/cpython/blob/main/Lib/functools.py#L1002https://github.com/python/cpython/blob/main/Lib/functools.py#L1002
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/sobolevn
bpo-46162: make property generichttps://github.com/python/cpython/pull/30238/commits/40292650001c4226ed700393098a4480e46ffdf5
4029265https://github.com/python/cpython/pull/30238/commits/40292650001c4226ed700393098a4480e46ffdf5
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Dec 23, 2021https://github.com/python/cpython/pull/30238#event-5809008152
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 23, 2021https://github.com/python/cpython/pull/30238#event-5809008285
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 23, 2021 https://github.com/python/cpython/pull/30238#ref-issue-1084160579
Make builtins.property generic python/typing#985 https://github.com/python/typing/issues/985
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Dec 23, 2021 https://github.com/python/cpython/pull/30238#pullrequestreview-839311394
View reviewed changes https://github.com/python/cpython/pull/30238/files/40292650001c4226ed700393098a4480e46ffdf5
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/30238#pullrequestreview-839311394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Dec 23, 2021https://github.com/python/cpython/pull/30238#event-5809747168
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 23, 2021https://github.com/python/cpython/pull/30238#issuecomment-1000286727
Please reload this pagehttps://github.com/python/cpython/pull/30238
@kumaraditya303https://github.com/kumaraditya303
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/30238
sobolevnhttps://github.com/sobolevn
December 23, 2021 16:06https://github.com/python/cpython/pull/30238#commits-pushed-4b94f77
https://github.com/sobolevn
Improve testhttps://github.com/python/cpython/pull/30238/commits/4b94f77d5add763e550b34d8f8d7f317ff9608be
4b94f77https://github.com/python/cpython/pull/30238/commits/4b94f77d5add763e550b34d8f8d7f317ff9608be
https://github.com/sobolevn
Improve testhttps://github.com/python/cpython/pull/30238/commits/b682749dabfbbc30ce1e3c4889ce8ba27aeee744
b682749https://github.com/python/cpython/pull/30238/commits/b682749dabfbbc30ce1e3c4889ce8ba27aeee744
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Dec 23, 2021https://github.com/python/cpython/pull/30238#issuecomment-1000336207
@kumaraditya303https://github.com/kumaraditya303
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Dec 23, 2021 https://github.com/python/cpython/pull/30238#pullrequestreview-839385985
View reviewed changes https://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744
Lib/test/test_property.pyhttps://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3
isidenticalhttps://github.com/isidentical
Dec 23, 2021https://github.com/python/cpython/pull/30238#discussion_r774600490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Dec 23, 2021https://github.com/python/cpython/pull/30238#issuecomment-1000343910
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Dec 23, 2021https://github.com/python/cpython/pull/30238#issuecomment-1000347323
python/typing#985https://github.com/python/typing/issues/985
Please reload this pagehttps://github.com/python/cpython/pull/30238
sobolevnhttps://github.com/sobolevn
December 23, 2021 18:39https://github.com/python/cpython/pull/30238#commits-pushed-77aa07a
https://github.com/sobolevn
Add property to test_genericaliashttps://github.com/python/cpython/pull/30238/commits/77aa07a26f37f93ddb8ff99573719786a24767a7
77aa07ahttps://github.com/python/cpython/pull/30238/commits/77aa07a26f37f93ddb8ff99573719786a24767a7
https://github.com/sobolevn
More testshttps://github.com/python/cpython/pull/30238/commits/4be39360fdb92528ac354502046a5d5bdb96251c
4be3936https://github.com/python/cpython/pull/30238/commits/4be39360fdb92528ac354502046a5d5bdb96251c
https://github.com/sobolevn
Ensure that you cannot get type hints of a propertyhttps://github.com/python/cpython/pull/30238/commits/f636cf8494d40cee51379e845e4689ab19637d4b
f636cf8https://github.com/python/cpython/pull/30238/commits/f636cf8494d40cee51379e845e4689ab19637d4b
https://github.com/merwok
merwokhttps://github.com/merwok
Dec 31, 2021 https://github.com/python/cpython/pull/30238#pullrequestreview-842294166
View reviewed changes https://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b
Misc/NEWS.d/next/Library/2021-12-23-12-53-34.bpo-46162.bE3xrz.rsthttps://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b#diff-f8a12453c0d7676542a5c3103cf32d38b7cce61f2821fbe0a753b9bbd6f0597f
merwokhttps://github.com/merwok
Dec 31, 2021https://github.com/python/cpython/pull/30238#discussion_r777046980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jan 11, 2022https://github.com/python/cpython/pull/30238#event-5871205938
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238
https://github.com/merwok
merwok https://github.com/merwok
https://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b
https://github.com/isidentical
isidentical https://github.com/isidentical
https://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/30238/files/40292650001c4226ed700393098a4480e46ffdf5
Please reload this pagehttps://github.com/python/cpython/pull/30238
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/30238
https://github.com/sobolevn
https://github.com/isidentical
https://github.com/kumaraditya303
https://github.com/merwok
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.