| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e8fa7c10-27f9-58ab-5962-12599507f65f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E308:2A4B31:2C6028:3C320E:6B00267A |
| html-safe-nonce | 8e958669ce168a110c589be4b29eafc0283632c31cba950aa1e92b18bbfe8f02 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzA4OjJBNEIzMToyQzYwMjg6M0MzMjBFOjZCMDAyNjdBIiwidmlzaXRvcl9pZCI6IjM4NjQ4MDA5NjU2MTM4NTYzNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 104b622098f046a574aff5548fe55231c2724c1819d3f948185b77e91f5a4ce6 |
| hovercard-subject-tag | pull_request:809023628 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/30238/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d3c723e7c585bd91b18a44def16c8308d225de77b56c77c82c75acc7080140a2/python/cpython/pull/30238 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d3c723e7c585bd91b18a44def16c8308d225de77b56c77c82c75acc7080140a2/python/cpython/pull/30238 |
| og:image:alt | Original discussion: python/typing#985
https://bugs.python.org/issue46162
Related, cached_property is already generic: https://github.com/python/cpython/blob/main/Lib/functools.py#L1002 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/30238#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/30238 |
| Reload | https://github.com/python/cpython/pull/30238 |
| Reload | https://github.com/python/cpython/pull/30238 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| sobolevn | https://github.com/sobolevn |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:issue-46162 | https://github.com/sobolevn/cpython/tree/issue-46162 |
| Conversation | https://github.com/python/cpython/pull/30238 |
| Commits6 (6) | https://github.com/python/cpython/pull/30238/commits |
| Checks | https://github.com/python/cpython/pull/30238/checks |
| Files changed | https://github.com/python/cpython/pull/30238/files |
| bpo-46162: make property generic | https://github.com/python/cpython/pull/30238#top |
| sobolevn | https://github.com/sobolevn |
| python:main | https://github.com/python/cpython/tree/main |
| sobolevn:issue-46162 | https://github.com/sobolevn/cpython/tree/issue-46162 |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#issue-1087555267 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| python/typing#985 | https://github.com/python/typing/issues/985 |
| https://bugs.python.org/issue46162 | https://bugs.python.org/issue46162 |
| https://github.com/python/cpython/blob/main/Lib/functools.py#L1002 | https://github.com/python/cpython/blob/main/Lib/functools.py#L1002 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
|
| https://github.com/sobolevn |
| bpo-46162: make property generic | https://github.com/python/cpython/pull/30238/commits/40292650001c4226ed700393098a4480e46ffdf5 |
| 4029265 | https://github.com/python/cpython/pull/30238/commits/40292650001c4226ed700393098a4480e46ffdf5 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#event-5809008152 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#event-5809008285 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Dec 23, 2021
| https://github.com/python/cpython/pull/30238#ref-issue-1084160579 |
|
Make builtins.property generic
python/typing#985
| https://github.com/python/typing/issues/985 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
|
Dec 23, 2021
| https://github.com/python/cpython/pull/30238#pullrequestreview-839311394 |
|
View reviewed changes
| https://github.com/python/cpython/pull/30238/files/40292650001c4226ed700393098a4480e46ffdf5 |
| kumaraditya303 | https://github.com/kumaraditya303 |
| https://github.com/python/cpython/pull/30238#pullrequestreview-839311394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#event-5809747168 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#issuecomment-1000286727 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| @kumaraditya303 | https://github.com/kumaraditya303 |
| @ambv | https://github.com/ambv |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| sobolevn | https://github.com/sobolevn |
| December 23, 2021 16:06 | https://github.com/python/cpython/pull/30238#commits-pushed-4b94f77 |
|
| https://github.com/sobolevn |
| Improve test | https://github.com/python/cpython/pull/30238/commits/4b94f77d5add763e550b34d8f8d7f317ff9608be |
| 4b94f77 | https://github.com/python/cpython/pull/30238/commits/4b94f77d5add763e550b34d8f8d7f317ff9608be |
|
| https://github.com/sobolevn |
| Improve test | https://github.com/python/cpython/pull/30238/commits/b682749dabfbbc30ce1e3c4889ce8ba27aeee744 |
| b682749 | https://github.com/python/cpython/pull/30238/commits/b682749dabfbbc30ce1e3c4889ce8ba27aeee744 |
| https://github.com/isidentical |
| isidentical | https://github.com/isidentical |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#issuecomment-1000336207 |
| @kumaraditya303 | https://github.com/kumaraditya303 |
| @sobolevn | https://github.com/sobolevn |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| https://github.com/isidentical |
| isidentical | https://github.com/isidentical |
|
Dec 23, 2021
| https://github.com/python/cpython/pull/30238#pullrequestreview-839385985 |
|
View reviewed changes
| https://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744 |
| Lib/test/test_property.py | https://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
| isidentical | https://github.com/isidentical |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#discussion_r774600490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#issuecomment-1000343910 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| https://github.com/isidentical |
| isidentical | https://github.com/isidentical |
| Dec 23, 2021 | https://github.com/python/cpython/pull/30238#issuecomment-1000347323 |
| python/typing#985 | https://github.com/python/typing/issues/985 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| sobolevn | https://github.com/sobolevn |
| December 23, 2021 18:39 | https://github.com/python/cpython/pull/30238#commits-pushed-77aa07a |
|
| https://github.com/sobolevn |
| Add property to test_genericalias | https://github.com/python/cpython/pull/30238/commits/77aa07a26f37f93ddb8ff99573719786a24767a7 |
| 77aa07a | https://github.com/python/cpython/pull/30238/commits/77aa07a26f37f93ddb8ff99573719786a24767a7 |
|
| https://github.com/sobolevn |
| More tests | https://github.com/python/cpython/pull/30238/commits/4be39360fdb92528ac354502046a5d5bdb96251c |
| 4be3936 | https://github.com/python/cpython/pull/30238/commits/4be39360fdb92528ac354502046a5d5bdb96251c |
|
| https://github.com/sobolevn |
| Ensure that you cannot get type hints of a property | https://github.com/python/cpython/pull/30238/commits/f636cf8494d40cee51379e845e4689ab19637d4b |
| f636cf8 | https://github.com/python/cpython/pull/30238/commits/f636cf8494d40cee51379e845e4689ab19637d4b |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
|
Dec 31, 2021
| https://github.com/python/cpython/pull/30238#pullrequestreview-842294166 |
|
View reviewed changes
| https://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b |
| Misc/NEWS.d/next/Library/2021-12-23-12-53-34.bpo-46162.bE3xrz.rst | https://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b#diff-f8a12453c0d7676542a5c3103cf32d38b7cce61f2821fbe0a753b9bbd6f0597f |
| merwok | https://github.com/merwok |
| Dec 31, 2021 | https://github.com/python/cpython/pull/30238#discussion_r777046980 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jan 11, 2022 | https://github.com/python/cpython/pull/30238#event-5871205938 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30238 |
|
| https://github.com/merwok |
|
merwok
| https://github.com/merwok |
|
| https://github.com/python/cpython/pull/30238/files/f636cf8494d40cee51379e845e4689ab19637d4b |
|
| https://github.com/isidentical |
|
isidentical
| https://github.com/isidentical |
|
| https://github.com/python/cpython/pull/30238/files/b682749dabfbbc30ce1e3c4889ce8ba27aeee744 |
|
| https://github.com/kumaraditya303 |
|
kumaraditya303
| https://github.com/kumaraditya303 |
|
| https://github.com/python/cpython/pull/30238/files/40292650001c4226ed700393098a4480e46ffdf5 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Please reload this page | https://github.com/python/cpython/pull/30238 |
|
| https://github.com/sobolevn |
|
| https://github.com/isidentical |
|
| https://github.com/kumaraditya303 |
|
| https://github.com/merwok |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |