René's URL Explorer Experiment


Title: bpo-46006: Fix _PyUnicode_EqualToASCIIId() for interned strings by vstinner · Pull Request #30123 · python/cpython · GitHub

Open Graph Title: bpo-46006: Fix _PyUnicode_EqualToASCIIId() for interned strings by vstinner · Pull Request #30123 · python/cpython

X Title: bpo-46006: Fix _PyUnicode_EqualToASCIIId() for interned strings by vstinner · Pull Request #30123 · python/cpython

Description: Fix string comparisons for subinterpreters: no longer make the assumption that two interned strings are not equal if they have different different memory addresses. This assumption is no longer true since interned strings have been made per interpreter in Python 3.10. Fix _PyUnicode_EqualToASCIIId() and type update_slot() functions. The change makes update_slot() a little bit less efficient: update_slot() now compares the strings contents, rather than comparing strings memory addresses. https://bugs.python.org/issue46006

Open Graph Description: Fix string comparisons for subinterpreters: no longer make the assumption that two interned strings are not equal if they have different different memory addresses. This assumption is no longer tru...

X Description: Fix string comparisons for subinterpreters: no longer make the assumption that two interned strings are not equal if they have different different memory addresses. This assumption is no longer tru...

Opengraph URL: https://github.com/python/cpython/pull/30123

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b078a290-862f-8468-e3f0-ab65918ecac4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E9A:96FA2:A51E4B:E1AEB9:6969E5FE
html-safe-nonce6e499e7405791278b56fe96e8d54c82c1b98b4c2dfb24955aa15fed9e3a85d9b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTlBOjk2RkEyOkE1MUU0QjpFMUFFQjk6Njk2OUU1RkUiLCJ2aXNpdG9yX2lkIjoiNDk3OTE1MTU4NTExMTgyNzk2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd0d432b919b6985319c7acae6983fd14347ec7428c5f608056bab6ddba398de7
hovercard-subject-tagpull_request:803541995
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/30123/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altFix string comparisons for subinterpreters: no longer make the assumption that two interned strings are not equal if they have different different memory addresses. This assumption is no longer tru...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/30123/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30123%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30123%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30123/files
Reloadhttps://github.com/python/cpython/pull/30123/files
Reloadhttps://github.com/python/cpython/pull/30123/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/30123/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/30123/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:mainhttps://github.com/python/cpython/tree/main
Conversation 8 https://github.com/python/cpython/pull/30123
Commits 1 https://github.com/python/cpython/pull/30123/commits
Checks 0 https://github.com/python/cpython/pull/30123/checks
Files changed https://github.com/python/cpython/pull/30123/files
Please reload this pagehttps://github.com/python/cpython/pull/30123/files
bpo-46006: Fix _PyUnicode_EqualToASCIIId() for interned strings https://github.com/python/cpython/pull/30123/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/30123/files
41c1f59 bpo-46006: Fix _PyUnicode_EqualToASCIIId() for interned strings vstinner Dec 15, 2021 https://github.com/python/cpython/pull/30123/commits/41c1f59f2309170f7e6cb350c83218597cb9724a
Clear filters https://github.com/python/cpython/pull/30123/files
Please reload this pagehttps://github.com/python/cpython/pull/30123/files
Please reload this pagehttps://github.com/python/cpython/pull/30123/files
2021-12-15-15-30-04.bpo-46006.T4pbJR.rst https://github.com/python/cpython/pull/30123/files#diff-8e0e81e83a5bf82231e0472ea431318eb8a54603e04d305304992afa642f27d9
typeobject.c https://github.com/python/cpython/pull/30123/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
unicodeobject.c https://github.com/python/cpython/pull/30123/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
Misc/NEWS.d/next/Core and Builtins/2021-12-15-15-30-04.bpo-46006.T4pbJR.rsthttps://github.com/python/cpython/pull/30123/files#diff-8e0e81e83a5bf82231e0472ea431318eb8a54603e04d305304992afa642f27d9
View file https://github.com/python/cpython/blob/41c1f59f2309170f7e6cb350c83218597cb9724a/Misc/NEWS.d/next/Core%20and%20Builtins/2021-12-15-15-30-04.bpo-46006.T4pbJR.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30123/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L216
Objects/typeobject.chttps://github.com/python/cpython/pull/30123/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/python/cpython/blob/41c1f59f2309170f7e6cb350c83218597cb9724a/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30123/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30123/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/30123/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Objects/unicodeobject.chttps://github.com/python/cpython/pull/30123/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
View file https://github.com/python/cpython/blob/41c1f59f2309170f7e6cb350c83218597cb9724a/Objects/unicodeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30123/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30123/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com/python/cpython/pull/30123/files#diff-34c966e7876d6f8bf801dd51896327e4f68bba02cddb95fbf3963f0b2e39c38a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.