René's URL Explorer Experiment


Title: bpo-45582: Fix test_embed failure during a PGO build on Windows by neonene · Pull Request #30014 · python/cpython · GitHub

Open Graph Title: bpo-45582: Fix test_embed failure during a PGO build on Windows by neonene · Pull Request #30014 · python/cpython

X Title: bpo-45582: Fix test_embed failure during a PGO build on Windows by neonene · Pull Request #30014 · python/cpython

Description: PGO-instrumented _testembed.exe and getpath.py often miscalculate the prefix path, when launched with all PYTHON* envvars removed. The new path calculation uses VPATH, which is defined as "..\\.." in pythoncore.vcxproj. From PGO-instrumented folder, VPATH needs to be "..\\..\\.." to resolve prefix. https://bugs.python.org/issue45582

Open Graph Description: PGO-instrumented _testembed.exe and getpath.py often miscalculate the prefix path, when launched with all PYTHON* envvars removed. The new path calculation uses VPATH, which is defined as "..\...

X Description: PGO-instrumented _testembed.exe and getpath.py often miscalculate the prefix path, when launched with all PYTHON* envvars removed. The new path calculation uses VPATH, which is defined as &quot...

Opengraph URL: https://github.com/python/cpython/pull/30014

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d31c4aa5-6a7d-9a49-5de2-b99832001a0f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8FE:31315B:399B27:4CE1FC:6969AE0A
html-safe-nonce4b4412f089b1024cb1b9037d547117b639a5c1b05ee18e220c6598bb9fe5a543
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEZFOjMxMzE1QjozOTlCMjc6NENFMUZDOjY5NjlBRTBBIiwidmlzaXRvcl9pZCI6IjE1MzA2OTc3NDQ4NjY4NjgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4f81e2021836041b2a73017571a7988ea7e658d36232a400ef737a0f9cbac78d
hovercard-subject-tagpull_request:799089838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/30014/files
twitter:imagehttps://avatars.githubusercontent.com/u/53406459?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/53406459?s=400&v=4
og:image:altPGO-instrumented _testembed.exe and getpath.py often miscalculate the prefix path, when launched with all PYTHON* envvars removed. The new path calculation uses VPATH, which is defined as "..\...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/30014/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30014%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F30014%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/30014/files
Reloadhttps://github.com/python/cpython/pull/30014/files
Reloadhttps://github.com/python/cpython/pull/30014/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/30014/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/30014/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
Conversation 3 https://github.com/python/cpython/pull/30014
Commits 12 https://github.com/python/cpython/pull/30014/commits
Checks 0 https://github.com/python/cpython/pull/30014/checks
Files changed https://github.com/python/cpython/pull/30014/files
Please reload this pagehttps://github.com/python/cpython/pull/30014/files
bpo-45582: Fix test_embed failure during a PGO build on Windows https://github.com/python/cpython/pull/30014/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/30014/files
1e6bb41 VPATH definition exclusive for PGInstrument neonene Dec 9, 2021 https://github.com/python/cpython/pull/30014/commits/1e6bb41821372060dfb55eeb859b8f7763c64c2e
24d03eb Use VPATH for BUILD_LANDMARK neonene Dec 9, 2021 https://github.com/python/cpython/pull/30014/commits/24d03eb12b08e45ff354292adedb0bcb174dc2b5
0529d08 Use different VPATH in test_init_pybuilddir_win32 neonene Dec 9, 2021 https://github.com/python/cpython/pull/30014/commits/0529d08d7a72a776543f68f3ea34368b0f838333
6662755 Merge branch 'python:main' into bpo-45582_pgo2 neonene Dec 9, 2021 https://github.com/python/cpython/pull/30014/commits/666275585134ec660b673b6f796497446e172c29
737cedb VPATH definition for MSBuild neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/737cedba901f80c83c7ff640eb87919423fbbffd
78e1fdb VPATH for sysmodule.c / getpath.c neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/78e1fdbbaf6f4e068ff174f9c5292be6edd66ff4
678a408 VPATH for sysmodule.c (freezed) neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/678a40889f22d5c1f668627e9a83f2e8ae3a38b3
bf34c4f Implement sys._vpath neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/bf34c4f3a77022031c321ff73ae18fed83a60a91
7f8e0e3 sysconfig.get_config_var('VPATH') neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/7f8e0e39dcbf4f6a67a308561338635cbc8ed9b5
ee17a52 Use VPATH in test_embed neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/ee17a52dcc4d8483955ee3a72fcc1404f563ada2
f3ac09c Fix indent in test_embed neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/f3ac09c942fb7588a3eeec2d2a885d6f72472183
2513c67 Fix a redundant definition neonene Dec 10, 2021 https://github.com/python/cpython/pull/30014/commits/2513c67190abab1a732666d193e387498fed7401
Clear filters https://github.com/python/cpython/pull/30014/files
Please reload this pagehttps://github.com/python/cpython/pull/30014/files
Please reload this pagehttps://github.com/python/cpython/pull/30014/files
sysconfig.py https://github.com/python/cpython/pull/30014/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
test_embed.py https://github.com/python/cpython/pull/30014/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
getpath.py https://github.com/python/cpython/pull/30014/files#diff-6fce05f0b43cd31ded3d7c0b3db040a75a61c79874dd660485f040a1773e3418
_freeze_module.vcxproj https://github.com/python/cpython/pull/30014/files#diff-d6e731738eec137782f1f1add8cb8ae28cbe912b6bedfe170eb91e90c388702e
python.props https://github.com/python/cpython/pull/30014/files#diff-bfa2e59d45a0dee1f2277e32e3fb94b24d13719427fe5cd4e1ab1a8d50d8ed6d
pythoncore.vcxproj https://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
sysmodule.c https://github.com/python/cpython/pull/30014/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L574
Lib/sysconfig.pyhttps://github.com/python/cpython/pull/30014/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/Lib/sysconfig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/pull/30014/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
Lib/test/test_embed.pyhttps://github.com/python/cpython/pull/30014/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/Lib/test/test_embed.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/pull/30014/files#diff-573be25566e43f5adc6650ad1b58d106dbbd79521cb9c6e6d5df9588616a1ffd
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L251
Modules/getpath.pyhttps://github.com/python/cpython/pull/30014/files#diff-6fce05f0b43cd31ded3d7c0b3db040a75a61c79874dd660485f040a1773e3418
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/Modules/getpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-6fce05f0b43cd31ded3d7c0b3db040a75a61c79874dd660485f040a1773e3418
https://github.com/python/cpython/pull/30014/files#diff-6fce05f0b43cd31ded3d7c0b3db040a75a61c79874dd660485f040a1773e3418
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L262
PCbuild/_freeze_module.vcxprojhttps://github.com/python/cpython/pull/30014/files#diff-d6e731738eec137782f1f1add8cb8ae28cbe912b6bedfe170eb91e90c388702e
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/PCbuild/_freeze_module.vcxproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-d6e731738eec137782f1f1add8cb8ae28cbe912b6bedfe170eb91e90c388702e
https://github.com/python/cpython/pull/30014/files#diff-d6e731738eec137782f1f1add8cb8ae28cbe912b6bedfe170eb91e90c388702e
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L185
PCbuild/python.propshttps://github.com/python/cpython/pull/30014/files#diff-bfa2e59d45a0dee1f2277e32e3fb94b24d13719427fe5cd4e1ab1a8d50d8ed6d
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/PCbuild/python.props
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-bfa2e59d45a0dee1f2277e32e3fb94b24d13719427fe5cd4e1ab1a8d50d8ed6d
https://github.com/python/cpython/pull/30014/files#diff-bfa2e59d45a0dee1f2277e32e3fb94b24d13719427fe5cd4e1ab1a8d50d8ed6d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L185
PCbuild/pythoncore.vcxprojhttps://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/PCbuild/pythoncore.vcxproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/pull/30014/files#diff-4295039788386c2986b811f2a6b59cf088be59822b24b4f1243c9e9b184f65fb
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L243
Python/sysmodule.chttps://github.com/python/cpython/pull/30014/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
View file https://github.com/python/cpython/blob/2513c67190abab1a732666d193e387498fed7401/Python/sysmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/30014/{{ revealButtonHref }}
https://github.com/python/cpython/pull/30014/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com/python/cpython/pull/30014/files#diff-a3a5c73931235f7f344c072dc755d6508e13923db3f5d581c5e88652075871cb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.