Title: bpo-45582: Fix getpath_isxfile() and test_embed on Windows by neonene · Pull Request #29930 · python/cpython · GitHub
Open Graph Title: bpo-45582: Fix getpath_isxfile() and test_embed on Windows by neonene · Pull Request #29930 · python/cpython
X Title: bpo-45582: Fix getpath_isxfile() and test_embed on Windows by neonene · Pull Request #29930 · python/cpython
Description: Current getpath_isxfile() in getpath.c always returns false. After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build. test_init_pybuilddir_win32 test_init_pyvenv_cfg FAIL: test_init_pybuilddir_win32 (test.test_embed.InitConfigTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\cp\Lib\test\test_embed.py", line 1322, in test_init_pybuilddir_win32 self.check_all_configs("test_init_compat_config", config, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\cp\Lib\test\test_embed.py", line 728, in check_all_configs self.check_config(configs, expected_config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\cp\Lib\test\test_embed.py", line 654, in check_config self.assertEqual(config, expected) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: {'_co[316 chars]embed.exe', ... ... - 'program_name': './_testembed.exe', ? ---- + 'program_name': './_testembed', ... The debug build passes them using the default program_name, and the PGO build does not due to another issue. https://bugs.python.org/issue45582
Open Graph Description: Current getpath_isxfile() in getpath.c always returns false. After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build....
X Description: Current getpath_isxfile() in getpath.c always returns false. After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build....
Opengraph URL: https://github.com/python/cpython/pull/29930
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:39878b5c-ff01-ed1e-ff76-634c6431c4fc |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C380:FB3A6:963205:CE824E:6969E66F |
| html-safe-nonce | c4d76769156056b18a17a7f0849dff9221f1a91036b37f7fd654c6ae50556e4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzgwOkZCM0E2Ojk2MzIwNTpDRTgyNEU6Njk2OUU2NkYiLCJ2aXNpdG9yX2lkIjoiNDg3NDU2NTYwOTU4MTA0NTM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 59641a65987822e0adf65eb912cb9a8906f953867de30de11e90b9e43edca87e |
| hovercard-subject-tag | pull_request:795419540 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/29930/checks |
| twitter:image | https://avatars.githubusercontent.com/u/53406459?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/53406459?s=400&v=4 |
| og:image:alt | Current getpath_isxfile() in getpath.c always returns false. After the function is fixed, test_embed.py needs a workaround to pass the following tests that have the same error in the release build.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width