René's URL Explorer Experiment


Title: bpo-45711: Remove unnecessary normalization of exc_info by iritkatriel · Pull Request #29922 · python/cpython · GitHub

Open Graph Title: bpo-45711: Remove unnecessary normalization of exc_info by iritkatriel · Pull Request #29922 · python/cpython

X Title: bpo-45711: Remove unnecessary normalization of exc_info by iritkatriel · Pull Request #29922 · python/cpython

Description: exc_info should always be normalized, so it is not necessary to normalize it here. It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback does not change, and it broke only one test: test_exception_chaining_after_await_with_context_cycle This is a test that raises the same exception twice, and makes sure that no context cycle is created. The test is not concerned with the traceback at all. We discussed the issue of the traceback change in this test in PR29780. https://bugs.python.org/issue45711

Open Graph Description: exc_info should always be normalized, so it is not necessary to normalize it here. It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback ...

X Description: exc_info should always be normalized, so it is not necessary to normalize it here. It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback ...

Opengraph URL: https://github.com/python/cpython/pull/29922

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26537ecc-740f-d2fe-d425-68dc7c3baddb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83A2:2E8FB4:3BC3ED5:4EED117:6A5D34B1
html-safe-noncee0fb5d9c495ae4536a47ec04ece15a23279e9291b002f0bb784b9e6c8a9ab4a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0EyOjJFOEZCNDozQkMzRUQ1OjRFRUQxMTc6NkE1RDM0QjEiLCJ2aXNpdG9yX2lkIjoiMzczNTA0MzAxNTY3OTIyNzA1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac37cd147f0d0c3ad4e8570facba574f335719828aab93346753f5b4a1fc8de5b2
hovercard-subject-tagpull_request:795338597
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/29922/files
twitter:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1055913?s=400&v=4
og:image:altexc_info should always be normalized, so it is not necessary to normalize it here. It is also not necessary to copy the traceback to the exception instance. I added an assertion that the traceback ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/29922/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29922%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29922%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/29922/files
Reloadhttps://github.com/python/cpython/pull/29922/files
Reloadhttps://github.com/python/cpython/pull/29922/files
Please reload this pagehttps://github.com/python/cpython/pull/29922/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/29922/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:45711-exc_info_does_not_need_normalizing-2https://github.com/iritkatriel/cpython/tree/45711-exc_info_does_not_need_normalizing-2
Conversation 1 https://github.com/python/cpython/pull/29922
Commits 3 https://github.com/python/cpython/pull/29922/commits
Checks 0 https://github.com/python/cpython/pull/29922/checks
Files changed https://github.com/python/cpython/pull/29922/files
Please reload this pagehttps://github.com/python/cpython/pull/29922/files
bpo-45711: Remove unnecessary normalization of exc_info https://github.com/python/cpython/pull/29922/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/29922/files
7a22e14 bpo-45711: Remove unnecessary normalization of exc_info iritkatriel Dec 2, 2021 https://github.com/python/cpython/pull/29922/commits/7a22e148468e82ea27838959a7e5ea6666276098
ddbb27d 📜🤖 Added by blurb_it. blurb-it[bot] Dec 5, 2021 https://github.com/python/cpython/pull/29922/commits/ddbb27dcf0af4fe013badd352aa1d295ae0e3356
0314b71 Fix typo in news iritkatriel Dec 8, 2021 https://github.com/python/cpython/pull/29922/commits/0314b71ddea891a1e621d47c64b4e226fbf78c50
Clear filters https://github.com/python/cpython/pull/29922/files
Please reload this pagehttps://github.com/python/cpython/pull/29922/files
Please reload this pagehttps://github.com/python/cpython/pull/29922/files
2021-12-05-17-36-08.bpo-45711.3TmTSw.rst https://github.com/python/cpython/pull/29922/files#diff-348d34cf05fc5ff1d2017efe561858aa5790d75d0e76f354544c169ec4ba00a6
errors.c https://github.com/python/cpython/pull/29922/files#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
Misc/NEWS.d/next/Core and Builtins/2021-12-05-17-36-08.bpo-45711.3TmTSw.rsthttps://github.com/python/cpython/pull/29922/files#diff-348d34cf05fc5ff1d2017efe561858aa5790d75d0e76f354544c169ec4ba00a6
View file https://github.com/iritkatriel/cpython/blob/0314b71ddea891a1e621d47c64b4e226fbf78c50/Misc/NEWS.d/next/Core%20and%20Builtins/2021-12-05-17-36-08.bpo-45711.3TmTSw.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/29922/{{ revealButtonHref }}
Python/errors.chttps://github.com/python/cpython/pull/29922/files#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
View file https://github.com/iritkatriel/cpython/blob/0314b71ddea891a1e621d47c64b4e226fbf78c50/Python/errors.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/29922/{{ revealButtonHref }}
https://github.com/python/cpython/pull/29922/files#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
https://github.com/python/cpython/pull/29922/files#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.