René's URL Explorer Experiment


Title: bpo-45711: use exc_value instead of exc_type to determine if exc_info is valid. Add more assertions. by iritkatriel · Pull Request #29627 · python/cpython · GitHub

Open Graph Title: bpo-45711: use exc_value instead of exc_type to determine if exc_info is valid. Add more assertions. by iritkatriel · Pull Request #29627 · python/cpython

X Title: bpo-45711: use exc_value instead of exc_type to determine if exc_info is valid. Add more assertions. by iritkatriel · Pull Request #29627 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This brings us closer to removing exc_type from exc_info. Where exc_type is used, I made it use exc_value instead and added assertions that this is ok. Then when we remove exc_type it will just be ...

X Description: This brings us closer to removing exc_type from exc_info. Where exc_type is used, I made it use exc_value instead and added assertions that this is ok. Then when we remove exc_type it will just be ...

Opengraph URL: https://github.com/python/cpython/pull/29627

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:64d64636-c649-23b8-1f0d-647439abdea4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD2C:1D1115:5B87E7:7A612A:6A5BD51E
html-safe-nonce407ce61c368da14a9b059e8beec153bcd5a46047e3fdd46f12c621af6736234e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDJDOjFEMTExNTo1Qjg3RTc6N0E2MTJBOjZBNUJENTFFIiwidmlzaXRvcl9pZCI6IjY1ODQ5NzI3NTY4MjgwMTc5NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5bfd4062d0a5ab7e2e307bde96bedea91e69c91da17b2860d862b8567e5579b9
hovercard-subject-tagpull_request:784047593
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29627/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8be0817dd6b2ddef9eb9fe2b494b5c8ef72364ff5b90afaa338766aa1ab1d44f/python/cpython/pull/29627
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8be0817dd6b2ddef9eb9fe2b494b5c8ef72364ff5b90afaa338766aa1ab1d44f/python/cpython/pull/29627
og:image:altThis brings us closer to removing exc_type from exc_info. Where exc_type is used, I made it use exc_value instead and added assertions that this is ok. Then when we remove exc_type it will just be ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiritkatriel
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/29627#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29627
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29627
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/29627
Reloadhttps://github.com/python/cpython/pull/29627
Reloadhttps://github.com/python/cpython/pull/29627
Please reload this pagehttps://github.com/python/cpython/pull/29627
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/29627
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.4k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:bpo-45711-remove-exc_type_fieldhttps://github.com/iritkatriel/cpython/tree/bpo-45711-remove-exc_type_field
Conversationhttps://github.com/python/cpython/pull/29627
Commits7 (7)https://github.com/python/cpython/pull/29627/commits
Checkshttps://github.com/python/cpython/pull/29627/checks
Files changedhttps://github.com/python/cpython/pull/29627/files
bpo-45711: use exc_value instead of exc_type to determine if exc_info is valid. Add more assertions.https://github.com/python/cpython/pull/29627#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
iritkatriel:bpo-45711-remove-exc_type_fieldhttps://github.com/iritkatriel/cpython/tree/bpo-45711-remove-exc_type_field
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 18, 2021https://github.com/python/cpython/pull/29627#issue-1057718325
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://bugs.python.org/issue45711https://bugs.python.org/issue45711
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/iritkatriel
bpo-45711: make decisions based on exc_value instead of exc_type. Str…https://github.com/python/cpython/pull/29627/commits/9275583eb03d66fef007b6d06a09a4a96ef358d1
9275583https://github.com/python/cpython/pull/29627/commits/9275583eb03d66fef007b6d06a09a4a96ef358d1
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/32959108f9c543e3cb9f2b68bbc782bddded6f42/.github/CODEOWNERS#L20
November 18, 2021 19:25https://github.com/python/cpython/pull/29627#event-5640988846
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 18, 2021https://github.com/python/cpython/pull/29627#event-5640989023
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 18, 2021https://github.com/python/cpython/pull/29627#event-5640989240
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 18, 2021https://github.com/python/cpython/pull/29627#event-5640994887
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
terryjreedyhttps://github.com/terryjreedy
November 18, 2021 19:54https://github.com/python/cpython/pull/29627#event-5641131816
iritkatrielhttps://github.com/iritkatriel
November 19, 2021 10:38https://github.com/python/cpython/pull/29627#commits-pushed-fbff4f6
https://github.com/iritkatriel
put assertion definition under Py_DEBUG to remove Address sanitizer w…https://github.com/python/cpython/pull/29627/commits/fbff4f6831da24ac08a97749fc808393e482e4f6
fbff4f6https://github.com/python/cpython/pull/29627/commits/fbff4f6831da24ac08a97749fc808393e482e4f6
https://github.com/iritkatriel
Merge remote-tracking branch 'upstream/main' into bpo-45711-remove-ex…https://github.com/python/cpython/pull/29627/commits/bc889bce6858f2426de7ad54a993ba073e48525a
bc889bchttps://github.com/python/cpython/pull/29627/commits/bc889bce6858f2426de7ad54a993ba073e48525a
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Nov 22, 2021https://github.com/python/cpython/pull/29627#event-5656926564
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 22, 2021https://github.com/python/cpython/pull/29627#issuecomment-975956245
@iritkatrielhttps://github.com/iritkatriel
bc889bchttps://github.com/python/cpython/commit/bc889bce6858f2426de7ad54a993ba073e48525a
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Nov 22, 2021https://github.com/python/cpython/pull/29627#event-5656926704
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
gvanrossumhttps://github.com/gvanrossum
November 23, 2021 11:02https://github.com/python/cpython/pull/29627#event-5659551459
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 24, 2021 https://github.com/python/cpython/pull/29627#pullrequestreview-815380589
View reviewed changes https://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/29627#pullrequestreview-815380589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29627
Python/errors.chttps://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/iritkatriel
https://github.com/gvanrossum
err_info->exc_value ==> exc_valuehttps://github.com/python/cpython/pull/29627/commits/3c451a1b9d2715716c61bcffadca96b9512de9d3
3c451a1https://github.com/python/cpython/pull/29627/commits/3c451a1b9d2715716c61bcffadca96b9512de9d3
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Nov 24, 2021https://github.com/python/cpython/pull/29627#issuecomment-978314372
Please reload this pagehttps://github.com/python/cpython/pull/29627
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 24, 2021 https://github.com/python/cpython/pull/29627#pullrequestreview-815391686
View reviewed changes https://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/29627#pullrequestreview-815391686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29627
Python/errors.chttps://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
Please reload this pagehttps://github.com/python/cpython/pull/29627
Python/errors.chttps://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
Please reload this pagehttps://github.com/python/cpython/pull/29627
Python/errors.chttps://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
Please reload this pagehttps://github.com/python/cpython/pull/29627
Python/errors.chttps://github.com/python/cpython/pull/29627/files/bc889bce6858f2426de7ad54a993ba073e48525a#diff-c37c836d0535b79d87b8eb0652c59ac0c2aeb1461bcb2274bee82656cecacad4
gvanrossumhttps://github.com/gvanrossum
Nov 24, 2021https://github.com/python/cpython/pull/29627#discussion_r756462858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29627
iritkatrielhttps://github.com/iritkatriel
November 24, 2021 23:50https://github.com/python/cpython/pull/29627#commits-pushed-277c509
https://github.com/iritkatriel
Simplified _PyErr_GetExcInfo. Moved assertion in _PyErr_GetTopmostExc…https://github.com/python/cpython/pull/29627/commits/277c509bf0849a71044c89483b2f78f36791189e
277c509https://github.com/python/cpython/pull/29627/commits/277c509bf0849a71044c89483b2f78f36791189e
https://github.com/iritkatriel
exc2 --> typ2https://github.com/python/cpython/pull/29627/commits/437cebba2e8220e1766ee51bb9ee8fc842bee337
437cebbhttps://github.com/python/cpython/pull/29627/commits/437cebba2e8220e1766ee51bb9ee8fc842bee337
https://github.com/iritkatriel
exc --> typhttps://github.com/python/cpython/pull/29627/commits/de67ed658b0bf862b565e146d18aa180e10210cf
de67ed6https://github.com/python/cpython/pull/29627/commits/de67ed658b0bf862b565e146d18aa180e10210cf
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Nov 25, 2021 https://github.com/python/cpython/pull/29627#pullrequestreview-815457626
View reviewed changes https://github.com/python/cpython/pull/29627/files/de67ed658b0bf862b565e146d18aa180e10210cf
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/29627#pullrequestreview-815457626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 25, 2021https://github.com/python/cpython/pull/29627#event-5669894768
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
c456dfahttps://github.com/python/cpython/commit/c456dfafe9f9f6614fbcf2213a93707f0e101f4e
Nov 25, 2021https://github.com/python/cpython/pull/29627#event-5671741139
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 25, 2021https://github.com/python/cpython/pull/29627#event-5671741343
remykaremhttps://github.com/remykarem
Dec 7, 2021 https://github.com/python/cpython/pull/29627#ref-commit-c69c987
https://github.com/iritkatriel
https://github.com/remykarem
bpo-45711: use exc_value instead of exc_type to determine if exc_info…https://github.com/remykarem/cpython/commit/c69c9875481fa20a7b1706be20d3f4dc6ca7e17a
c69c987https://github.com/remykarem/cpython/commit/c69c9875481fa20a7b1706be20d3f4dc6ca7e17a
pythonGH-29627https://github.com/python/cpython/pull/29627
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
January 13, 2022 15:34https://github.com/python/cpython/pull/29627#event-5888465593
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29627
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/29627/files/de67ed658b0bf862b565e146d18aa180e10210cf
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/terryjreedy
terryjreedy https://github.com/terryjreedy
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/29627
https://github.com/iritkatriel
https://github.com/bedevere-bot
https://github.com/gvanrossum
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.