René's URL Explorer Experiment


Title: bpo-29070: Integration tests for pty module with patch from bpo-26228 by diekmann · Pull Request #2932 · python/cpython · GitHub

Open Graph Title: bpo-29070: Integration tests for pty module with patch from bpo-26228 by diekmann · Pull Request #2932 · python/cpython

X Title: bpo-29070: Integration tests for pty module with patch from bpo-26228 by diekmann · Pull Request #2932 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: TL;DR: Fix issue and add huge test suite for pty.py. Some development of a test suite with integration tests for the pty module happened over several months in the python bug tracker (when python w...

X Description: TL;DR: Fix issue and add huge test suite for pty.py. Some development of a test suite with integration tests for the pty module happened over several months in the python bug tracker (when python w...

Opengraph URL: https://github.com/python/cpython/pull/2932

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3d1529dd-d676-7bce-ee8c-f6dcd066d816
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD91C:3C7A3:44055AA:607DA6E:6A4FC589
html-safe-nonce4953ac4dae8b0ee4be2847230862618a86803ae871bca0c96e5427caed049fdc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTFDOjNDN0EzOjQ0MDU1QUE6NjA3REE2RTo2QTRGQzU4OSIsInZpc2l0b3JfaWQiOiIzNTc0NjgyOTI5ODQ5MTU3MDAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac551109fbdc34f304e5edaa0b3ce53a2e12a5a8c44643c2e34d66b6c97ed7316f
hovercard-subject-tagpull_request:132997338
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/2932/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d9cc7dc1dae0509411936220efd1737d9a2731766e38348209ee7ee259be7d76/python/cpython/pull/2932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9cc7dc1dae0509411936220efd1737d9a2731766e38348209ee7ee259be7d76/python/cpython/pull/2932
og:image:altTL;DR: Fix issue and add huge test suite for pty.py. Some development of a test suite with integration tests for the pty module happened over several months in the python bug tracker (when python w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamediekmann
hostnamegithub.com
expected-hostnamegithub.com
None60b2ae4c725f51e2dac275d0ac5e9233e5967a61cdfaebd732f63da67ff1b71c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release06fb64e1cb36b9a7a2e3f0e6c14af40ef9f439d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/2932#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2932
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2932
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/2932
Reloadhttps://github.com/python/cpython/pull/2932
Reloadhttps://github.com/python/cpython/pull/2932
Please reload this pagehttps://github.com/python/cpython/pull/2932
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/2932
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
diekmannhttps://github.com/diekmann
python:masterhttps://github.com/python/cpython/tree/master
diekmann:wip-issue-29070https://github.com/diekmann/cpython/tree/wip-issue-29070
Conversationhttps://github.com/python/cpython/pull/2932
Commits26 (26)https://github.com/python/cpython/pull/2932/commits
Checkshttps://github.com/python/cpython/pull/2932/checks
Files changedhttps://github.com/python/cpython/pull/2932/files
bpo-29070: Integration tests for pty module with patch from bpo-26228https://github.com/python/cpython/pull/2932#top
diekmannhttps://github.com/diekmann
python:masterhttps://github.com/python/cpython/tree/master
diekmann:wip-issue-29070https://github.com/diekmann/cpython/tree/wip-issue-29070
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Jul 28, 2017https://github.com/python/cpython/pull/2932#issue-246385862
Please reload this pagehttps://github.com/python/cpython/pull/2932
bpo-26228http://bugs.python.org/issue26228
bpo-29070http://bugs.python.org/issue29070
review toolhttp://bugs.python.org/review/29070/#ps20016
bpo-26228https://bugs.python.org/issue?@action=redirect&bpo=26228
https://bugs.python.org/issue29070https://bugs.python.org/issue29070
Please reload this pagehttps://github.com/python/cpython/pull/2932
diekmannhttps://github.com/diekmann
July 28, 2017 17:13https://github.com/python/cpython/pull/2932#commits-pushed-703c1d1
https://github.com/diekmann
migrating issue to githubhttps://github.com/python/cpython/pull/2932/commits/703c1d13eeacb4c6d52fe96d27cb7569aef26079
703c1d1https://github.com/python/cpython/pull/2932/commits/703c1d13eeacb4c6d52fe96d27cb7569aef26079
http://bugs.python.org/file46613/pty.patchhttp://bugs.python.org/file46613/pty.patch
http://bugs.python.org/issue29070http://bugs.python.org/issue29070
https://github.com/diekmann
using subprocess.run to run pty.spawnhttps://github.com/python/cpython/pull/2932/commits/78c165aad018efb62f1a41dad6d0792923968a79
78c165ahttps://github.com/python/cpython/pull/2932/commits/78c165aad018efb62f1a41dad6d0792923968a79
https://github.com/diekmann
move _mock_stdin_stdout to the actual testshttps://github.com/python/cpython/pull/2932/commits/28e918e1323954b04cbdd29dd6b837eb9b5d5a4d
28e918ehttps://github.com/python/cpython/pull/2932/commits/28e918e1323954b04cbdd29dd6b837eb9b5d5a4d
https://github.com/diekmann
Get os.forkpty disabled again.https://github.com/python/cpython/pull/2932/commits/6e7f587c31d4ca9290f13bdf4eb075f16e00dcc8
6e7f587https://github.com/python/cpython/pull/2932/commits/6e7f587c31d4ca9290f13bdf4eb075f16e00dcc8
https://github.com/diekmann
Yes, way less monkey patching.https://github.com/python/cpython/pull/2932/commits/fd61cad9000f9c6e903b78525a9d164e9b3b4066
fd61cadhttps://github.com/python/cpython/pull/2932/commits/fd61cad9000f9c6e903b78525a9d164e9b3b4066
https://github.com/diekmann
Decoupling PtySpawnTestBase and PtyMockingTestBasehttps://github.com/python/cpython/pull/2932/commits/e9b0b8b48972fe6e81eba8bb009a0eb831e57e48
e9b0b8bhttps://github.com/python/cpython/pull/2932/commits/e9b0b8b48972fe6e81eba8bb009a0eb831e57e48
https://github.com/diekmann
Move PtyMockingTestBase closer to PtyCopyTestshttps://github.com/python/cpython/pull/2932/commits/a42755bbbc3a5eac56fce108ac379165885285ca
a42755bhttps://github.com/python/cpython/pull/2932/commits/a42755bbbc3a5eac56fce108ac379165885285ca
https://github.com/diekmann
Tuned class hierarchyhttps://github.com/python/cpython/pull/2932/commits/7451f9798582685a2c7e0520c538c3c10c96eb3f
7451f97https://github.com/python/cpython/pull/2932/commits/7451f9798582685a2c7e0520c538c3c10c96eb3f
https://github.com/diekmann
fix line length and error path of base classeshttps://github.com/python/cpython/pull/2932/commits/b604d83b51f79cc36aaec7d9dd8a9fee8d15b7e1
b604d83https://github.com/python/cpython/pull/2932/commits/b604d83b51f79cc36aaec7d9dd8a9fee8d15b7e1
https://github.com/diekmann
clarify difference to alternativeshttps://github.com/python/cpython/pull/2932/commits/cbe7d14ad72b8c4c83c05ccd06cc1d1c66745f0d
cbe7d14https://github.com/python/cpython/pull/2932/commits/cbe7d14ad72b8c4c83c05ccd06cc1d1c66745f0d
https://github.com/diekmann
move disable-os.forkpty-code closer to the testhttps://github.com/python/cpython/pull/2932/commits/8afd1e73c357b3be02c4ca989d37c218bd0d0195
8afd1e7https://github.com/python/cpython/pull/2932/commits/8afd1e73c357b3be02c4ca989d37c218bd0d0195
https://github.com/diekmann
cosmetic changeshttps://github.com/python/cpython/pull/2932/commits/2c3498febcb65023f213d753fb86068ae407cab6
2c3498fhttps://github.com/python/cpython/pull/2932/commits/2c3498febcb65023f213d753fb86068ae407cab6
https://github.com/diekmann
polishhttps://github.com/python/cpython/pull/2932/commits/ec58a624f8f08005a5b1e94678efe31a30e71556
ec58a62https://github.com/python/cpython/pull/2932/commits/ec58a624f8f08005a5b1e94678efe31a30e71556
https://github.com/diekmann
let exceptions out and fail the testshttps://github.com/python/cpython/pull/2932/commits/0be6c54f725a2559d1c5fdafdda054cdc6e5959c
0be6c54https://github.com/python/cpython/pull/2932/commits/0be6c54f725a2559d1c5fdafdda054cdc6e5959c
https://github.com/diekmann
Pull related code for select mocking tests togetherhttps://github.com/python/cpython/pull/2932/commits/250ae50704f959f000644eefbce9fa3110111f45
250ae50https://github.com/python/cpython/pull/2932/commits/250ae50704f959f000644eefbce9fa3110111f45
https://github.com/diekmann
Tune PtyCopyTestshttps://github.com/python/cpython/pull/2932/commits/7ced6d8d9d4449b6ed72e573bff331d5e84b8720
7ced6d8https://github.com/python/cpython/pull/2932/commits/7ced6d8d9d4449b6ed72e573bff331d5e84b8720
https://github.com/diekmann
unify code comments in PtySpawnTestBasehttps://github.com/python/cpython/pull/2932/commits/528fc5dcc1478927cb1fda28adf649b129f60cb8
528fc5dhttps://github.com/python/cpython/pull/2932/commits/528fc5dcc1478927cb1fda28adf649b129f60cb8
https://github.com/diekmann
cosmetic changeshttps://github.com/python/cpython/pull/2932/commits/aeb65859f418a32f174174666046ae4fa8865be2
aeb6585https://github.com/python/cpython/pull/2932/commits/aeb65859f418a32f174174666046ae4fa8865be2
https://github.com/diekmann
Cleanup of terminal setup codehttps://github.com/python/cpython/pull/2932/commits/57876df00be7c1efaf1c336be428fa2f09c9e8a3
57876dfhttps://github.com/python/cpython/pull/2932/commits/57876df00be7c1efaf1c336be428fa2f09c9e8a3
https://github.com/diekmann
removed test_eof_echoctlhttps://github.com/python/cpython/pull/2932/commits/2309d69ba0bd1f50701076aaead221953789d587
2309d69https://github.com/python/cpython/pull/2932/commits/2309d69ba0bd1f50701076aaead221953789d587
https://github.com/diekmann
fixed echoing racehttps://github.com/python/cpython/pull/2932/commits/f93de8d5f32c78f0ad38eec6716618beffbf1957
f93de8dhttps://github.com/python/cpython/pull/2932/commits/f93de8d5f32c78f0ad38eec6716618beffbf1957
https://github.com/diekmann
cleaned OS X workaround commentshttps://github.com/python/cpython/pull/2932/commits/9cd94257c6d44581cf14d959f06461bef3a4b836
9cd9425https://github.com/python/cpython/pull/2932/commits/9cd94257c6d44581cf14d959f06461bef3a4b836
https://github.com/diekmann
Removed doc string from test methods.https://github.com/python/cpython/pull/2932/commits/a7e47537f3402077a1c0d402e7d93afce5eb1937
a7e4753https://github.com/python/cpython/pull/2932/commits/a7e47537f3402077a1c0d402e7d93afce5eb1937
https://github.com/diekmann
Fixed commenthttps://github.com/python/cpython/pull/2932/commits/59447641289db65dc817dce307ec38779e837916
5944764https://github.com/python/cpython/pull/2932/commits/59447641289db65dc817dce307ec38779e837916
https://github.com/diekmann
[CONTRIBUTING.rst] Added myself to Misc/ACKShttps://github.com/python/cpython/pull/2932/commits/851c2612db4741c101e9f1305d5f5ea106d59a08
851c261https://github.com/python/cpython/pull/2932/commits/851c2612db4741c101e9f1305d5f5ea106d59a08
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Jul 28, 2017https://github.com/python/cpython/pull/2932#issuecomment-318688511
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
bugs.python.orghttp://bugs.python.org/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
Please reload this pagehttps://github.com/python/cpython/pull/2932
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Jul 28, 2017https://github.com/python/cpython/pull/2932#event-1183745452
https://github.com/diekmann
added Chris Torek to ACKShttps://github.com/python/cpython/pull/2932/commits/5dbc2495690a98635fbb373ee345733de52a5aa4
5dbc249https://github.com/python/cpython/pull/2932/commits/5dbc2495690a98635fbb373ee345733de52a5aa4
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Jul 28, 2017https://github.com/python/cpython/pull/2932#event-1183755785
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
needs rebase https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20rebase%22
needs rebase https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20rebase%22
Oct 9, 2017https://github.com/python/cpython/pull/2932#event-1283396427
https://github.com/vadmium
vadmiumhttps://github.com/vadmium
Oct 29, 2017 https://github.com/python/cpython/pull/2932#ref-pullrequest-269419113
bpo-26228: pty.spawn hangs on FreeBSD, OS X, and Solaris #4167 https://github.com/python/cpython/pull/4167
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Oct 29, 2017https://github.com/python/cpython/pull/2932#issuecomment-340309966
#3808https://github.com/python/cpython/pull/3808
#4167https://github.com/python/cpython/pull/4167
Please reload this pagehttps://github.com/python/cpython/pull/2932
https://github.com/diekmann
diekmannhttps://github.com/diekmann
Oct 29, 2017https://github.com/python/cpython/pull/2932#event-1315768486
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2932
Please reload this pagehttps://github.com/python/cpython/pull/2932
https://github.com/diekmann
https://github.com/the-knights-who-say-ni
https://github.com/Mariatta
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.