| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:26368d7e-df58-7d90-19f1-4dca09c11cb4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C518:311995:EBFE0B:132F99E:696B083A |
| html-safe-nonce | f3c8402b39a5a33d01ae27a9f47a69f1e73834af8cc108da2233f13da71d3f21 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTE4OjMxMTk5NTpFQkZFMEI6MTMyRjk5RTo2OTZCMDgzQSIsInZpc2l0b3JfaWQiOiIzNTc1NDc1MjE4MTU2MjkyMTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5ceb96f1642192dea8a7fbcb2731dbd3db7c0ab87e940cd6a8f5eea1bb9b4297 |
| hovercard-subject-tag | pull_request:767790146 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29251/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/32dc6dbf0927f32e3a01b347df45853a5c9f89ec08f886a12a1c6ced2e2c720a/python/cpython/pull/29251 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32dc6dbf0927f32e3a01b347df45853a5c9f89ec08f886a12a1c6ced2e2c720a/python/cpython/pull/29251 |
| og:image:alt | https://bugs.python.org/issue45634 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erlend-aasland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/29251#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29251 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29251 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/29251 |
| Reload | https://github.com/python/cpython/pull/29251 |
| Reload | https://github.com/python/cpython/pull/29251 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/29251#issue-comment-box |
| corona10 | https://github.com/corona10 |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:sqlite-fix-add-ints | https://github.com/erlend-aasland/cpython/tree/sqlite-fix-add-ints |
|
bpo-45634: Don't combine error checks when adding sqlite3 int constants
| https://github.com/python/cpython/pull/29251#top |
| corona10 | https://github.com/corona10 |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:sqlite-fix-add-ints | https://github.com/erlend-aasland/cpython/tree/sqlite-fix-add-ints |
|
Conversation
9
| https://github.com/python/cpython/pull/29251 |
|
Commits
3
| https://github.com/python/cpython/pull/29251/commits |
|
Checks
0
| https://github.com/python/cpython/pull/29251/checks |
|
Files changed
| https://github.com/python/cpython/pull/29251/files |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Oct 27, 2021 | https://github.com/python/cpython/pull/29251#issue-1037861631 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://bugs.python.org/issue45634 | https://bugs.python.org/issue45634 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| bpo-45634: Don't combine error checks when adding sqlite3 int constants | https://github.com/python/cpython/pull/29251/commits/022cf3cda0485ab8bf45a5a46da357fd082e0eb9 |
| 022cf3c | https://github.com/python/cpython/pull/29251/commits/022cf3cda0485ab8bf45a5a46da357fd082e0eb9 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| berkerpeksag | https://github.com/berkerpeksag |
| code owner | https://github.com/python/cpython/blob/35e1ff38ee67ee543d9fcb268c3552c5397f9b3f/.github/CODEOWNERS#L99 |
| October 27, 2021 21:05 | https://github.com/python/cpython/pull/29251#event-5530155654 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Oct 27, 2021 | https://github.com/python/cpython/pull/29251#event-5530155816 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 27, 2021 | https://github.com/python/cpython/pull/29251#event-5530155974 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| corona10 | https://github.com/corona10 |
| October 27, 2021 21:05 | https://github.com/python/cpython/pull/29251#event-5530156297 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Oct 27, 2021 | https://github.com/python/cpython/pull/29251#event-5530156763 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Oct 27, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-953311437 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.com/gareth-rees |
| gareth-rees | https://github.com/gareth-rees |
|
Oct 28, 2021
| https://github.com/python/cpython/pull/29251#pullrequestreview-791924559 |
|
View reviewed changes
| https://github.com/python/cpython/pull/29251/files/022cf3cda0485ab8bf45a5a46da357fd082e0eb9 |
| Modules/_sqlite/module.c | https://github.com/python/cpython/pull/29251/files/022cf3cda0485ab8bf45a5a46da357fd082e0eb9#diff-6cfed746161998667a9ea0e65596ab18dc519c5f12476b29759f2fc7de22bd34 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| Address review: skip jump, just return | https://github.com/python/cpython/pull/29251/commits/982f3a3ec3654e727d5e4fc9d57ff0c1d63a1c2d |
| 982f3a3 | https://github.com/python/cpython/pull/29251/commits/982f3a3ec3654e727d5e4fc9d57ff0c1d63a1c2d |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| ambv | https://github.com/ambv |
| October 28, 2021 21:15 | https://github.com/python/cpython/pull/29251#event-5536826572 |
| Sync with main to trigger CI again | https://github.com/python/cpython/pull/29251/commits/5082b814577dc51987cd80a3bb6f6d2a53e88d13 |
| 5082b81 | https://github.com/python/cpython/pull/29251/commits/5082b814577dc51987cd80a3bb6f6d2a53e88d13 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Oct 29, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-954648293 |
| GH-28463 | https://github.com/python/cpython/pull/28463 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
|
Oct 31, 2021
| https://github.com/python/cpython/pull/29251#pullrequestreview-793687902 |
|
View reviewed changes
| https://github.com/python/cpython/pull/29251/files/5082b814577dc51987cd80a3bb6f6d2a53e88d13 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#event-5544985348 |
| https://github.com/corona10 |
| corona10 | https://github.com/corona10 |
| 39b4d59 | https://github.com/python/cpython/commit/39b4d5938ce781af41f8c9da72dee46095a78642 |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#event-5544988604 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-955670319 |
| @erlend-aasland | https://github.com/erlend-aasland |
| @corona10 | https://github.com/corona10 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#event-5544988643 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-955670323 |
| @erlend-aasland | https://github.com/erlend-aasland |
| @corona10 | https://github.com/corona10 |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| corona10 | https://github.com/corona10 |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#event-5544988720 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| October 31, 2021 10:15 | https://github.com/python/cpython/pull/29251#event-5545002075 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-955673383 |
| @corona10 | https://github.com/corona10 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| erlend-aasland | https://github.com/erlend-aasland |
|
Oct 31, 2021
| https://github.com/python/cpython/pull/29251#ref-commit-0d24c76 |
| [3.10] bpo-45634: Don't combine error checks when adding sqlite3 in… | https://github.com/erlend-aasland/cpython/commit/0d24c76f14f5a857e53bbd4d1918b04efff4c24e |
| 0d24c76 | https://github.com/erlend-aasland/cpython/commit/0d24c76f14f5a857e53bbd4d1918b04efff4c24e |
| pythonGH-29251 | https://github.com/python/cpython/pull/29251 |
| 39b4d59 | https://github.com/erlend-aasland/cpython/commit/39b4d5938ce781af41f8c9da72dee46095a78642 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#issuecomment-955674965 |
| GH-29343 | https://github.com/python/cpython/pull/29343 |
| 3.10 branch | https://github.com/python/cpython/tree/3.10 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
| Oct 31, 2021 | https://github.com/python/cpython/pull/29251#event-5545020601 |
| corona10 | https://github.com/corona10 |
|
Oct 31, 2021
| https://github.com/python/cpython/pull/29251#ref-commit-ed91f95 |
| [3.10] | https://github.com/python/cpython/commit/ed91f959b032951620f32bcd93ff27223699a86a |
| bpo-45634 | https://bugs.python.org/issue?@action=redirect&bpo=45634 |
| : Don't combine error checks when adding | https://github.com/python/cpython/commit/ed91f959b032951620f32bcd93ff27223699a86a |
| sqlite3 | https://github.com/python/cpython/commit/ed91f959b032951620f32bcd93ff27223699a86a |
| in… | https://github.com/python/cpython/commit/ed91f959b032951620f32bcd93ff27223699a86a |
| ed91f95 | https://github.com/python/cpython/commit/ed91f959b032951620f32bcd93ff27223699a86a |
| GH-29251 | https://github.com/python/cpython/pull/29251 |
| GH-29343 | https://github.com/python/cpython/pull/29343 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
May 16, 2022
| https://github.com/python/cpython/pull/29251#ref-issue-1199068139 |
|
[sqlite3] don't combine error checks when adding integer constants
#89797
| https://github.com/python/cpython/issues/89797 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29251 |
|
| https://github.com/corona10 |
|
corona10
| https://github.com/corona10 |
|
| https://github.com/python/cpython/pull/29251/files/5082b814577dc51987cd80a3bb6f6d2a53e88d13 |
|
| https://github.com/berkerpeksag |
|
berkerpeksag
| https://github.com/berkerpeksag |
|
| https://github.com/ambv |
|
ambv
| https://github.com/ambv |
|
| https://github.com/gareth-rees |
|
gareth-rees
| https://github.com/gareth-rees |
|
| https://github.com/python/cpython/pull/29251/files/022cf3cda0485ab8bf45a5a46da357fd082e0eb9 |
|
| https://github.com/corona10 |
|
corona10
| https://github.com/corona10 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/29251 |
|
| https://github.com/erlend-aasland |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/gareth-rees |
|
| https://github.com/corona10 |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |