René's URL Explorer Experiment


Title: bpo-45438: format of inspect.Signature with generic builtins by martinitus · Pull Request #29212 · python/cpython · GitHub

Open Graph Title: bpo-45438: format of inspect.Signature with generic builtins by martinitus · Pull Request #29212 · python/cpython

X Title: bpo-45438: format of inspect.Signature with generic builtins by martinitus · Pull Request #29212 · python/cpython

Description: Use isinstance(annotation,types.GenericAlias) in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Add test case for generic sign...

Open Graph Description: Use isinstance(annotation,types.GenericAlias) in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Add test case for generic sign...

X Description: Use isinstance(annotation,types.GenericAlias) in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Add test case for generic sign...

Opengraph URL: https://github.com/python/cpython/pull/29212

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a4b5ee8d-105e-2a27-d55e-d0836820c284
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8368:178041:26E6707:350DD16:696ACBB1
html-safe-nonce4de66da029b8fc6423d30aded7e66740b05b46557305c3c92ec4d222b3643875
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzY4OjE3ODA0MToyNkU2NzA3OjM1MEREMTY6Njk2QUNCQjEiLCJ2aXNpdG9yX2lkIjoiNjczMjI3NDQ4ODQ5OTE2MjAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8aeb4b98349984f3b551fc0fb041f565af22d345ba71eaf965851b14d1263d1c
hovercard-subject-tagpull_request:765525040
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8342c65b49ff2b6698bdde6a412efac6d4a444c915108227868b3b0cbf2ffa98/python/cpython/pull/29212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8342c65b49ff2b6698bdde6a412efac6d4a444c915108227868b3b0cbf2ffa98/python/cpython/pull/29212
og:image:altUse isinstance(annotation,types.GenericAlias) in inspect.formatannotation to correctly add type arguments of builtin types to the string representation of Signatures. Add test case for generic sign...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemartinitus
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/29212#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29212
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29212
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/29212
Reloadhttps://github.com/python/cpython/pull/29212
Reloadhttps://github.com/python/cpython/pull/29212
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/29212
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/29212
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/29212#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
bpo-45438: format of inspect.Signature with generic builtins https://github.com/python/cpython/pull/29212#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
Conversation 8 https://github.com/python/cpython/pull/29212
Commits 2 https://github.com/python/cpython/pull/29212/commits
Checks 0 https://github.com/python/cpython/pull/29212/checks
Files changed https://github.com/python/cpython/pull/29212/files
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/martinitus
martinitushttps://github.com/martinitus
Oct 25, 2021https://github.com/python/cpython/pull/29212#issue-1035201305
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://bugs.python.org/issue45438https://bugs.python.org/issue45438
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/MRuecklCC
bpo-45438https://bugs.python.org/issue?@action=redirect&bpo=45438
: format of inspect.Signature with generic builtinshttps://github.com/python/cpython/pull/29212/commits/80a3f0ecc335b9b750d71044a3daae5c1986017a
80a3f0ehttps://github.com/python/cpython/pull/29212/commits/80a3f0ecc335b9b750d71044a3daae5c1986017a
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 25, 2021https://github.com/python/cpython/pull/29212#event-5514004690
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Oct 25, 2021https://github.com/python/cpython/pull/29212#event-5514004771
https://github.com/the-knights-who-say-ni
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29212
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Oct 25, 2021https://github.com/python/cpython/pull/29212#event-5514881814
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Oct 26, 2021https://github.com/python/cpython/pull/29212#event-5521639086
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 26, 2021 https://github.com/python/cpython/pull/29212#pullrequestreview-789591218
View reviewed changes https://github.com/python/cpython/pull/29212/files/80a3f0ecc335b9b750d71044a3daae5c1986017a
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 26, 2021https://github.com/python/cpython/pull/29212#event-5521641616
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 26, 2021https://github.com/python/cpython/pull/29212#issuecomment-952286267
@martinitushttps://github.com/martinitus
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/MRuecklCC
bpo-45438https://bugs.python.org/issue?@action=redirect&bpo=45438
: add news entryhttps://github.com/python/cpython/pull/29212/commits/f976f10a9e8b1c03bc2e96b7a22e24a9e9a361e9
f976f10https://github.com/python/cpython/pull/29212/commits/f976f10a9e8b1c03bc2e96b7a22e24a9e9a361e9
https://github.com/martinitus
martinitushttps://github.com/martinitus
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-952664035
Please reload this pagehttps://github.com/python/cpython/pull/29212
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-952987932
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
d02ffd1https://github.com/python/cpython/commit/d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899
Oct 27, 2021https://github.com/python/cpython/pull/29212#event-5530285205
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-953330260
@martinitushttps://github.com/martinitus
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 27, 2021https://github.com/python/cpython/pull/29212#event-5530285378
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-953330264
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/29212
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2021 https://github.com/python/cpython/pull/29212#ref-commit-de555cb
https://github.com/martinitus
https://github.com/miss-islington
bpo-45438: format of inspect.Signature with generic builtins (https://github.com/miss-islington/cpython/commit/de555cbd028b1b54229a3b35277e34a8d489406c
pythonG…https://github.com/python/cpython/pull/29212
de555cbhttps://github.com/miss-islington/cpython/commit/de555cbd028b1b54229a3b35277e34a8d489406c
…H-29212https://github.com/python/cpython/pull/29212
d02ffd1https://github.com/miss-islington/cpython/commit/d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-953330353
GH-29253https://github.com/python/cpython/pull/29253
3.10 branchhttps://github.com/python/cpython/tree/3.10
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Oct 27, 2021https://github.com/python/cpython/pull/29212#event-5530285924
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2021 https://github.com/python/cpython/pull/29212#ref-commit-4fda2ec
https://github.com/martinitus
https://github.com/miss-islington
bpo-45438: format of inspect.Signature with generic builtins (https://github.com/miss-islington/cpython/commit/4fda2eccc57b2bceb8beeb3ad163c75b68a5ef91
pythonG…https://github.com/python/cpython/pull/29212
4fda2echttps://github.com/miss-islington/cpython/commit/4fda2eccc57b2bceb8beeb3ad163c75b68a5ef91
…H-29212https://github.com/python/cpython/pull/29212
d02ffd1https://github.com/miss-islington/cpython/commit/d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 27, 2021https://github.com/python/cpython/pull/29212#issuecomment-953330394
GH-29254https://github.com/python/cpython/pull/29254
3.9 branchhttps://github.com/python/cpython/tree/3.9
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Oct 27, 2021https://github.com/python/cpython/pull/29212#event-5530286161
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2021 https://github.com/python/cpython/pull/29212#ref-commit-ce7a6af
https://github.com/miss-islington
https://github.com/martinitus
bpo-45438https://bugs.python.org/issue?@action=redirect&bpo=45438
: format of inspect.Signature with generic builtins (https://github.com/python/cpython/commit/ce7a6afb797d2ffde45e9e902516b8437c8f9e31
GH-29212https://github.com/python/cpython/pull/29212
)https://github.com/python/cpython/commit/ce7a6afb797d2ffde45e9e902516b8437c8f9e31
ce7a6afhttps://github.com/python/cpython/commit/ce7a6afb797d2ffde45e9e902516b8437c8f9e31
d02ffd1https://github.com/python/cpython/commit/d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899
miss-islingtonhttps://github.com/miss-islington
Oct 27, 2021 https://github.com/python/cpython/pull/29212#ref-commit-21150c6
https://github.com/miss-islington
https://github.com/martinitus
bpo-45438https://bugs.python.org/issue?@action=redirect&bpo=45438
: format of inspect.Signature with generic builtins (https://github.com/python/cpython/commit/21150c6fa330f80747d698e4b883c7b4801a25bd
GH-29212https://github.com/python/cpython/pull/29212
)https://github.com/python/cpython/commit/21150c6fa330f80747d698e4b883c7b4801a25bd
21150c6https://github.com/python/cpython/commit/21150c6fa330f80747d698e4b883c7b4801a25bd
d02ffd1https://github.com/python/cpython/commit/d02ffd1b5c0fd8dec6dd2f7e3f2b0cfae48b7899
https://github.com/martinitus
martinitushttps://github.com/martinitus
November 1, 2021 10:04https://github.com/python/cpython/pull/29212#event-5547880867
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Oct 18, 2022 https://github.com/python/cpython/pull/29212#ref-issue-1199066858
inspect not capturing type annotations created by __class_getitem__ #89601 https://github.com/python/cpython/issues/89601
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29212
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/29212/files/80a3f0ecc335b9b750d71044a3daae5c1986017a
Please reload this pagehttps://github.com/python/cpython/pull/29212
https://github.com/martinitus
https://github.com/the-knights-who-say-ni
https://github.com/gvanrossum
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/MRuecklCC
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.