| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a063be7f-5dee-1005-01c2-bedcbbb7ad2a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 941C:1EFC6:1F92D72:2B2B071:696AC4B1 |
| html-safe-nonce | 3618faf50313942fb1019ee40f6424074d2724f197f1ed69891938cf7d297e56 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDFDOjFFRkM2OjFGOTJENzI6MkIyQjA3MTo2OTZBQzRCMSIsInZpc2l0b3JfaWQiOiI3NjQ2NTA1NjgxMDA2ODA2MTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d1e2bb96823e6e11fd6a41335ba7dd9ad3ed11d610f566760e7ba43d9d58a2f5 |
| hovercard-subject-tag | pull_request:764201718 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29161/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f98e187f5bcdfc0ae26fbd5b340274e34d0d0a333421cc2e73e800959befc542/python/cpython/pull/29161 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f98e187f5bcdfc0ae26fbd5b340274e34d0d0a333421cc2e73e800959befc542/python/cpython/pull/29161 |
| og:image:alt | Modules/Setup now use PY_CFLAGS_NODIST instead of PY_CFLAGS to
compile shared modules.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45571 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tiran |
| hostname | github.com |
| expected-hostname | github.com |
| None | 986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/29161#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29161 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29161 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/29161 |
| Reload | https://github.com/python/cpython/pull/29161 |
| Reload | https://github.com/python/cpython/pull/29161 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/29161#issue-comment-box |
| tiran | https://github.com/tiran |
| python:main | https://github.com/python/cpython/tree/main |
| tiran:bpo-45571-makesetup | https://github.com/tiran/cpython/tree/bpo-45571-makesetup |
|
bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
| https://github.com/python/cpython/pull/29161#top |
| tiran | https://github.com/tiran |
| python:main | https://github.com/python/cpython/tree/main |
| tiran:bpo-45571-makesetup | https://github.com/tiran/cpython/tree/bpo-45571-makesetup |
|
Conversation
5
| https://github.com/python/cpython/pull/29161 |
|
Commits
1
| https://github.com/python/cpython/pull/29161/commits |
|
Checks
0
| https://github.com/python/cpython/pull/29161/checks |
|
Files changed
| https://github.com/python/cpython/pull/29161/files |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#issue-1033586225 |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
| https://bugs.python.org/issue45571 | https://bugs.python.org/issue45571 |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
|
| https://github.com/tiran |
| bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup | https://github.com/python/cpython/pull/29161/commits/f20210dc724dc871c422a7be9e8bb846de56e2dd |
| f20210d | https://github.com/python/cpython/pull/29161/commits/f20210dc724dc871c422a7be9e8bb846de56e2dd |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
|
needs backport to 3.9
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22 |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5504910968 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Yhg1s | https://github.com/Yhg1s |
| brettcannon | https://github.com/brettcannon |
| October 22, 2021 13:30 | https://github.com/python/cpython/pull/29161#event-5504910982 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5504911260 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5504911297 |
| https://github.com/brettcannon |
| brettcannon | https://github.com/brettcannon |
|
Oct 22, 2021
| https://github.com/python/cpython/pull/29161#pullrequestreview-787127776 |
|
View reviewed changes
| https://github.com/python/cpython/pull/29161/files/f20210dc724dc871c422a7be9e8bb846de56e2dd |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5506366046 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5506406885 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| f6e8b80 | https://github.com/python/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5506406934 |
| https://github.com/tiran |
| tiran | https://github.com/tiran |
| October 22, 2021 18:02 | https://github.com/python/cpython/pull/29161#event-5506407082 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#issuecomment-949852323 |
| @tiran | https://github.com/tiran |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5506407141 |
| miss-islington | https://github.com/miss-islington |
|
Oct 22, 2021
| https://github.com/python/cpython/pull/29161#ref-commit-41a33b0 |
|
| https://github.com/tiran |
|
| https://github.com/miss-islington |
| bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup ( | https://github.com/miss-islington/cpython/commit/41a33b0f7200ca3554a96d2f5684a82a73176e0f |
| pythonGH-29161 | https://github.com/python/cpython/pull/29161 |
| 41a33b0 | https://github.com/miss-islington/cpython/commit/41a33b0f7200ca3554a96d2f5684a82a73176e0f |
| https://github.com/python/cpython/pull/29161 |
| f6e8b80 | https://github.com/miss-islington/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#issuecomment-949852452 |
| GH-29168 | https://github.com/python/cpython/pull/29168 |
| 3.10 branch | https://github.com/python/cpython/tree/3.10 |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.10
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22 |
|
needs backport to 3.9
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22 |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#event-5506407883 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Oct 22, 2021 | https://github.com/python/cpython/pull/29161#issuecomment-949852506 |
| GH-29169 | https://github.com/python/cpython/pull/29169 |
| 3.9 branch | https://github.com/python/cpython/tree/3.9 |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
| miss-islington | https://github.com/miss-islington |
|
Oct 22, 2021
| https://github.com/python/cpython/pull/29161#ref-commit-9a44cc5 |
|
| https://github.com/tiran |
|
| https://github.com/miss-islington |
| bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup ( | https://github.com/miss-islington/cpython/commit/9a44cc5bc87995a5762dec24b3e6248fd62dc3f1 |
| pythonGH-29161 | https://github.com/python/cpython/pull/29161 |
| 9a44cc5 | https://github.com/miss-islington/cpython/commit/9a44cc5bc87995a5762dec24b3e6248fd62dc3f1 |
| https://github.com/python/cpython/pull/29161 |
| f6e8b80 | https://github.com/miss-islington/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
| miss-islington | https://github.com/miss-islington |
|
Oct 22, 2021
| https://github.com/python/cpython/pull/29161#ref-commit-1990308 |
|
| https://github.com/miss-islington |
|
| https://github.com/tiran |
| bpo-45571 | https://bugs.python.org/issue?@action=redirect&bpo=45571 |
| : use PY_CFLAGS_NODIST for shared Modules/Setup ( | https://github.com/python/cpython/commit/19903085c3ad7a17c8047e1556c700f2eb109931 |
| GH-29161 | https://github.com/python/cpython/pull/29161 |
| ) | https://github.com/python/cpython/commit/19903085c3ad7a17c8047e1556c700f2eb109931 |
| 1990308 | https://github.com/python/cpython/commit/19903085c3ad7a17c8047e1556c700f2eb109931 |
| f6e8b80 | https://github.com/python/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
| miss-islington | https://github.com/miss-islington |
|
Oct 22, 2021
| https://github.com/python/cpython/pull/29161#ref-commit-269bf56 |
|
| https://github.com/miss-islington |
|
| https://github.com/tiran |
| bpo-45571 | https://bugs.python.org/issue?@action=redirect&bpo=45571 |
| : use PY_CFLAGS_NODIST for shared Modules/Setup ( | https://github.com/python/cpython/commit/269bf56e3d352c415ec38f93017ba8e291ddb18a |
| GH-29161 | https://github.com/python/cpython/pull/29161 |
| ) | https://github.com/python/cpython/commit/269bf56e3d352c415ec38f93017ba8e291ddb18a |
| 269bf56 | https://github.com/python/cpython/commit/269bf56e3d352c415ec38f93017ba8e291ddb18a |
| f6e8b80 | https://github.com/python/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
| https://github.com/psphilippe |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29161 |
| https://github.com/psphilippe |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29161 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29161 |
|
| https://github.com/brettcannon |
|
brettcannon
| https://github.com/brettcannon |
|
| https://github.com/python/cpython/pull/29161/files/f20210dc724dc871c422a7be9e8bb846de56e2dd |
|
| https://github.com/Yhg1s |
|
Yhg1s
| https://github.com/Yhg1s |
|
type-bug
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug |
| Please reload this page | https://github.com/python/cpython/pull/29161 |
|
| https://github.com/tiran |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/psphilippe |
|
| https://github.com/brettcannon |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |