René's URL Explorer Experiment


Title: bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) by tiran · Pull Request #29157 · python/cpython · GitHub

Open Graph Title: bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) by tiran · Pull Request #29157 · python/cpython

X Title: bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) by tiran · Pull Request #29157 · python/cpython

Description: setup.py no longer defines Py_BUILD_CORE_MODULE. Instead every module defines the macro before #include "Python.h" unless Py_BUILD_CORE_BUILTIN is already defined. Py_BUILD_CORE_BUILTIN is defined ...

Open Graph Description: setup.py no longer defines Py_BUILD_CORE_MODULE. Instead every module defines the macro before #include "Python.h" unless Py_BUILD_CORE_BUILTIN is already defined. Py_BUILD_CORE_BUILTIN i...

X Description: setup.py no longer defines Py_BUILD_CORE_MODULE. Instead every module defines the macro before #include "Python.h" unless Py_BUILD_CORE_BUILTIN is already defined. Py_BUILD_CORE_B...

Mail addresses
christian@python.org

Opengraph URL: https://github.com/python/cpython/pull/29157

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0be26b36-6147-194e-9aae-feefa4794543
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAD6:2C2C4D:1A0486:245E4E:696A6F0C
html-safe-nonce427c88d72fe4c6ed348e0c840a3398d5fe77d53223cdda1f3fc35a372646951c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUQ2OjJDMkM0RDoxQTA0ODY6MjQ1RTRFOjY5NkE2RjBDIiwidmlzaXRvcl9pZCI6IjU5NzY4MTg4NjgzMzgzMTY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbe9130528e76a530829a20ef58e6782fb2c3217f99c670e69a6df7e036f1cb96
hovercard-subject-tagpull_request:764137326
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29157/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/549e3254c2a9e9b34c97ae7064c6d572d6c64885a742b7093a2f8b711f193f93/python/cpython/pull/29157
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/549e3254c2a9e9b34c97ae7064c6d572d6c64885a742b7093a2f8b711f193f93/python/cpython/pull/29157
og:image:altsetup.py no longer defines Py_BUILD_CORE_MODULE. Instead every module defines the macro before #include "Python.h" unless Py_BUILD_CORE_BUILTIN is already defined. Py_BUILD_CORE_BUILTIN i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametiran
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/29157#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29157
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29157
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/29157
Reloadhttps://github.com/python/cpython/pull/29157
Reloadhttps://github.com/python/cpython/pull/29157
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/29157
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/29157
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/29157#issue-comment-box
tiranhttps://github.com/tiran
python:mainhttps://github.com/python/cpython/tree/main
tiran:bpo-43974-2https://github.com/tiran/cpython/tree/bpo-43974-2
bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) https://github.com/python/cpython/pull/29157#top
tiranhttps://github.com/tiran
python:mainhttps://github.com/python/cpython/tree/main
tiran:bpo-43974-2https://github.com/tiran/cpython/tree/bpo-43974-2
Conversation 5 https://github.com/python/cpython/pull/29157
Commits 5 https://github.com/python/cpython/pull/29157/commits
Checks 0 https://github.com/python/cpython/pull/29157/checks
Files changed https://github.com/python/cpython/pull/29157/files
Please reload this pagehttps://github.com/python/cpython/pull/29157
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/tiran
tiranhttps://github.com/tiran
Oct 22, 2021https://github.com/python/cpython/pull/29157#issue-1033510555
Please reload this pagehttps://github.com/python/cpython/pull/29157
https://bugs.python.org/issue43974https://bugs.python.org/issue43974
Please reload this pagehttps://github.com/python/cpython/pull/29157
tiranhttps://github.com/tiran
October 22, 2021 14:00https://github.com/python/cpython/pull/29157#commits-pushed-51be18e
https://github.com/tiran
bpo-43974: Move Py_BUILD_CORE_MODULE into module codehttps://github.com/python/cpython/pull/29157/commits/51be18e36254c7fde29f7407d00f61522f3dc60c
51be18ehttps://github.com/python/cpython/pull/29157/commits/51be18e36254c7fde29f7407d00f61522f3dc60c
https://github.com/tiran
PCbuild: Dont' define Py_BUILD_CORE_MODULEhttps://github.com/python/cpython/pull/29157/commits/d47314ac4a463785bef299ed9335914eedfa013b
d47314ahttps://github.com/python/cpython/pull/29157/commits/d47314ac4a463785bef299ed9335914eedfa013b
https://github.com/tiran
Simplify Modules/Setuphttps://github.com/python/cpython/pull/29157/commits/80561b5f750d2b5d22e483aca3c244c156fbd942
80561b5https://github.com/python/cpython/pull/29157/commits/80561b5f750d2b5d22e483aca3c244c156fbd942
https://github.com/tiran
tiranhttps://github.com/tiran
brettcannonhttps://github.com/brettcannon
vstinnerhttps://github.com/vstinner
October 22, 2021 12:07https://github.com/python/cpython/pull/29157#event-5504459486
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504459708
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504459734
https://github.com/tiran
tiranhttps://github.com/tiran
Oct 22, 2021 https://github.com/python/cpython/pull/29157#ref-pullrequest-870788918
bpo-43974: Set Py_BUILD_CORE_MODULE for all core modules #25713 https://github.com/python/cpython/pull/25713
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 22, 2021 https://github.com/python/cpython/pull/29157#pullrequestreview-786765403
View reviewed changes https://github.com/python/cpython/pull/29157/files/80561b5f750d2b5d22e483aca3c244c156fbd942
Modules/_blake2/blake2b_impl.chttps://github.com/python/cpython/pull/29157/files/80561b5f750d2b5d22e483aca3c244c156fbd942#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
Please reload this pagehttps://github.com/python/cpython/pull/29157
tiranhttps://github.com/tiran
October 22, 2021 14:10https://github.com/python/cpython/pull/29157#commits-pushed-2783161
https://github.com/tiran
Victor prefers a different stylehttps://github.com/python/cpython/pull/29157/commits/27831617b4d6e8e525fc753a71fbf567eb3f05e3
2783161https://github.com/python/cpython/pull/29157/commits/27831617b4d6e8e525fc753a71fbf567eb3f05e3
https://github.com/tiran
_abc also requires Py_BUILD_COREhttps://github.com/python/cpython/pull/29157/commits/2b5f23a63defd7c22f39fa6518f509fab526c635
2b5f23ahttps://github.com/python/cpython/pull/29157/commits/2b5f23a63defd7c22f39fa6518f509fab526c635
https://github.com/tiran
tiranhttps://github.com/tiran
October 22, 2021 12:50https://github.com/python/cpython/pull/29157#event-5504681869
https://github.com/tiran
tiranhttps://github.com/tiran
1st1https://github.com/1st1
abalkinhttps://github.com/abalkin
asvetlovhttps://github.com/asvetlov
gpsheadhttps://github.com/gpshead
pgansslehttps://github.com/pganssle
rhettingerhttps://github.com/rhettinger
code ownershttps://github.com/python/cpython/blob/86dfb55d2e091cf633dbd7aabcd49d96fb1f9d81/.github/CODEOWNERS#L108
October 22, 2021 12:50https://github.com/python/cpython/pull/29157#event-5504681916
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 22, 2021 https://github.com/python/cpython/pull/29157#pullrequestreview-786823004
View reviewed changes https://github.com/python/cpython/pull/29157/files/2b5f23a63defd7c22f39fa6518f509fab526c635
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/29157#pullrequestreview-786823004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29157
Misc/NEWS.d/next/Build/2021-10-22-14-00-44.bpo-43974.HHZtbx.rsthttps://github.com/python/cpython/pull/29157/files/2b5f23a63defd7c22f39fa6518f509fab526c635#diff-a7dab8419699f2a8331c3d9d88e42be72ed39f9248e1231768907f07aa8d8ed3
vstinnerhttps://github.com/vstinner
Oct 22, 2021https://github.com/python/cpython/pull/29157#discussion_r734524142
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/29157
tiranhttps://github.com/tiran
Oct 22, 2021https://github.com/python/cpython/pull/29157#discussion_r734547495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://bugs.python.org/issue45571https://bugs.python.org/issue45571
Please reload this pagehttps://github.com/python/cpython/pull/29157
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504771018
https://github.com/tiran
tiranhttps://github.com/tiran
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504947097
https://github.com/tiran
tiranhttps://github.com/tiran
03e9f5dhttps://github.com/python/cpython/commit/03e9f5dc751b8c441a85f428abc3f432ffe46345
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504947145
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 22, 2021https://github.com/python/cpython/pull/29157#event-5504947377
https://github.com/tiran
tiranhttps://github.com/tiran
October 22, 2021 13:36https://github.com/python/cpython/pull/29157#event-5504947385
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29157
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/29157/files/2b5f23a63defd7c22f39fa6518f509fab526c635
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/abalkin
abalkin https://github.com/abalkin
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/pganssle
pganssle https://github.com/pganssle
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/29157
https://github.com/tiran
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.