| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f38417c3-017f-a2aa-52c2-cf767ed5af7f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C71E:D7E2A:26D4F30:342395C:6992EEDC |
| html-safe-nonce | 8633d148b69d6bd619d0b271d7134b0641948c9ee4f707b5bfc884cc45ff1704 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzFFOkQ3RTJBOjI2RDRGMzA6MzQyMzk1Qzo2OTkyRUVEQyIsInZpc2l0b3JfaWQiOiI1OTQyMTQ2MTc0MTQ4NjAzNjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 012e71f936e9b79f6b3b2417350e76bcbd60d7babd4cfe45e717330a1fb8bb77 |
| hovercard-subject-tag | pull_request:761654585 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/29063/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d566af158c3276c58fbf7fd88a5806e30d9c7ea52b919a16c1747e6839c5d7e3/python/cpython/pull/29063 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d566af158c3276c58fbf7fd88a5806e30d9c7ea52b919a16c1747e6839c5d7e3/python/cpython/pull/29063 |
| og:image:alt | In gh-28954 I adjusted how test_embed determines if it should be skipped. That broke out-of-tree builds. This change fixes them.
https://bugs.python.org/issue45506 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericsnowcurrently |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01ab16879a3159e6f0717ab948b9b562e162a6aafd1f4393b786b07b747df244 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b1570f3928bef80fa5fc7890ce0942e9b696ad9d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/29063#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29063 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29063 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/29063 |
| Reload | https://github.com/python/cpython/pull/29063 |
| Reload | https://github.com/python/cpython/pull/29063 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/29063 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.5k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| python:main | https://github.com/python/cpython/tree/main |
| ericsnowcurrently:fix-test_embed-out-of-tree | https://github.com/ericsnowcurrently/cpython/tree/fix-test_embed-out-of-tree |
| Conversation | https://github.com/python/cpython/pull/29063 |
| Commits1 (1) | https://github.com/python/cpython/pull/29063/commits |
| Checks | https://github.com/python/cpython/pull/29063/checks |
| Files changed | https://github.com/python/cpython/pull/29063/files |
| bpo-45506: Go back to not running most of test_embed in out-of-tree builds. | https://github.com/python/cpython/pull/29063#top |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| python:main | https://github.com/python/cpython/tree/main |
| ericsnowcurrently:fix-test_embed-out-of-tree | https://github.com/ericsnowcurrently/cpython/tree/fix-test_embed-out-of-tree |
|
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#issue-1030580184 |
| Please reload this page | https://github.com/python/cpython/pull/29063 |
| gh-28954 | https://github.com/python/cpython/pull/28954 |
| https://bugs.python.org/issue45506 | https://bugs.python.org/issue45506 |
| Please reload this page | https://github.com/python/cpython/pull/29063 |
|
| https://github.com/ericsnowcurrently |
| Go back to not running most of test_embed in out-of-tree builds. | https://github.com/python/cpython/pull/29063/commits/c2989f3ad71a3c72dd499ce07683659abd35fb42 |
| c2989f3 | https://github.com/python/cpython/pull/29063/commits/c2989f3ad71a3c72dd499ce07683659abd35fb42 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5486955757 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5486955956 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5486955976 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5486956049 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| f4b1244 | https://github.com/python/cpython/commit/f4b12440cf24d7636755aac5b2645e47713557c7 |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5487688097 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Oct 19, 2021 | https://github.com/python/cpython/pull/29063#event-5487688287 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| October 19, 2021 20:11 | https://github.com/python/cpython/pull/29063#event-5487688408 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
Oct 28, 2021
| https://github.com/python/cpython/pull/29063#ref-pullrequest-1038957250 |
|
bpo-45506: Re-enable test_embed.
#29300
| https://github.com/python/cpython/pull/29300 |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
Nov 3, 2021
| https://github.com/python/cpython/pull/29063#ref-commit-7b43828 |
|
| https://github.com/ericsnowcurrently |
| bpo-45506 | https://bugs.python.org/issue?@action=redirect&bpo=45506 |
| : Stop skipping test_embed. ( | https://github.com/python/cpython/commit/7b438282d39e742b2628a32e7c6699a140ff4cfb |
| gh-29300 | https://github.com/python/cpython/pull/29300 |
| ) | https://github.com/python/cpython/commit/7b438282d39e742b2628a32e7c6699a140ff4cfb |
| 7b43828 | https://github.com/python/cpython/commit/7b438282d39e742b2628a32e7c6699a140ff4cfb |
| gh-29063 | https://github.com/python/cpython/pull/29063 |
| https://bugs.python.org/issue45506 | https://bugs.python.org/issue45506 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F29063 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Please reload this page | https://github.com/python/cpython/pull/29063 |
|
| https://github.com/ericsnowcurrently |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |