René's URL Explorer Experiment


Title: bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c by segevfiner · Pull Request #2904 · python/cpython · GitHub

Open Graph Title: bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c by segevfiner · Pull Request #2904 · python/cpython

X Title: bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c by segevfiner · Pull Request #2904 · python/cpython

Description: A fix after #2492, I guess the values were truncated before. Tests are failing in Windows x64. I ran the test suite locally (Default flags) making sure it passes now with the correct Python version. Barring weird failure from test.test_uuid.TestInternals.test_ipconfig_getnode related to encoding, I think subprocess uses cp1255 while the console seems to be set to cp862 in my computer. Maybe Python should be deciding on the code page for use by subprocess by using GetConsoleOutputCP. Who knows if that's always the right thing to do... 😓 @zooba @Haypo https://bugs.python.org/issue9566

Open Graph Description: A fix after #2492, I guess the values were truncated before. Tests are failing in Windows x64. I ran the test suite locally (Default flags) making sure it passes now with the correct Python version...

X Description: A fix after #2492, I guess the values were truncated before. Tests are failing in Windows x64. I ran the test suite locally (Default flags) making sure it passes now with the correct Python version...

Opengraph URL: https://github.com/python/cpython/pull/2904

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:64ad6960-dccf-ae54-05f8-f9a5edd280bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7D2:20ED06:DAC9B5:123480F:6A52AA80
html-safe-nonced03cdcc15e83eefa25159562985a9843b3e868d7cbe3d1a5879f1adf75fcb9d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0QyOjIwRUQwNjpEQUM5QjU6MTIzNDgwRjo2QTUyQUE4MCIsInZpc2l0b3JfaWQiOiI1ODI3NTE4NzU0MDcwODk5MzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac969bbecf9126633a191012ddbc2a748ce6bc8a92920c048cdc21b4f94207b71c
hovercard-subject-tagpull_request:132634995
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/2904/files
twitter:imagehttps://avatars.githubusercontent.com/u/24731903?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24731903?s=400&v=4
og:image:altA fix after #2492, I guess the values were truncated before. Tests are failing in Windows x64. I ran the test suite locally (Default flags) making sure it passes now with the correct Python version...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/2904/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2904%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2904%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/2904/files
Reloadhttps://github.com/python/cpython/pull/2904/files
Reloadhttps://github.com/python/cpython/pull/2904/files
Please reload this pagehttps://github.com/python/cpython/pull/2904/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/2904/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
segevfiner:bpo-9566-pointers-are-unsignedhttps://github.com/segevfiner/cpython/tree/bpo-9566-pointers-are-unsigned
Conversation 0 https://github.com/python/cpython/pull/2904
Commits 1 https://github.com/python/cpython/pull/2904/commits
Checks 0 https://github.com/python/cpython/pull/2904/checks
Files changed https://github.com/python/cpython/pull/2904/files
Please reload this pagehttps://github.com/python/cpython/pull/2904/files
bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c https://github.com/python/cpython/pull/2904/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/2904/files
3ca3587 bpo-9566: Change HANDLE argument parsing to unsigned in msvcrtmodule.c segevfiner Jul 26, 2017 https://github.com/python/cpython/pull/2904/commits/3ca3587d0276a3719d484975034707e024745fc6
Clear filters https://github.com/python/cpython/pull/2904/files
Please reload this pagehttps://github.com/python/cpython/pull/2904/files
Please reload this pagehttps://github.com/python/cpython/pull/2904/files
msvcrtmodule.c.h https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
msvcrtmodule.c https://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
PC/clinic/msvcrtmodule.c.hhttps://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
View file https://github.com/segevfiner/cpython/blob/3ca3587d0276a3719d484975034707e024745fc6/PC/clinic/msvcrtmodule.c.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/2904/{{ revealButtonHref }}
https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
https://github.com/python/cpython/pull/2904/files#diff-52a8383765b497209ebde00efc4b114d07fad1ed11eba00cfbffd4d6b066ee74
PC/msvcrtmodule.chttps://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
View file https://github.com/segevfiner/cpython/blob/3ca3587d0276a3719d484975034707e024745fc6/PC/msvcrtmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/2904/{{ revealButtonHref }}
https://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
https://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
https://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
https://github.com/python/cpython/pull/2904/files#diff-37e4d6387c5c3bd0f6cedfda8b8d3d9771e1233e0d9d60ca0dc7a6f081b1fa90
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.