René's URL Explorer Experiment


Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython · GitHub

Open Graph Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython

X Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython

Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consistent interface, just by inheriting from collections.abc.Mapping (as many already do), without having to add any boilerplate code of their own. From the associated original issue bpo-40890, it looks like this was never discussed or considered. Perhaps this would have been added at the same time as gh-20749 if it had been part of the original discussion. Submitting this (currently draft) 3-line PR as a starting point for further discussion. The changes in this PR already make the following code work: # demo.txt >>> from collections.abc import Mapping >>> class MyMapping(Mapping): ... def __init__(self, source: Mapping): ... self._source = source ... ... def __iter__(self): ... return iter(self._source) ... ... def __len__(self): ... return len(self._source) ... ... def __getitem__(self, key): ... return self._source[key] ... ... def __repr__(self): ... return f'{self.__class__.__name__}({self._source})' >>> d = dict(one=1, two=2) >>> d.keys().mapping mappingproxy({'one': 1, 'two': 2}) >>> m = MyMapping(d) >>> m.keys().mapping mappingproxy(MyMapping({'one': 1, 'two': 2})) $ ./python.exe -VV Python 3.11.0a1+ (heads/main-dirty:7103356455, Oct 11 2021, 17:28:12) [Clang 12.0.0 (clang-1200.0.32.29)] $ ./python.exe -m doctest demo.txt # no output + exits zero => it works If it makes sense to pursue this, I can create a proper bpo issue and put the finishing touches on this PR. Context: I noticed this while reviewing the changes in Python 3.10 to see if they called for any corresponding changes to my bidict library, which I believe is one of several libraries that would benefit from fixing this issue. /cc @rhettinger @sweeneyde et al.

Open Graph Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste...

X Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste...

Opengraph URL: https://github.com/python/cpython/pull/28892

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1769e7f9-2de7-9802-7477-f2aa90b27aab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB062:2D8191:3B5FA5:4F1E0A:6B0029B7
html-safe-nonceb09b2e85691c17ec8c3cd2d1c3ea62be6c3fdd516c6d10da611b41e60e27e83d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDYyOjJEODE5MTozQjVGQTU6NEYxRTBBOjZCMDAyOUI3IiwidmlzaXRvcl9pZCI6Ijc3NjM3MTUyMDUzOTcyMjc5NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccff185fff5a5755d8f95d02fe3e935f161e613c6579cc9699be581bb2592461a
hovercard-subject-tagpull_request:755665506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/28892/files
twitter:imagehttps://avatars.githubusercontent.com/u/64992?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/64992?s=400&v=4
og:image:altAs of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/28892/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28892%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28892%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/28892/files
Reloadhttps://github.com/python/cpython/pull/28892/files
Reloadhttps://github.com/python/cpython/pull/28892/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
jabhttps://github.com/jab
python:mainhttps://github.com/python/cpython/tree/main
jab:mappinghttps://github.com/jab/cpython/tree/mapping
Conversation 7 https://github.com/python/cpython/pull/28892
Commits 1 https://github.com/python/cpython/pull/28892/commits
Checks 0 https://github.com/python/cpython/pull/28892/checks
Files changed https://github.com/python/cpython/pull/28892/files
Please reload this pagehttps://github.com/python/cpython/pull/28892/files
Add MappingView.mapping for parity with dictview https://github.com/python/cpython/pull/28892/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/28892/files
c4d6cda Add MappingView.mapping for parity with dictview jab Oct 11, 2021 https://github.com/python/cpython/pull/28892/commits/c4d6cda96e595663acfc87b0759a4ea1ded3a01c
Clear filters https://github.com/python/cpython/pull/28892/files
Please reload this pagehttps://github.com/python/cpython/pull/28892/files
Please reload this pagehttps://github.com/python/cpython/pull/28892/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L407
Lib/_collections_abc.pyhttps://github.com/python/cpython/pull/28892/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
View file https://github.com/jab/cpython/blob/c4d6cda96e595663acfc87b0759a4ea1ded3a01c/Lib/_collections_abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/28892/{{ revealButtonHref }}
https://github.com/python/cpython/pull/28892/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
https://github.com/python/cpython/pull/28892/files#diff-2044b2b16b4875063072f171fbaa695fab71ffa10976692286bc7f5e0fb4b545
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.