Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython · GitHub
Open Graph Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython
X Title: Add MappingView.mapping for parity with dictview by jab · Pull Request #28892 · python/cpython
Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consistent interface, just by inheriting from collections.abc.Mapping (as many already do), without having to add any boilerplate code of their own. From the associated original issue bpo-40890, it looks like this was never discussed or considered. Perhaps this would have been added at the same time as gh-20749 if it had been part of the original discussion. Submitting this (currently draft) 3-line PR as a starting point for further discussion. The changes in this PR already make the following code work: # demo.txt >>> from collections.abc import Mapping >>> class MyMapping(Mapping): ... def __init__(self, source: Mapping): ... self._source = source ... ... def __iter__(self): ... return iter(self._source) ... ... def __len__(self): ... return len(self._source) ... ... def __getitem__(self, key): ... return self._source[key] ... ... def __repr__(self): ... return f'{self.__class__.__name__}({self._source})' >>> d = dict(one=1, two=2) >>> d.keys().mapping mappingproxy({'one': 1, 'two': 2}) >>> m = MyMapping(d) >>> m.keys().mapping mappingproxy(MyMapping({'one': 1, 'two': 2})) $ ./python.exe -VV Python 3.11.0a1+ (heads/main-dirty:7103356455, Oct 11 2021, 17:28:12) [Clang 12.0.0 (clang-1200.0.32.29)] $ ./python.exe -m doctest demo.txt # no output + exits zero => it works If it makes sense to pursue this, I can create a proper bpo issue and put the finishing touches on this PR. Context: I noticed this while reviewing the changes in Python 3.10 to see if they called for any corresponding changes to my bidict library, which I believe is one of several libraries that would benefit from fixing this issue. /cc @rhettinger @sweeneyde et al.
Open Graph Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste...
X Description: As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste...
Opengraph URL: https://github.com/python/cpython/pull/28892
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1769e7f9-2de7-9802-7477-f2aa90b27aab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B062:2D8191:3B5FA5:4F1E0A:6B0029B7 |
| html-safe-nonce | b09b2e85691c17ec8c3cd2d1c3ea62be6c3fdd516c6d10da611b41e60e27e83d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDYyOjJEODE5MTozQjVGQTU6NEYxRTBBOjZCMDAyOUI3IiwidmlzaXRvcl9pZCI6Ijc3NjM3MTUyMDUzOTcyMjc5NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cff185fff5a5755d8f95d02fe3e935f161e613c6579cc9699be581bb2592461a |
| hovercard-subject-tag | pull_request:755665506 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/28892/files |
| twitter:image | https://avatars.githubusercontent.com/u/64992?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/64992?s=400&v=4 |
| og:image:alt | As of gh-20749, built-in dictviews now have a mapping attribute. This PR adds the same to collections.abc.MappingView, so that non-builtin mappings can get feature parity, not to mention a consiste... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width