| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2571c31a-35ce-0291-8b0f-afed03066d28 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8846:219C24:5275D:6F874:6A532446 |
| html-safe-nonce | 4f338bca80172a10f373c739a51e0e710e03ca3a52764945538d2399c471ac06 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODQ2OjIxOUMyNDo1Mjc1RDo2Rjg3NDo2QTUzMjQ0NiIsInZpc2l0b3JfaWQiOiIxNjE1ODM5NTQ1NDc5MzQxMTI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d379502d6e05142d9b33b81e829bae3ca87e4c415f79c90c46b005e12504cb5b |
| hovercard-subject-tag | pull_request:734741672 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/28358/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bf6bf6751acd11fa7ae3e33d81123908d505816b04201493d958fcc3febdcb38/python/cpython/pull/28358 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bf6bf6751acd11fa7ae3e33d81123908d505816b04201493d958fcc3febdcb38/python/cpython/pull/28358 |
| og:image:alt | Signed-off-by: Edward Z. Yang ezyang@fb.com
https://bugs.python.org/issue45210
Issue: tp_dealloc docs should mention error indicator may be set #89373 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ezyang |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/28358#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28358 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28358 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/28358 |
| Reload | https://github.com/python/cpython/pull/28358 |
| Reload | https://github.com/python/cpython/pull/28358 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| ezyang:tp-dealloc-error-indicator | https://github.com/ezyang/cpython/tree/tp-dealloc-error-indicator |
| Conversation | https://github.com/python/cpython/pull/28358 |
| Commits9 (9) | https://github.com/python/cpython/pull/28358/commits |
| Checks | https://github.com/python/cpython/pull/28358/checks |
| Files changed | https://github.com/python/cpython/pull/28358/files |
| gh-89373: Document that error indicator may be set in tp_dealloc | https://github.com/python/cpython/pull/28358#top |
| vstinner | https://github.com/vstinner |
| python:main | https://github.com/python/cpython/tree/main |
| ezyang:tp-dealloc-error-indicator | https://github.com/ezyang/cpython/tree/tp-dealloc-error-indicator |
|
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Sep 15, 2021 | https://github.com/python/cpython/pull/28358#issue-997300033 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://bugs.python.org/issue45210 | https://bugs.python.org/issue45210 |
| tp_dealloc docs should mention error indicator may be set #89373 | https://github.com/python/cpython/issues/89373 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
| Document that error indicator may be set in tp_dealloc | https://github.com/python/cpython/pull/28358/commits/610719022f3c9d4cafc1771aede4a2538bea59db |
| 6107190 | https://github.com/python/cpython/pull/28358/commits/610719022f3c9d4cafc1771aede4a2538bea59db |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Sep 15, 2021 | https://github.com/python/cpython/pull/28358#event-5307295108 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| Sep 15, 2021 | https://github.com/python/cpython/pull/28358#issuecomment-920191507 |
| PSF contributor agreement | https://www.python.org/psf/contrib/contrib-form/ |
| bugs.python.org | https://bugs.python.org/ |
| @ezyang | https://github.com/ezyang |
| the steps outlined in the CPython devguide | https://devguide.python.org/pullrequest/#licensing |
| check yourself | https://check-python-cla.herokuapp.com/ |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
| Sep 15, 2021 | https://github.com/python/cpython/pull/28358#event-5307295282 |
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Sep 15, 2021 | https://github.com/python/cpython/pull/28358#issuecomment-920200166 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
| add blurb | https://github.com/python/cpython/pull/28358/commits/3d7a84273724b5820c0392d32c7b1fa10bcd122d |
| 3d7a842 | https://github.com/python/cpython/pull/28358/commits/3d7a84273724b5820c0392d32c7b1fa10bcd122d |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| Oct 3, 2021 | https://github.com/python/cpython/pull/28358#event-5400007817 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Apr 2, 2022 | https://github.com/python/cpython/pull/28358#issuecomment-1086726364 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
| Merge remote-tracking branch 'origin/main' into tp-dealloc-error-indi… | https://github.com/python/cpython/pull/28358/commits/ef342c59be42d5874be2160d9e96b0eb92c09a9c |
| ef342c5 | https://github.com/python/cpython/pull/28358/commits/ef342c59be42d5874be2160d9e96b0eb92c09a9c |
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Apr 3, 2022 | https://github.com/python/cpython/pull/28358#issuecomment-1086751889 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Apr 3, 2022
| https://github.com/python/cpython/pull/28358#pullrequestreview-929617151 |
|
View reviewed changes
| https://github.com/python/cpython/pull/28358/files/ef342c59be42d5874be2160d9e96b0eb92c09a9c |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/python/cpython/pull/28358#pullrequestreview-929617151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/files/ef342c59be42d5874be2160d9e96b0eb92c09a9c#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Apr 3, 2022 | https://github.com/python/cpython/pull/28358#discussion_r841137842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| ezyang | https://github.com/ezyang |
| Apr 3, 2022 | https://github.com/python/cpython/pull/28358#discussion_r841139815 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Apr 3, 2022 | https://github.com/python/cpython/pull/28358#issuecomment-1086756621 |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 5, 2022
| https://github.com/python/cpython/pull/28358#pullrequestreview-932581682 |
|
View reviewed changes
| https://github.com/python/cpython/pull/28358/files/ef342c59be42d5874be2160d9e96b0eb92c09a9c |
| Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/files/ef342c59be42d5874be2160d9e96b0eb92c09a9c#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1 |
| vstinner | https://github.com/vstinner |
| Apr 5, 2022 | https://github.com/python/cpython/pull/28358#discussion_r843310350 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| ezyang | https://github.com/ezyang |
| Apr 6, 2022 | https://github.com/python/cpython/pull/28358#discussion_r843401218 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
| Update typeobj.rst | https://github.com/python/cpython/pull/28358/commits/f068c4ede7a63594c539cb75e09349aaf76401e6 |
| f068c4e | https://github.com/python/cpython/pull/28358/commits/f068c4ede7a63594c539cb75e09349aaf76401e6 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Apr 6, 2022
| https://github.com/python/cpython/pull/28358#ref-pullrequest-1194346290 |
|
gh-89373: _Py_Dealloc() checks tp_dealloc exception
#32357
| https://github.com/python/cpython/pull/32357 |
| https://github.com/MaxwellDupre |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28358 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 21, 2022 | https://github.com/python/cpython/pull/28358#event-6470191005 |
| https://github.com/python/cpython/pull/28358 |
| ezyang | https://github.com/python/cpython/pull/28358 |
|
Apr 27, 2022
| https://github.com/python/cpython/pull/28358#ref-issue-1199065256 |
|
tp_dealloc docs should mention error indicator may be set
#89373
| https://github.com/python/cpython/issues/89373 |
| https://github.com/ezio-melotti |
| ezio-melotti | https://github.com/ezio-melotti |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jul 13, 2022 | https://github.com/python/cpython/pull/28358#event-6988864629 |
| https://github.com/willingc |
| willingc | https://github.com/willingc |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Nov 4, 2024 | https://github.com/python/cpython/pull/28358#event-15110252741 |
| https://github.com/apps/python-cla-bot |
| python-cla-bot | https://github.com/apps/python-cla-bot |
| Apr 6, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2781452454 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://cla.python.org/ |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| ezyang | https://github.com/ezyang |
| June 5, 2025 22:53 | https://github.com/python/cpython/pull/28358#commits-pushed-598791b |
|
| https://github.com/ezyang |
| Merge remote-tracking branch 'origin/main' into tp-dealloc-error-indi… | https://github.com/python/cpython/pull/28358/commits/598791bb36eeb127182d8ad09a7590437f007e96 |
| 598791b | https://github.com/python/cpython/pull/28358/commits/598791bb36eeb127182d8ad09a7590437f007e96 |
|
| https://github.com/ezyang |
| Merge remote-tracking branch 'origin' into tp-dealloc-error-indicator | https://github.com/python/cpython/pull/28358/commits/bd83da0d2dc4aad0805d9d0c3fa802caa7e80a70 |
| bd83da0 | https://github.com/python/cpython/pull/28358/commits/bd83da0d2dc4aad0805d9d0c3fa802caa7e80a70 |
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Jun 6, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2947952805 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Jun 6, 2025
| https://github.com/python/cpython/pull/28358#pullrequestreview-2904103214 |
|
View reviewed changes
| https://github.com/python/cpython/pull/28358/files/bd83da0d2dc4aad0805d9d0c3fa802caa7e80a70 |
| Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/files/bd83da0d2dc4aad0805d9d0c3fa802caa7e80a70#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
| Don't use deprecated PyErr_Fetch | https://github.com/python/cpython/pull/28358/commits/6c718859c3e1850cdef4949316f3f5232780f7ab |
| 6c71885 | https://github.com/python/cpython/pull/28358/commits/6c718859c3e1850cdef4949316f3f5232780f7ab |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
| Update Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/commits/3e62ace3c4227102163264e7f44e41f1c89250c1 |
| 3e62ace | https://github.com/python/cpython/pull/28358/commits/3e62ace3c4227102163264e7f44e41f1c89250c1 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Jun 7, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2952363895 |
| @ezyang | https://github.com/ezyang |
| #28358 (comment) | https://github.com/python/cpython/pull/28358#issuecomment-2781452454 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/ezyang |
| ezyang | https://github.com/ezyang |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2954523497 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Jun 9, 2025
| https://github.com/python/cpython/pull/28358#pullrequestreview-2909391758 |
|
View reviewed changes
| https://github.com/python/cpython/pull/28358/files/3e62ace3c4227102163264e7f44e41f1c89250c1 |
| Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/files/3e62ace3c4227102163264e7f44e41f1c89250c1#diff-560c6b0fbef4ddae510a4f11e165d0cd179a52506b470cead404d2b53e48bbe1 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/vstinner |
| Update Doc/c-api/typeobj.rst | https://github.com/python/cpython/pull/28358/commits/6afd215e7c2730c1d5059a1cd909f170d752a976 |
| 6afd215 | https://github.com/python/cpython/pull/28358/commits/6afd215e7c2730c1d5059a1cd909f170d752a976 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
Jun 9, 2025
| https://github.com/python/cpython/pull/28358#pullrequestreview-2909395608 |
|
View reviewed changes
| https://github.com/python/cpython/pull/28358/files/6afd215e7c2730c1d5059a1cd909f170d752a976 |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/28358#pullrequestreview-2909395608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18051708267 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| June 9, 2025 08:51 | https://github.com/python/cpython/pull/28358#event-18051719748 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18051752123 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| 8441b26 | https://github.com/python/cpython/commit/8441b263af964f353bf02d56c32a4fc547cdc330 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18051804777 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/github-project-automation |
| github-project-automation | https://github.com/apps/github-project-automation |
| Docs PRs | https://github.com/orgs/python/projects/50 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18051805564 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18051805645 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
|
needs backport to 3.14
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18055145443 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2955710471 |
| @ezyang | https://github.com/ezyang |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2955710472 |
| @ezyang | https://github.com/ezyang |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2955710567 |
| @ezyang | https://github.com/ezyang |
| @vstinner | https://github.com/vstinner |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/miss-islington-app |
| miss-islington-app | https://github.com/apps/miss-islington-app |
| vstinner | https://github.com/vstinner |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18055147277 |
| miss-islington | https://github.com/miss-islington |
|
Jun 9, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-1452dc7 |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
|
| https://github.com/miss-islington |
| bpo-45210: Document that error indicator may be set in tp_dealloc ( | https://github.com/miss-islington/cpython/commit/1452dc723a0d22999d140c3fc1ee24e9de2f98ba |
| py… | https://github.com/python/cpython/pull/28358 |
| 1452dc7 | https://github.com/miss-islington/cpython/commit/1452dc723a0d22999d140c3fc1ee24e9de2f98ba |
| …thonGH-28358 | https://github.com/python/cpython/pull/28358 |
| 8441b26 | https://github.com/miss-islington/cpython/commit/8441b263af964f353bf02d56c32a4fc547cdc330 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2955711027 |
| GH-135298 | https://github.com/python/cpython/pull/135298 |
| 3.14 branch | https://github.com/python/cpython/tree/3.14 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
needs backport to 3.14
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18055150302 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
needs backport to 3.13
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.13%22 |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#event-18055156118 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Jun 9, 2025 | https://github.com/python/cpython/pull/28358#issuecomment-2955712923 |
| @ezyang | https://github.com/ezyang |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
| vstinner | https://github.com/vstinner |
|
Jun 9, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-725ec53 |
|
| https://github.com/miss-islington |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
| [3.14] | https://github.com/python/cpython/commit/725ec53032a7a1bc7a4307fb9aae39cb22fd8971 |
| bpo-45210 | https://bugs.python.org/issue?@action=redirect&bpo=45210 |
| : Document that error indicator may be set in tp_deal… | https://github.com/python/cpython/commit/725ec53032a7a1bc7a4307fb9aae39cb22fd8971 |
| 725ec53 | https://github.com/python/cpython/commit/725ec53032a7a1bc7a4307fb9aae39cb22fd8971 |
| GH-28358 | https://github.com/python/cpython/pull/28358 |
| #135298 | https://github.com/python/cpython/pull/135298 |
| bpo-45210 | https://bugs.python.org/issue?@action=redirect&bpo=45210 |
| GH-28358 | https://github.com/python/cpython/pull/28358 |
| 8441b26 | https://github.com/python/cpython/commit/8441b263af964f353bf02d56c32a4fc547cdc330 |
| lkollar | https://github.com/lkollar |
|
Jun 19, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-e628f8a |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
|
| https://github.com/lkollar |
| bpo-45210: Document that error indicator may be set in tp_dealloc ( | https://github.com/lkollar/cpython/commit/e628f8a12e563be9e872761fd9e17bb1e8de0720 |
| py… | https://github.com/python/cpython/pull/28358 |
| e628f8a | https://github.com/lkollar/cpython/commit/e628f8a12e563be9e872761fd9e17bb1e8de0720 |
| …thon#28358 | https://github.com/python/cpython/pull/28358 |
| Pranjal095 | https://github.com/Pranjal095 |
|
Jul 12, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-1e8c8fd |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
|
| https://github.com/Pranjal095 |
| bpo-45210: Document that error indicator may be set in tp_dealloc ( | https://github.com/Pranjal095/cpython/commit/1e8c8fde13f93aaea01868a0d328e27af3ef80b9 |
| py… | https://github.com/python/cpython/pull/28358 |
| 1e8c8fd | https://github.com/Pranjal095/cpython/commit/1e8c8fde13f93aaea01868a0d328e27af3ef80b9 |
| …thon#28358 | https://github.com/python/cpython/pull/28358 |
| taegyunkim | https://github.com/taegyunkim |
|
Aug 4, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-2bee62f |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
|
| https://github.com/taegyunkim |
| bpo-45210: Document that error indicator may be set in tp_dealloc ( | https://github.com/taegyunkim/cpython/commit/2bee62f0d0d84ee09a278f0ac19dfc9055865624 |
| py… | https://github.com/python/cpython/pull/28358 |
| 2bee62f | https://github.com/taegyunkim/cpython/commit/2bee62f0d0d84ee09a278f0ac19dfc9055865624 |
| …thon#28358 | https://github.com/python/cpython/pull/28358 |
| Agent-Hellboy | https://github.com/Agent-Hellboy |
|
Aug 19, 2025
| https://github.com/python/cpython/pull/28358#ref-commit-8dbfb7c |
|
| https://github.com/ezyang |
|
| https://github.com/vstinner |
|
| https://github.com/Agent-Hellboy |
| bpo-45210: Document that error indicator may be set in tp_dealloc ( | https://github.com/Agent-Hellboy/cpython/commit/8dbfb7cd0faef419cdffd9873a152ef8d2f47698 |
| py… | https://github.com/python/cpython/pull/28358 |
| 8dbfb7c | https://github.com/Agent-Hellboy/cpython/commit/8dbfb7cd0faef419cdffd9873a152ef8d2f47698 |
| …thon#28358 | https://github.com/python/cpython/pull/28358 |
| https://github.com/kcdodd |
| kcdodd | https://github.com/kcdodd |
|
Aug 22, 2025
| https://github.com/python/cpython/pull/28358#ref-issue-3345736276 |
|
dlpack destructor "clobbers preexisting error indicator"
jax-ml/jax#31271
| https://github.com/jax-ml/jax/issues/31271 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28358 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/cpython/pull/28358/files/ef342c59be42d5874be2160d9e96b0eb92c09a9c |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/28358/files/6afd215e7c2730c1d5059a1cd909f170d752a976 |
|
| https://github.com/MaxwellDupre |
|
MaxwellDupre
| https://github.com/MaxwellDupre |
|
| https://github.com/python/cpython/pull/28358/files/598791bb36eeb127182d8ad09a7590437f007e96 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
|
Docs PRs
| https://github.com/orgs/python/projects/50 |
| Please reload this page | https://github.com/python/cpython/pull/28358 |
|
| https://github.com/ezyang |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/vstinner |
|
| https://github.com/MaxwellDupre |
|
| https://github.com/willingc |
|
| https://github.com/ezio-melotti |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |