René's URL Explorer Experiment


Title: bpo-45019: Do some cleanup related to frozen modules. by ericsnowcurrently · Pull Request #28319 · python/cpython · GitHub

Open Graph Title: bpo-45019: Do some cleanup related to frozen modules. by ericsnowcurrently · Pull Request #28319 · python/cpython

X Title: bpo-45019: Do some cleanup related to frozen modules. by ericsnowcurrently · Pull Request #28319 · python/cpython

Description: There are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules. (FYI, these changes...

Open Graph Description: There are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules. (FYI, these changes...

X Description: There are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules. (FYI, these changes...

Opengraph URL: https://github.com/python/cpython/pull/28319

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35cc2c56-73ea-7ac4-b1c8-30757cd2861f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABC6:2CD276:68093D:88BBA3:696B11E7
html-safe-nonce250428d9e2e74d9ded973da40eb1b8d556e68d797419c83c83a17bb6e1ce2f66
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkM2OjJDRDI3Njo2ODA5M0Q6ODhCQkEzOjY5NkIxMUU3IiwidmlzaXRvcl9pZCI6IjIwNzA1Njg4MjU2NzYwNDI3MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c0a31fee8022f6b933b322f71d7a1c534073836fde29f6ab7b9d92e6c4bb2df
hovercard-subject-tagpull_request:733132326
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/28319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7cf1c14c64b657c6cfcd3f1303c2b877cee049e0d711aa60add5dadd73863170/python/cpython/pull/28319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7cf1c14c64b657c6cfcd3f1303c2b877cee049e0d711aa60add5dadd73863170/python/cpython/pull/28319
og:image:altThere are a few things I missed in gh-27980. This is a follow-up that will make subsequent PRs cleaner. It includes fixes to tests and tools that reference the frozen modules. (FYI, these changes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/28319#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28319
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28319
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/28319
Reloadhttps://github.com/python/cpython/pull/28319
Reloadhttps://github.com/python/cpython/pull/28319
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/28319
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/28319
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/28319#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:frozen-modules-cleanup-2https://github.com/ericsnowcurrently/cpython/tree/frozen-modules-cleanup-2
bpo-45019: Do some cleanup related to frozen modules. https://github.com/python/cpython/pull/28319#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:frozen-modules-cleanup-2https://github.com/ericsnowcurrently/cpython/tree/frozen-modules-cleanup-2
Conversation 0 https://github.com/python/cpython/pull/28319
Commits 19 https://github.com/python/cpython/pull/28319/commits
Checks 0 https://github.com/python/cpython/pull/28319/checks
Files changed https://github.com/python/cpython/pull/28319/files
Please reload this pagehttps://github.com/python/cpython/pull/28319
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 13, 2021https://github.com/python/cpython/pull/28319#issue-995356596
Please reload this pagehttps://github.com/python/cpython/pull/28319
gh-27980https://github.com/python/cpython/pull/27980
gh-28107https://github.com/python/cpython/pull/28107
@gvanrossumhttps://github.com/gvanrossum
https://bugs.python.org/issue45019https://bugs.python.org/issue45019
Please reload this pagehttps://github.com/python/cpython/pull/28319
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 13, 2021 14:10https://github.com/python/cpython/pull/28319#commits-pushed-63cd6f6
https://github.com/ericsnowcurrently
Fix freeze_module() in freeze_modules.py.https://github.com/python/cpython/pull/28319/commits/63cd6f6af96b6a2382c01fc56c6986367874d6d3
63cd6f6https://github.com/python/cpython/pull/28319/commits/63cd6f6af96b6a2382c01fc56c6986367874d6d3
https://github.com/ericsnowcurrently
Add FrozenSource and FrozenModule to freeze_modules.py.https://github.com/python/cpython/pull/28319/commits/0223e321e8ad1e9779a0dc0d735f780d253a0fd5
0223e32https://github.com/python/cpython/pull/28319/commits/0223e321e8ad1e9779a0dc0d735f780d253a0fd5
https://github.com/ericsnowcurrently
Leave all non-required frozen modules uncommitted.https://github.com/python/cpython/pull/28319/commits/a2be976aed874d4262320aae09ccd432b5dff817
a2be976https://github.com/python/cpython/pull/28319/commits/a2be976aed874d4262320aae09ccd432b5dff817
https://github.com/ericsnowcurrently
Leave *all* frozen modules uncommitted.https://github.com/python/cpython/pull/28319/commits/7a9d113cf8cc963bb34501be92b78cadc0e49eca
7a9d113https://github.com/python/cpython/pull/28319/commits/7a9d113cf8cc963bb34501be92b78cadc0e49eca
https://github.com/ericsnowcurrently
Generate the list of frozen modules used by test_ctypes.https://github.com/python/cpython/pull/28319/commits/e0f264f2401e9ae69a7880f4b5e2e93270db94af
e0f264fhttps://github.com/python/cpython/pull/28319/commits/e0f264f2401e9ae69a7880f4b5e2e93270db94af
https://github.com/ericsnowcurrently
Ignore frozen submodules in generate_stdlib_module_names.py.https://github.com/python/cpython/pull/28319/commits/c4cea0f24edbe6180ff4b5fbae04d49d821e8a67
c4cea0fhttps://github.com/python/cpython/pull/28319/commits/c4cea0f24edbe6180ff4b5fbae04d49d821e8a67
https://github.com/ericsnowcurrently
Add a comment to the frozen modules manifest file.https://github.com/python/cpython/pull/28319/commits/1336b4ed15bc46f0936f24181af8ce2c3fad910d
1336b4ehttps://github.com/python/cpython/pull/28319/commits/1336b4ed15bc46f0936f24181af8ce2c3fad910d
https://github.com/ericsnowcurrently
Show how the frozen manifest changed.https://github.com/python/cpython/pull/28319/commits/122492ab116242d0be313a3120c37f5a5c1c738a
122492ahttps://github.com/python/cpython/pull/28319/commits/122492ab116242d0be313a3120c37f5a5c1c738a
https://github.com/ericsnowcurrently
Go back to keeping frozen modules in the repo.https://github.com/python/cpython/pull/28319/commits/4c1bc81c1bc47f050af00f379d31e9d677ecc081
4c1bc81https://github.com/python/cpython/pull/28319/commits/4c1bc81c1bc47f050af00f379d31e9d677ecc081
https://github.com/ericsnowcurrently
Also stop tracking the frozen manifest.https://github.com/python/cpython/pull/28319/commits/cd992806826133ede5b7da149daa5d2be8b22063
cd99280https://github.com/python/cpython/pull/28319/commits/cd992806826133ede5b7da149daa5d2be8b22063
https://github.com/ericsnowcurrently
Mark the frozen manifest as a generated file.https://github.com/python/cpython/pull/28319/commits/65a956274f4b9114458f9a4128f4c7fae894fb5c
65a9562https://github.com/python/cpython/pull/28319/commits/65a956274f4b9114458f9a4128f4c7fae894fb5c
https://github.com/ericsnowcurrently
Drop a superfluous prefix on makefile rule dependencies.https://github.com/python/cpython/pull/28319/commits/122e6422207b62211d6a41e03169f7f886ca13ec
122e642https://github.com/python/cpython/pull/28319/commits/122e6422207b62211d6a41e03169f7f886ca13ec
https://github.com/ericsnowcurrently
Do not generate test code.https://github.com/python/cpython/pull/28319/commits/0704664c64ffc12a5dfd4a1a8732c2bc162b68d1
0704664https://github.com/python/cpython/pull/28319/commits/0704664c64ffc12a5dfd4a1a8732c2bc162b68d1
https://github.com/ericsnowcurrently
Drop unused code from freeze_modules.py.https://github.com/python/cpython/pull/28319/commits/81d70eaaffb8681738656d54ce56e1a28d1cf2cc
81d70eahttps://github.com/python/cpython/pull/28319/commits/81d70eaaffb8681738656d54ce56e1a28d1cf2cc
https://github.com/ericsnowcurrently
Do not clear the frozen .h files with "make distclean", now that they…https://github.com/python/cpython/pull/28319/commits/a61afbde26ff1eed57770687c18a902df94c3f43
a61afbdhttps://github.com/python/cpython/pull/28319/commits/a61afbde26ff1eed57770687c18a902df94c3f43
https://github.com/ericsnowcurrently
Always flush the printed "title" when freezing modules.https://github.com/python/cpython/pull/28319/commits/ca35ee8b11a3f54ec54da15df030dca38c96ec81
ca35ee8https://github.com/python/cpython/pull/28319/commits/ca35ee8b11a3f54ec54da15df030dca38c96ec81
https://github.com/ericsnowcurrently
Add the frozen manifest back into the repo.https://github.com/python/cpython/pull/28319/commits/1bf4d2f15180985b408163e80a326e9a0261dafe
1bf4d2fhttps://github.com/python/cpython/pull/28319/commits/1bf4d2f15180985b408163e80a326e9a0261dafe
https://github.com/ericsnowcurrently
On Windows, only freeze the essential modules for now.https://github.com/python/cpython/pull/28319/commits/bd129b554b6cc3e3fb9288113b3dec3ba9176470
bd129b5https://github.com/python/cpython/pull/28319/commits/bd129b554b6cc3e3fb9288113b3dec3ba9176470
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295604038
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/1fc41ae8709e20d741bd86c2345173688a5e84b0/.github/CODEOWNERS#L51
September 13, 2021 21:26https://github.com/python/cpython/pull/28319#event-5295604087
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295604276
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295604338
https://github.com/ericsnowcurrently
Drop an outdated call.https://github.com/python/cpython/pull/28319/commits/20d3b506b0c64be2569e6a96a70d104941535229
20d3b50https://github.com/python/cpython/pull/28319/commits/20d3b506b0c64be2569e6a96a70d104941535229
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295752177
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 13, 2021 https://github.com/python/cpython/pull/28319#ref-pullrequest-984434325
bpo-45020: Freeze the modules imported during startup. #28107 https://github.com/python/cpython/pull/28107
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
a2d8c4bhttps://github.com/python/cpython/commit/a2d8c4b81b8e68e2ffe10945f7ca69174c14e52a
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295794394
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 13, 2021https://github.com/python/cpython/pull/28319#event-5295794479
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
September 15, 2021 16:21https://github.com/python/cpython/pull/28319#event-5307137609
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2021 https://github.com/python/cpython/pull/28319#ref-pullrequest-997363323
bpo-45019: Silence a warning in test_ctypes. #28362 https://github.com/python/cpython/pull/28362
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2021 https://github.com/python/cpython/pull/28319#ref-commit-4b30aaa
https://github.com/ericsnowcurrently
bpo-45019https://bugs.python.org/issue?@action=redirect&bpo=45019
: Silence a warning in test_ctypes. (https://github.com/python/cpython/commit/4b30aaa0c9dc4da956199dbd48af9c06089cb271
gh-28362https://github.com/python/cpython/pull/28362
)https://github.com/python/cpython/commit/4b30aaa0c9dc4da956199dbd48af9c06089cb271
4b30aaahttps://github.com/python/cpython/commit/4b30aaa0c9dc4da956199dbd48af9c06089cb271
gh-28319https://github.com/python/cpython/pull/28319
https://bugs.python.org/issue45019https://bugs.python.org/issue45019
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2021 https://github.com/python/cpython/pull/28319#ref-pullrequest-997438027
bpo-45019: Clean up the frozen __hello__ module. #28374 https://github.com/python/cpython/pull/28374
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 15, 2021 https://github.com/python/cpython/pull/28319#ref-commit-3814e20
https://github.com/ericsnowcurrently
bpo-45019https://bugs.python.org/issue?@action=redirect&bpo=45019
: Clean up the frozen __hello__ module. (https://github.com/python/cpython/commit/3814e2036d96e2b6c69afce61926bb0a2a34d2d9
gh-28374https://github.com/python/cpython/pull/28374
)https://github.com/python/cpython/commit/3814e2036d96e2b6c69afce61926bb0a2a34d2d9
3814e20https://github.com/python/cpython/commit/3814e2036d96e2b6c69afce61926bb0a2a34d2d9
gh-28319https://github.com/python/cpython/pull/28319
https://bugs.python.org/issue45019https://bugs.python.org/issue45019
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F28319
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/28319
https://github.com/ericsnowcurrently
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.