René's URL Explorer Experiment


Title: bpo-39039: tarfile raises descriptive exception from zlib.error by jdevries3133 · Pull Request #27766 · python/cpython · GitHub

Open Graph Title: bpo-39039: tarfile raises descriptive exception from zlib.error by jdevries3133 · Pull Request #27766 · python/cpython

X Title: bpo-39039: tarfile raises descriptive exception from zlib.error by jdevries3133 · Pull Request #27766 · python/cpython

Description: during tarfile parsing, a zlib error indicates invalid data tarfile.open now raises a descriptive exception from the zlib error this makes it clear to the user that they may be trying to open a corrupted tar file I think that this small changes achieves a fix for the bpo. Tests still pass, so that's a good sign that maybe this change does not introduce side-effects, but I am hoping that someone with knowledge of this library help me think of some edge cases to try out. Please note that I am a relative novice developer, and while this patch is good to the best of my understanding, my understanding is not the best! https://bugs.python.org/issue39039

Open Graph Description: during tarfile parsing, a zlib error indicates invalid data tarfile.open now raises a descriptive exception from the zlib error this makes it clear to the user that they may be trying to open a cor...

X Description: during tarfile parsing, a zlib error indicates invalid data tarfile.open now raises a descriptive exception from the zlib error this makes it clear to the user that they may be trying to open a cor...

Opengraph URL: https://github.com/python/cpython/pull/27766

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f3728625-b713-f1be-8fc6-f8257270892f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA00:363DB3:2E5978E:429A82B:6A4FBB3A
html-safe-nonce529d7fb76c142387b2a2871991345c3e9153b38e827f47d789e5da253530cf72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTAwOjM2M0RCMzoyRTU5NzhFOjQyOUE4MkI6NkE0RkJCM0EiLCJ2aXNpdG9yX2lkIjoiNTM5Nzg0ODY1MzgyMDgzNjY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac61d8a2a0692e528d1ef057ac09ab4c1e8bed359faf0adb532c4117a33db0b0e0
hovercard-subject-tagpull_request:712701738
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/27766/files
twitter:imagehttps://avatars.githubusercontent.com/u/58614260?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58614260?s=400&v=4
og:image:altduring tarfile parsing, a zlib error indicates invalid data tarfile.open now raises a descriptive exception from the zlib error this makes it clear to the user that they may be trying to open a cor...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/27766/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27766%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27766%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/27766/files
Reloadhttps://github.com/python/cpython/pull/27766/files
Reloadhttps://github.com/python/cpython/pull/27766/files
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
jdevries3133:bpo-39039-tarfilehttps://github.com/jdevries3133/cpython/tree/bpo-39039-tarfile
Conversation 28 https://github.com/python/cpython/pull/27766
Commits 7 https://github.com/python/cpython/pull/27766/commits
Checks 0 https://github.com/python/cpython/pull/27766/checks
Files changed https://github.com/python/cpython/pull/27766/files
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
bpo-39039: tarfile raises descriptive exception from zlib.error https://github.com/python/cpython/pull/27766/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/27766/files
cab12ea bpo-39039: tarfile raises descriptive exception from zlib.error jdevries3133 Aug 14, 2021 https://github.com/python/cpython/pull/27766/commits/cab12eadaad7802900e9bd6029e7578837c20439
84726b9 temp: revert changes so far; return to "clean slate" jdevries3133 Aug 17, 2021 https://github.com/python/cpython/pull/27766/commits/84726b95aab776cb6e137d890185e3488ca39a88
6123c18 first revision; no test yet jdevries3133 Aug 18, 2021 https://github.com/python/cpython/pull/27766/commits/6123c186216ac5400d64e175b0c6242321bf3446
325202a draft: introduce test jdevries3133 Aug 20, 2021 https://github.com/python/cpython/pull/27766/commits/325202a2b666a2dbd0f6e64f27c6258e14a1a77c
4711fd2 draft: restore fix jdevries3133 Aug 20, 2021 https://github.com/python/cpython/pull/27766/commits/4711fd2848582250517747de14c6c9a588b51215
eb60bbe check if zlib is None, not "not zlib" jdevries3133 Aug 20, 2021 https://github.com/python/cpython/pull/27766/commits/eb60bbe68ff20ca9eb0482deebe6d3ee3d6987a0
4cc0c4c raise ReadError from None jdevries3133 Aug 22, 2021 https://github.com/python/cpython/pull/27766/commits/4cc0c4c34df1a24e51c320ed10b04e762e97c471
Clear filters https://github.com/python/cpython/pull/27766/files
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
tarfile.py https://github.com/python/cpython/pull/27766/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
test_tarfile.py https://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
2021-08-18-10-36-14.bpo-39039.A63LYh.rst https://github.com/python/cpython/pull/27766/files#diff-9957b3f231fc9c0a27a367d52ebb3ac33dc4e734c3127db3f82df3f85df50835
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/tarfile.pyhttps://github.com/python/cpython/pull/27766/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
View file https://github.com/jdevries3133/cpython/blob/4cc0c4c34df1a24e51c320ed10b04e762e97c471/Lib/tarfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/27766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/27766/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
ambvhttps://github.com/ambv
Aug 22, 2021https://github.com/python/cpython/pull/27766/files#r693545776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
jdevries3133https://github.com/jdevries3133
Aug 22, 2021https://github.com/python/cpython/pull/27766/files#r693546162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/27766/files
https://github.com/python/cpython/pull/27766/files#diff-7972dffec6674d5f09410c71766ac6caacb95b9bccbf032061806ae304519c9b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L602
Lib/test/test_tarfile.pyhttps://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
View file https://github.com/jdevries3133/cpython/blob/4cc0c4c34df1a24e51c320ed10b04e762e97c471/Lib/test/test_tarfile.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/27766/{{ revealButtonHref }}
https://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
https://github.com/python/cpython/pull/27766/files#diff-5a960e3329582bbb78357c630a282130226d734c1042e491ba2198729a2b6eac
Misc/NEWS.d/next/Library/2021-08-18-10-36-14.bpo-39039.A63LYh.rsthttps://github.com/python/cpython/pull/27766/files#diff-9957b3f231fc9c0a27a367d52ebb3ac33dc4e734c3127db3f82df3f85df50835
View file https://github.com/jdevries3133/cpython/blob/4cc0c4c34df1a24e51c320ed10b04e762e97c471/Misc/NEWS.d/next/Library/2021-08-18-10-36-14.bpo-39039.A63LYh.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/27766/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.