René's URL Explorer Experiment


Title: bpo-43897: Reject `"_"` captures and top-level `MatchStar` in the AST validator by brandtbucher · Pull Request #27432 · python/cpython · GitHub

Open Graph Title: bpo-43897: Reject `"_"` captures and top-level `MatchStar` in the AST validator by brandtbucher · Pull Request #27432 · python/cpython

X Title: bpo-43897: Reject `"_"` captures and top-level `MatchStar` in the AST validator by brandtbucher · Pull Request #27432 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Also, remove an old comment and fix some recursion depth issues. https://bugs.python.org/issue43897

X Description: Also, remove an old comment and fix some recursion depth issues. https://bugs.python.org/issue43897

Opengraph URL: https://github.com/python/cpython/pull/27432

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b11ca99c-7d78-b9d5-b06e-4aee69403e46
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA384:FF37F:B6B6CD:F93488:6A57E64B
html-safe-nonceeb131ec1060b333c934a718fe088eac00423206e264c79c8e02481304078a180
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzg0OkZGMzdGOkI2QjZDRDpGOTM0ODg6NkE1N0U2NEIiLCJ2aXNpdG9yX2lkIjoiNDY5MzYwMzU2MjA4MDk1MzkzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace44a6b5139559c4aaa06aea491aed1c7edd128aca1ce44dce0cefde40e60c7f0
hovercard-subject-tagpull_request:699038201
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/27432/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/39973f5c95e111154b9f6c67a411c22d0aa2afdd68c7bc5ff3df673d269c7d4b/python/cpython/pull/27432
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39973f5c95e111154b9f6c67a411c22d0aa2afdd68c7bc5ff3df673d269c7d4b/python/cpython/pull/27432
og:image:altAlso, remove an old comment and fix some recursion depth issues. https://bugs.python.org/issue43897
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
None49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release72a32c9d47294b6b7eb7f0250253277920c7a987
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/27432#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27432
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27432
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/27432
Reloadhttps://github.com/python/cpython/pull/27432
Reloadhttps://github.com/python/cpython/pull/27432
Please reload this pagehttps://github.com/python/cpython/pull/27432
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/27432
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:patma-ast-validationhttps://github.com/brandtbucher/cpython/tree/patma-ast-validation
Conversationhttps://github.com/python/cpython/pull/27432
Commits3 (3)https://github.com/python/cpython/pull/27432/commits
Checkshttps://github.com/python/cpython/pull/27432/checks
Files changedhttps://github.com/python/cpython/pull/27432/files
bpo-43897: Reject "_" captures and top-level MatchStar in the AST validatorhttps://github.com/python/cpython/pull/27432#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:patma-ast-validationhttps://github.com/brandtbucher/cpython/tree/patma-ast-validation
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jul 28, 2021https://github.com/python/cpython/pull/27432#issue-955261434
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://bugs.python.org/issue43897https://bugs.python.org/issue43897
Please reload this pagehttps://github.com/python/cpython/pull/27432
brandtbucherhttps://github.com/brandtbucher
July 28, 2021 14:41https://github.com/python/cpython/pull/27432#commits-pushed-c3c705f
https://github.com/brandtbucher
Add failing regression tests.https://github.com/python/cpython/pull/27432/commits/c3c705f6186269baaf1a5bc530835dede2b3f01a
c3c705fhttps://github.com/python/cpython/pull/27432/commits/c3c705f6186269baaf1a5bc530835dede2b3f01a
https://github.com/brandtbucher
Properly validate "_" identifiers and MatchStarhttps://github.com/python/cpython/pull/27432/commits/86279a89365bde658a700b8d8e71f5ecd3aa8626
86279a8https://github.com/python/cpython/pull/27432/commits/86279a89365bde658a700b8d8e71f5ecd3aa8626
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Jul 28, 2021https://github.com/python/cpython/pull/27432#event-5082693786
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
isidenticalhttps://github.com/isidentical
July 28, 2021 21:52https://github.com/python/cpython/pull/27432#event-5082693793
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 28, 2021https://github.com/python/cpython/pull/27432#event-5082693918
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 28, 2021https://github.com/python/cpython/pull/27432#event-5082693937
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jul 28, 2021https://github.com/python/cpython/pull/27432#event-5082695165
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Jul 28, 2021 https://github.com/python/cpython/pull/27432#pullrequestreview-717503767
View reviewed changes https://github.com/python/cpython/pull/27432/files/86279a89365bde658a700b8d8e71f5ecd3aa8626
Python/ast.chttps://github.com/python/cpython/pull/27432/files/86279a89365bde658a700b8d8e71f5ecd3aa8626#diff-63309d32b22eaebd869b7ac0d2d4d02f95bd7ff5de2ba042d07c8e6962af8bbc
isidenticalhttps://github.com/isidentical
Jul 28, 2021https://github.com/python/cpython/pull/27432#discussion_r678682841
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/27432
brandtbucherhttps://github.com/brandtbucher
Jul 28, 2021https://github.com/python/cpython/pull/27432#discussion_r678690923
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Jul 28, 2021 https://github.com/python/cpython/pull/27432#pullrequestreview-717504863
View reviewed changes https://github.com/python/cpython/pull/27432/files/86279a89365bde658a700b8d8e71f5ecd3aa8626
isidenticalhttps://github.com/isidentical
https://github.com/python/cpython/pull/27432#pullrequestreview-717504863
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 28, 2021https://github.com/python/cpython/pull/27432#event-5082735236
https://github.com/isidentical
isidenticalhttps://github.com/isidentical
Jul 28, 2021https://github.com/python/cpython/pull/27432#issuecomment-888653568
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jul 28, 2021https://github.com/python/cpython/pull/27432#issuecomment-888659440
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/brandtbucher
star_okay -> star_okhttps://github.com/python/cpython/pull/27432/commits/407a3946fe43e91f19f10856b65baf3c78b20083
407a394https://github.com/python/cpython/pull/27432/commits/407a3946fe43e91f19f10856b65baf3c78b20083
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jul 29, 2021https://github.com/python/cpython/pull/27432#issuecomment-888704668
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Jul 29, 2021https://github.com/python/cpython/pull/27432#issuecomment-888706045
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
8d06474https://github.com/python/cpython/commit/8d0647485db5af2a0f0929d6509479ca45f1281b
Jul 29, 2021https://github.com/python/cpython/pull/27432#event-5083087196
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jul 29, 2021https://github.com/python/cpython/pull/27432#issuecomment-888706236
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 29, 2021https://github.com/python/cpython/pull/27432#event-5083087279
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jul 29, 2021https://github.com/python/cpython/pull/27432#issuecomment-888706351
GH-27435https://github.com/python/cpython/pull/27435
3.10 branchhttps://github.com/python/cpython/tree/3.10
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
Jul 29, 2021https://github.com/python/cpython/pull/27432#event-5083087958
miss-islingtonhttps://github.com/miss-islington
Jul 29, 2021 https://github.com/python/cpython/pull/27432#ref-commit-796f816
https://github.com/brandtbucher
https://github.com/miss-islington
bpo-43897: Reject "_" captures and top-level MatchStar in the AST val…https://github.com/miss-islington/cpython/commit/796f816ae2710170a1977bba06325dbeffdcd8c0
796f816https://github.com/miss-islington/cpython/commit/796f816ae2710170a1977bba06325dbeffdcd8c0
pythonGH-27432https://github.com/python/cpython/pull/27432
8d06474https://github.com/miss-islington/cpython/commit/8d0647485db5af2a0f0929d6509479ca45f1281b
miss-islingtonhttps://github.com/miss-islington
Jul 29, 2021 https://github.com/python/cpython/pull/27432#ref-commit-405f5c5
https://github.com/miss-islington
[3.10]https://github.com/python/cpython/commit/405f5c54914483607194a3ba6d4e50533d92bad1
bpo-43897https://bugs.python.org/issue?@action=redirect&bpo=43897
: Reject "_" captures and top-level MatchStar in the …https://github.com/python/cpython/commit/405f5c54914483607194a3ba6d4e50533d92bad1
405f5c5https://github.com/python/cpython/commit/405f5c54914483607194a3ba6d4e50533d92bad1
GH-27432https://github.com/python/cpython/pull/27432
GH-27435https://github.com/python/cpython/pull/27435
8d06474https://github.com/python/cpython/commit/8d0647485db5af2a0f0929d6509479ca45f1281b
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
July 21, 2022 20:19https://github.com/python/cpython/pull/27432#event-7041201886
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27432
https://github.com/isidentical
isidentical https://github.com/isidentical
https://github.com/python/cpython/pull/27432/files/86279a89365bde658a700b8d8e71f5ecd3aa8626
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/27432
https://github.com/brandtbucher
https://github.com/isidentical
https://github.com/pablogsal
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.