René's URL Explorer Experiment


Title: bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython · GitHub

Open Graph Title: bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython

X Title: bpo-43950: ensure source_line is present when specializing the traceback by isidentical · Pull Request #27313 · python/cpython

Description: There seems to be different cases where the _PyDisplay_Line() function returns 0 without displaying the actual line but also without having any errors raised. cpython/Python/traceback.c Lines 414 to 420 in 4512848 /* use the right encoding to decode the file as unicode */ fd = PyObject_AsFileDescriptor(binary); if (fd < 0) { Py_DECREF(io); Py_DECREF(binary); return 0; } cpython/Python/traceback.c Lines 436 to 446 in 4512848 if (fob == NULL) { PyErr_Clear(); res = _PyObject_CallMethodIdNoArgs(binary, &PyId_close); Py_DECREF(binary); if (res) Py_DECREF(res); else PyErr_Clear(); return 0; } This patch ensures that the line is retrieved and displayed. https://bugs.python.org/issue43950

Open Graph Description: There seems to be different cases where the _PyDisplay_Line() function returns 0 without displaying the actual line but also without having any errors raised. cpython/Python/tracebac...

X Description: There seems to be different cases where the _PyDisplay_Line() function returns 0 without displaying the actual line but also without having any errors raised. cpython/Python/tracebac...

Opengraph URL: https://github.com/python/cpython/pull/27313

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:143a5c52-1791-aa5d-53b9-70b3700da2db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB40:27E9DD:B89779:103028C:696A29B7
html-safe-nonce3011adc44247d35476fa84e080d32ee91527c56309c33f19c55a3f331f056fe7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQwOjI3RTlERDpCODk3Nzk6MTAzMDI4Qzo2OTZBMjlCNyIsInZpc2l0b3JfaWQiOiIyNDQxMDMwMzM2NDM5MjY1NzE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace6faf9389ceb5e554d03f630e505fff437d14e8e25aa6c05a32eca7498e376aa
hovercard-subject-tagpull_request:696156423
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/27313/files
twitter:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/47358913?s=400&v=4
og:image:altThere seems to be different cases where the _PyDisplay_Line() function returns 0 without displaying the actual line but also without having any errors raised. cpython/Python/tracebac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef472b8e6c7b3fdd5d0354972a3f4c516289bf0be
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/27313/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27313%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27313%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/27313/files
Reloadhttps://github.com/python/cpython/pull/27313/files
Reloadhttps://github.com/python/cpython/pull/27313/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/27313/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/27313/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
colnotab:ensure-source-line-is-displayedhttps://github.com/colnotab/cpython/tree/ensure-source-line-is-displayed
Conversation 5 https://github.com/python/cpython/pull/27313
Commits 3 https://github.com/python/cpython/pull/27313/commits
Checks 0 https://github.com/python/cpython/pull/27313/checks
Files changed https://github.com/python/cpython/pull/27313/files
Please reload this pagehttps://github.com/python/cpython/pull/27313/files
bpo-43950: ensure source_line is present when specializing the traceback https://github.com/python/cpython/pull/27313/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/27313/files
ff5ecbe bpo-43950: ensure source_line is present when specializing the traceback isidentical Jul 23, 2021 https://github.com/python/cpython/pull/27313/commits/ff5ecbe82620600088cf7b0a26c129ec1a0c1bd5
24bab74 add a regression test isidentical Jul 23, 2021 https://github.com/python/cpython/pull/27313/commits/24bab74ac1861a2507a98727aaf68897dfe148d1
8db4e0c use a lower value isidentical Jul 23, 2021 https://github.com/python/cpython/pull/27313/commits/8db4e0c6e97f5f12d92e43790953dc5b462ff9f8
Clear filters https://github.com/python/cpython/pull/27313/files
Please reload this pagehttps://github.com/python/cpython/pull/27313/files
Please reload this pagehttps://github.com/python/cpython/pull/27313/files
test_traceback.py https://github.com/python/cpython/pull/27313/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
traceback.c https://github.com/python/cpython/pull/27313/files#diff-8bca5f3e0435e43986da8b0359c72b3c60915101d3c0c84d27009eb8c15918f7
Lib/test/test_traceback.pyhttps://github.com/python/cpython/pull/27313/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
View file https://github.com/colnotab/cpython/blob/8db4e0c6e97f5f12d92e43790953dc5b462ff9f8/Lib/test/test_traceback.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/27313/{{ revealButtonHref }}
https://github.com/python/cpython/pull/27313/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
https://github.com/python/cpython/pull/27313/files#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
Python/traceback.chttps://github.com/python/cpython/pull/27313/files#diff-8bca5f3e0435e43986da8b0359c72b3c60915101d3c0c84d27009eb8c15918f7
View file https://github.com/colnotab/cpython/blob/8db4e0c6e97f5f12d92e43790953dc5b462ff9f8/Python/traceback.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/27313/{{ revealButtonHref }}
https://github.com/python/cpython/pull/27313/files#diff-8bca5f3e0435e43986da8b0359c72b3c60915101d3c0c84d27009eb8c15918f7
https://github.com/python/cpython/pull/27313/files#diff-8bca5f3e0435e43986da8b0359c72b3c60915101d3c0c84d27009eb8c15918f7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.