René's URL Explorer Experiment


Title: Master by idan22moral · Pull Request #27248 · python/cpython · GitHub

Open Graph Title: Master by idan22moral · Pull Request #27248 · python/cpython

X Title: Master by idan22moral · Pull Request #27248 · python/cpython

Description: This is a follow-up PR to #24402. It should address @gpshead's last comment on the subject: #24402 (comment) Original issue: https://bugs.python.org/issue43086

Open Graph Description: This is a follow-up PR to #24402. It should address @gpshead's last comment on the subject: #24402 (comment) Original issue: https://bugs.python.org/issue43086

X Description: This is a follow-up PR to #24402. It should address @gpshead's last comment on the subject: #24402 (comment) Original issue: https://bugs.python.org/issue43086

Opengraph URL: https://github.com/python/cpython/pull/27248

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:406d47c2-dfe8-0040-6d88-49622a318cad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF56:2F5B11:1A7FB6:24252E:6969D514
html-safe-nonced2aea17dd0b073334e6ee9815c8c0b630aa5e2dd78e72f3ffbec2768feef57c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjU2OjJGNUIxMToxQTdGQjY6MjQyNTJFOjY5NjlENTE0IiwidmlzaXRvcl9pZCI6IjkyNDQ2MDE3ODU4MjY1NjI3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac77ed9b90407a2982a9ed61ec13bbb3681a3e40f1c3f9a70119d82c50e2f61abb
hovercard-subject-tagpull_request:692821512
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/27248/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9627147734c483a08398cfe6f864af3eeba7509f5c42c8cc64b1f1468ba170e/python/cpython/pull/27248
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9627147734c483a08398cfe6f864af3eeba7509f5c42c8cc64b1f1468ba170e/python/cpython/pull/27248
og:image:altThis is a follow-up PR to #24402. It should address @gpshead's last comment on the subject: #24402 (comment) Original issue: https://bugs.python.org/issue43086
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameidan22moral
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/27248#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27248
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27248
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/27248
Reloadhttps://github.com/python/cpython/pull/27248
Reloadhttps://github.com/python/cpython/pull/27248
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/27248
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/27248
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/27248#issue-comment-box
idan22moralhttps://github.com/idan22moral
python:mainhttps://github.com/python/cpython/tree/main
idan22moral:masterhttps://github.com/idan22moral/cpython/tree/master
Master https://github.com/python/cpython/pull/27248#top
idan22moralhttps://github.com/idan22moral
python:mainhttps://github.com/python/cpython/tree/main
idan22moral:masterhttps://github.com/idan22moral/cpython/tree/master
Conversation 0 https://github.com/python/cpython/pull/27248
Commits 29 https://github.com/python/cpython/pull/27248/commits
Checks 0 https://github.com/python/cpython/pull/27248/checks
Files changed https://github.com/python/cpython/pull/27248/files
Please reload this pagehttps://github.com/python/cpython/pull/27248
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/idan22moral
idan22moralhttps://github.com/idan22moral
Jul 19, 2021https://github.com/python/cpython/pull/27248#issue-947905215
#24402https://github.com/python/cpython/pull/24402
@gpsheadhttps://github.com/gpshead
#24402 (comment)https://github.com/python/cpython/pull/24402#issuecomment-882699002
https://bugs.python.org/issue43086https://bugs.python.org/issue43086
Please reload this pagehttps://github.com/python/cpython/pull/27248
idan22moralhttps://github.com/idan22moral
January 31, 2021 18:31https://github.com/python/cpython/pull/27248#commits-pushed-52d83e9
https://github.com/idan22moral
Added handling for excess data in binascii.a2b_base64https://github.com/python/cpython/pull/27248/commits/52d83e9fa67b7b4cd246f34ecac9689b8cdf266d
52d83e9https://github.com/python/cpython/pull/27248/commits/52d83e9fa67b7b4cd246f34ecac9689b8cdf266d
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/27248/commits/557bce8b6bad1387e8f6fc886f9e8fa42c3031bb
557bce8https://github.com/python/cpython/pull/27248/commits/557bce8b6bad1387e8f6fc886f9e8fa42c3031bb
https://github.com/idan22moral
Added if-state guardhttps://github.com/python/cpython/pull/27248/commits/6ed5193a3d302e1200cf729bf5eb88d195c3cd72
6ed5193https://github.com/python/cpython/pull/27248/commits/6ed5193a3d302e1200cf729bf5eb88d195c3cd72
https://github.com/idan22moral
Merge branch 'master' ofhttps://github.com/python/cpython/pull/27248/commits/4ee90f5b89bfd1cc256990a28e4fe83b43de7183
https://github.com/idan22moral/cpythonhttps://github.com/idan22moral/cpython
4ee90f5https://github.com/python/cpython/pull/27248/commits/4ee90f5b89bfd1cc256990a28e4fe83b43de7183
https://github.com/idan22moral
Implemented the strict mode logichttps://github.com/python/cpython/pull/27248/commits/c7b723f4c776be794d3e7626fad62694434e3bb5
c7b723fhttps://github.com/python/cpython/pull/27248/commits/c7b723f4c776be794d3e7626fad62694434e3bb5
https://github.com/idan22moral
Merge branch 'master' ofhttps://github.com/python/cpython/pull/27248/commits/93f497aa218675861df8e3165fcad17a032997aa
https://github.com/python/cpythonhttps://github.com/python/cpython
93f497ahttps://github.com/python/cpython/pull/27248/commits/93f497aa218675861df8e3165fcad17a032997aa
https://github.com/idan22moral
Trying to fix the "Check if generated files are up to date" failurehttps://github.com/python/cpython/pull/27248/commits/f6283d9787f763ee925c9a97e0731d345379be40
f6283d9https://github.com/python/cpython/pull/27248/commits/f6283d9787f763ee925c9a97e0731d345379be40
https://github.com/idan22moral
Generated function signatures using clinichttps://github.com/python/cpython/pull/27248/commits/cedbb856cb14e13fe5bfc7581fcb49653e071869
cedbb85https://github.com/python/cpython/pull/27248/commits/cedbb856cb14e13fe5bfc7581fcb49653e071869
https://github.com/idan22moral
Handle data in the middle of the padding in strict modehttps://github.com/python/cpython/pull/27248/commits/69c96d54e4c1a4992f00cbb0a8f895292b158296
69c96d5https://github.com/python/cpython/pull/27248/commits/69c96d54e4c1a4992f00cbb0a8f895292b158296
https://github.com/idan22moral
Added a test for strict modehttps://github.com/python/cpython/pull/27248/commits/3718ebd1c0ee0a8ec4b38f8884ea7a04290670a4
3718ebdhttps://github.com/python/cpython/pull/27248/commits/3718ebd1c0ee0a8ec4b38f8884ea7a04290670a4
https://github.com/idan22moral
Added a test for invalid data as the first characterhttps://github.com/python/cpython/pull/27248/commits/d0b60e23dd5edaf2efa7a1b10192783381529dd2
d0b60e2https://github.com/python/cpython/pull/27248/commits/d0b60e23dd5edaf2efa7a1b10192783381529dd2
https://github.com/idan22moral
Disallowed leading padding in strict modehttps://github.com/python/cpython/pull/27248/commits/afb95dba830961aceda9070d69eb727405fbdd8d
afb95dbhttps://github.com/python/cpython/pull/27248/commits/afb95dba830961aceda9070d69eb727405fbdd8d
https://github.com/idan22moral
Added tests for padding-only inputhttps://github.com/python/cpython/pull/27248/commits/3c5758b63211d2a8a037db018f0632674b179365
3c5758bhttps://github.com/python/cpython/pull/27248/commits/3c5758b63211d2a8a037db018f0632674b179365
https://github.com/idan22moral
Added tests to validate the default behavior.https://github.com/python/cpython/pull/27248/commits/5f8df5b7768e62919db79e772de027be5206b093
5f8df5bhttps://github.com/python/cpython/pull/27248/commits/5f8df5b7768e62919db79e772de027be5206b093
https://github.com/idan22moral
Described the changed of this pull requesthttps://github.com/python/cpython/pull/27248/commits/644dbaf5871237da50aa08444e60a6a9b119dce9
644dbafhttps://github.com/python/cpython/pull/27248/commits/644dbaf5871237da50aa08444e60a6a9b119dce9
https://github.com/idan22moral
Modified syntax of RSThttps://github.com/python/cpython/pull/27248/commits/464484cd1e51d7db33a8235dbd3e5fe81fbad0fb
464484chttps://github.com/python/cpython/pull/27248/commits/464484cd1e51d7db33a8235dbd3e5fe81fbad0fb
https://github.com/idan22moral
Updated the docs to explain the strict_mode parameterhttps://github.com/python/cpython/pull/27248/commits/e1ccf8aed107746bf52c21f3cf632760dd183ce2
e1ccf8ahttps://github.com/python/cpython/pull/27248/commits/e1ccf8aed107746bf52c21f3cf632760dd183ce2
https://github.com/idan22moral
Moved declaration of state to the beginning to prevent multiple decla…https://github.com/python/cpython/pull/27248/commits/d6a5cbfbc688711f6f53596e1722865455eb7957
d6a5cbfhttps://github.com/python/cpython/pull/27248/commits/d6a5cbfbc688711f6f53596e1722865455eb7957
https://github.com/idan22moral
Merge branch 'main' into masterhttps://github.com/python/cpython/pull/27248/commits/5abc68ff528e8b3f4f31cf40bf14c1bb4628b659
5abc68fhttps://github.com/python/cpython/pull/27248/commits/5abc68ff528e8b3f4f31cf40bf14c1bb4628b659
https://github.com/idan22moral
Corrected the RST syntax for argument in docs (italic)https://github.com/python/cpython/pull/27248/commits/08aa26c3435cbc9f599eab7e5d6a87b717294dbd
08aa26chttps://github.com/python/cpython/pull/27248/commits/08aa26c3435cbc9f599eab7e5d6a87b717294dbd
https://github.com/idan22moral
Corrected the RST syntax for argument in news (italic)https://github.com/python/cpython/pull/27248/commits/2f1990e1e3bc4fcc024ae1fd982221da813b42e9
2f1990ehttps://github.com/python/cpython/pull/27248/commits/2f1990e1e3bc4fcc024ae1fd982221da813b42e9
https://github.com/idan22moral
Removed whitespace that lead to build failurehttps://github.com/python/cpython/pull/27248/commits/fa959bd54f692807a6268f20403b4f56119bf302
fa959bdhttps://github.com/python/cpython/pull/27248/commits/fa959bd54f692807a6268f20403b4f56119bf302
https://github.com/gpshead
use self.assertEqual instead of assert ==https://github.com/python/cpython/pull/27248/commits/a60a8c6ec438763b8403d80fb7130276b649e769
a60a8c6https://github.com/python/cpython/pull/27248/commits/a60a8c6ec438763b8403d80fb7130276b649e769
https://github.com/gpshead
remove leadg | characters in NEWShttps://github.com/python/cpython/pull/27248/commits/03072726fe040ec0057d5d3ac0b995cc58918e35
0307272https://github.com/python/cpython/pull/27248/commits/03072726fe040ec0057d5d3ac0b995cc58918e35
https://github.com/gpshead
Simplify the error messages.https://github.com/python/cpython/pull/27248/commits/d26e1ebc086f50f8bc9f2d1ae85600d8279ca9b1
d26e1ebhttps://github.com/python/cpython/pull/27248/commits/d26e1ebc086f50f8bc9f2d1ae85600d8279ca9b1
https://github.com/gpshead
update test for error message (Leading vs Malformed)https://github.com/python/cpython/pull/27248/commits/652e7f4e6395947c0e558647a7c46c927f544a7f
652e7f4https://github.com/python/cpython/pull/27248/commits/652e7f4e6395947c0e558647a7c46c927f544a7f
https://github.com/idan22moral
Renamed assertLeadingPadding function to match logichttps://github.com/python/cpython/pull/27248/commits/89ecff97a9eba641fbce3a2127c0af4030836698
89ecff9https://github.com/python/cpython/pull/27248/commits/89ecff97a9eba641fbce3a2127c0af4030836698
https://github.com/idan22moral
Added a seperate error message for discontinuous paddinghttps://github.com/python/cpython/pull/27248/commits/9168d3f5153bfaaacb1867b275a5845a2946ae62
9168d3fhttps://github.com/python/cpython/pull/27248/commits/9168d3f5153bfaaacb1867b275a5845a2946ae62
https://github.com/idan22moral
Updated the tests for discontinuous paddinghttps://github.com/python/cpython/pull/27248/commits/6107aaaf2f53a435f8cb4a644e74ca712fec50b0
6107aaahttps://github.com/python/cpython/pull/27248/commits/6107aaaf2f53a435f8cb4a644e74ca712fec50b0
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 19, 2021https://github.com/python/cpython/pull/27248#event-5040027365
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 19, 2021https://github.com/python/cpython/pull/27248#event-5040027426
https://github.com/idan22moral
idan22moralhttps://github.com/idan22moral
Jul 19, 2021https://github.com/python/cpython/pull/27248#event-5040034240
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F27248
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/27248
https://github.com/idan22moral
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/gpshead
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.