René's URL Explorer Experiment


Title: bpo-30971: Improve code readability of json.tool by dhimmel · Pull Request #2720 · python/cpython · GitHub

Open Graph Title: bpo-30971: Improve code readability of json.tool by dhimmel · Pull Request #2720 · python/cpython

X Title: bpo-30971: Improve code readability of json.tool by dhimmel · Pull Request #2720 · python/cpython

Description: Several months ago I worked on pull requests to add new options to the json.tool command line utility. These pull requests are still open, pending further design discussion and consensus on whether to add them: #345 to add indentation / whitespace options (bpo-29636). #201 to display non-ascii characters (bpo-27413). Related, #346 fixed a small testing bug in json.tool and was merged. Since #345 and #201 have been inactive for some time, I wanted to take the non-controversial code changes from those PRs. This PR contains readability improvements and minor refactoring to json.tool. The goal is to get some of the previous work merged and make the json.tool source easier to maintain and enhance going forward. Admittedly, the changes are quite minor.

Open Graph Description: Several months ago I worked on pull requests to add new options to the json.tool command line utility. These pull requests are still open, pending further design discussion and consensus on whether...

X Description: Several months ago I worked on pull requests to add new options to the json.tool command line utility. These pull requests are still open, pending further design discussion and consensus on whether...

Opengraph URL: https://github.com/python/cpython/pull/2720

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5d9f2c96-7764-ce89-469f-f89eccefd65c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD342:1F52F6:9D0D3C:D267DD:6B0045F5
html-safe-nonce2fe9822cbd1f9b72d35915b5e842948c086d56a698e0d55fd4cf94f5e80fe094
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzQyOjFGNTJGNjo5RDBEM0M6RDI2N0REOjZCMDA0NUY1IiwidmlzaXRvcl9pZCI6IjI4NjI5NDk0MjA5MDU4MDkzOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac70008c046701d14832d5a563a22d042cc848d2e5436c4b87e60f8dfa31bb8933
hovercard-subject-tagpull_request:130726124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/2720/files
twitter:imagehttps://avatars.githubusercontent.com/u/1117703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1117703?s=400&v=4
og:image:altSeveral months ago I worked on pull requests to add new options to the json.tool command line utility. These pull requests are still open, pending further design discussion and consensus on whether...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/2720/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2720%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2720%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/2720/files
Reloadhttps://github.com/python/cpython/pull/2720/files
Reloadhttps://github.com/python/cpython/pull/2720/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
dhimmelhttps://github.com/dhimmel
python:masterhttps://github.com/python/cpython/tree/master
dhimmel:json-tool-refactorhttps://github.com/dhimmel/cpython/tree/json-tool-refactor
Conversation 17 https://github.com/python/cpython/pull/2720
Commits 4 https://github.com/python/cpython/pull/2720/commits
Checks 0 https://github.com/python/cpython/pull/2720/checks
Files changed https://github.com/python/cpython/pull/2720/files
Please reload this pagehttps://github.com/python/cpython/pull/2720/files
bpo-30971: Improve code readability of json.tool https://github.com/python/cpython/pull/2720/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/2720/files
5639cb3 json.tool: improve code readability dhimmel Jul 15, 2017 https://github.com/python/cpython/pull/2720/commits/5639cb35d4eb25574442bda8ab5e0ff778296b60
ff3b029 Address https://github.com/python/cpython/pull/2720#pullrequestreview… dhimmel Jul 17, 2017 https://github.com/python/cpython/pull/2720/commits/ff3b0299fe87c64ae50d9f8d42bd795041c666a8
61cbd23 Update --sort-keys help message dhimmel Jul 18, 2017 https://github.com/python/cpython/pull/2720/commits/61cbd236f1f72aae43de5878a9feef7d823a1616
143d63b Remove comments dhimmel Jul 20, 2017 https://github.com/python/cpython/pull/2720/commits/143d63bbb5ad7a55c3ee0db4614c4b12a9a6b461
Clear filters https://github.com/python/cpython/pull/2720/files
Please reload this pagehttps://github.com/python/cpython/pull/2720/files
Please reload this pagehttps://github.com/python/cpython/pull/2720/files
Lib/json/tool.pyhttps://github.com/python/cpython/pull/2720/files#diff-4cb398433fcc0627b9a9a229aca0c7ad949354a4fd508d6ac1892d9d6c279ef7
View file https://github.com/dhimmel/cpython/blob/143d63bbb5ad7a55c3ee0db4614c4b12a9a6b461/Lib/json/tool.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/2720/{{ revealButtonHref }}
https://github.com/python/cpython/pull/2720/files#diff-4cb398433fcc0627b9a9a229aca0c7ad949354a4fd508d6ac1892d9d6c279ef7
https://github.com/python/cpython/pull/2720/files#diff-4cb398433fcc0627b9a9a229aca0c7ad949354a4fd508d6ac1892d9d6c279ef7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.